Changeset 84516 in webkit


Ignore:
Timestamp:
Apr 21, 2011 10:24:19 AM (13 years ago)
Author:
leviw@chromium.org
Message:

2011-04-21 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

position fixed element does not render properly when dynamically updated via javascript
https://bugs.webkit.org/show_bug.cgi?id=54297

Disabling the LayoutState fast-path for fixed-position content.

Tests: fast/repaint/fixed-contents-changed-after-scroll.html

fast/repaint/transformed-contents-changed-after-scroll.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):

2011-04-21 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

position fixed element does not render properly when dynamically updated via javascript
https://bugs.webkit.org/show_bug.cgi?id=54297

Disabling the LayoutState fast-path for fixed-position content.

  • fast/repaint/fixed-contents-changed-after-scroll.html: Added.
  • fast/repaint/transformed-contents-changed-after-scroll.html: Added.
  • platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.txt: Added.
  • platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r84513 r84516  
     12011-04-21  Levi Weintraub  <leviw@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        position fixed element does not render properly when dynamically updated via javascript
     6        https://bugs.webkit.org/show_bug.cgi?id=54297
     7
     8        Disabling the LayoutState fast-path for fixed-position content.
     9
     10        * fast/repaint/fixed-contents-changed-after-scroll.html: Added.
     11        * fast/repaint/transformed-contents-changed-after-scroll.html: Added.
     12        * platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.checksum: Added.
     13        * platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.png: Added.
     14        * platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.txt: Added.
     15        * platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.checksum: Added.
     16        * platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.png: Added.
     17        * platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.txt: Added.
     18
    1192011-04-21  Tony Chang  <tony@chromium.org>
    220
  • trunk/Source/WebCore/ChangeLog

    r84512 r84516  
     12011-04-21  Levi Weintraub  <leviw@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        position fixed element does not render properly when dynamically updated via javascript
     6        https://bugs.webkit.org/show_bug.cgi?id=54297
     7
     8        Disabling the LayoutState fast-path for fixed-position content.
     9
     10        Tests: fast/repaint/fixed-contents-changed-after-scroll.html
     11               fast/repaint/transformed-contents-changed-after-scroll.html
     12
     13        * rendering/RenderBox.cpp:
     14        (WebCore::RenderBox::computeRectForRepaint):
     15
    1162011-04-20  Matthew Delaney  <mdelaney@apple.com>
    217
  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r84504 r84516  
    14331433    // physical coordinate space of the repaintContainer.
    14341434    if (RenderView* v = view()) {
    1435         // LayoutState is only valid for root-relative repainting
    1436         if (v->layoutStateEnabled() && !repaintContainer) {
     1435        // LayoutState is only valid for root-relative, non-fixed position repainting
     1436        if (v->layoutStateEnabled() && !repaintContainer && style()->position() != FixedPosition) {
    14371437            LayoutState* layoutState = v->layoutState();
    14381438
Note: See TracChangeset for help on using the changeset viewer.