Changeset 84640 in webkit

Timestamp:

Apr 22, 2011 10:25:50 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-22 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium]Mac UI polish to add left/right padding space for autofill popup window.
​https://bugs.webkit.org/show_bug.cgi?id=58960
​http://code.google.com/p/chromium/issues/detail?id=51077

No new test because Chromium Autofill popup window doesn't have any test framework.
This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
Only if Autofill popup window has right/left padding.
The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.

• rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
• rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified. (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderThemeChromiumMac.h (modified) (1 diff)
• rendering/RenderThemeChromiumMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-22  Naoki Takano  <takano.naoki@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        [Chromium]Mac UI polish to add left/right padding space for autofill popup window.
+        https://bugs.webkit.org/show_bug.cgi?id=58960
+        http://code.google.com/p/chromium/issues/detail?id=51077
+
+        No new test because Chromium Autofill popup window doesn't have any test framework.
+        This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
+        Only if Autofill popup window has right/left padding.
+        The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.
+
+        * rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
+        * rendering/RenderThemeChromiumMac.mm:
+        (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified.
+        (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.
+
 2011-04-21  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebCore/rendering/RenderThemeChromiumMac.h

@@ -55 +55 @@
     virtual bool usesTestModeFocusRingColor() const;
     virtual NSView* documentViewFor(RenderObject*) const;
+
+    virtual int popupInternalPaddingLeft(RenderStyle*) const;
+    virtual int popupInternalPaddingRight(RenderStyle*) const;
 private:
     virtual void updateActiveState(NSCell*, const RenderObject*);

trunk/Source/WebCore/rendering/RenderThemeChromiumMac.mm

@@ -78 +78 @@
 {
     return FlippedView();
+}
+
+const int autofillPopupHorizontalPadding = 4;
+
+// These functions are called with MenuListPart or MenulistButtonPart appearance by RenderMenuList, or with TextFieldPart appearance by AutofillPopupMenuClient.
+// We assume only AutofillPopupMenuClient gives TexfieldPart appearance here.
+// We want to change only Autofill padding.
+// In the future, we have to separate Autofill popup window logic from WebKit to Chromium.
+int RenderThemeChromiumMac::popupInternalPaddingLeft(RenderStyle* style) const
+{
+    if (style->appearance() == TextFieldPart)
+        return autofillPopupHorizontalPadding;
+
+    return RenderThemeMac::popupInternalPaddingLeft(style);
+}
+
+int RenderThemeChromiumMac::popupInternalPaddingRight(RenderStyle* style) const
+{
+    if (style->appearance() == TextFieldPart)
+        return autofillPopupHorizontalPadding;
+
+    return RenderThemeMac::popupInternalPaddingRight(style);
 }