Changeset 84693 in webkit

Timestamp:

Apr 22, 2011 3:36:46 PM (13 years ago)

Author:

yael.aharon@nokia.com

Message:

2011-04-22 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Sam Weinig.

HTMLFormControlElement::labels should allow custom attributes.
​https://bugs.webkit.org/show_bug.cgi?id=59128

• fast/forms/labels-custom-property-expected.txt: Added.
• fast/forms/labels-custom-property.html: Added.

2011-04-22 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Sam Weinig.

HTMLFormControlElement::labels should allow custom attributes.
​https://bugs.webkit.org/show_bug.cgi?id=59128

Cache the labels list when it is created and keep using it for future
labels calls.

Test: fast/forms/labels-custom-property.html

• html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/labels-custom-property-expected.txt (added)
• LayoutTests/fast/forms/labels-custom-property.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/NodeRareData.h (modified) (2 diffs)
• Source/WebCore/html/HTMLFormControlElement.cpp (modified) (1 diff)
• Source/WebCore/html/LabelsNodeList.cpp (modified) (1 diff)
• Source/WebCore/html/LabelsNodeList.h (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-22  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Sam Weinig.
+
+        HTMLFormControlElement::labels should allow custom attributes.
+        https://bugs.webkit.org/show_bug.cgi?id=59128
+
+        * fast/forms/labels-custom-property-expected.txt: Added.
+        * fast/forms/labels-custom-property.html: Added.
+
 2011-04-22  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-22  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Sam Weinig.
+
+        HTMLFormControlElement::labels should allow custom attributes.
+        https://bugs.webkit.org/show_bug.cgi?id=59128
+
+        Cache the labels list when it is created and keep using it for future
+        labels calls.
+
+        Test: fast/forms/labels-custom-property.html
+
+        * html/HTMLFormControlElement.cpp:
+        (WebCore::HTMLFormControlElement::labels):
+
 2011-04-22  Adrienne Walker  <enne@google.com>
 

trunk/Source/WebCore/dom/NodeRareData.h

@@ -35 +35 @@
 namespace WebCore {
 
+class LabelsNodeList;
 class TreeScope;
 
@@ -57 +58 @@
     TagNodeListCacheNS m_tagNodeListCacheNS;
  
-    RefPtr<DynamicNodeList> m_labelsNodeListCache;
+    LabelsNodeList* m_labelsNodeListCache;
  
     static PassOwnPtr<NodeListsNodeData> create()

trunk/Source/WebCore/html/HTMLFormControlElement.cpp

@@ -472 +472 @@
     }
 
-    return LabelsNodeList::create(this);
+    if (data->nodeLists()->m_labelsNodeListCache)
+        return data->nodeLists()->m_labelsNodeListCache;
+
+    RefPtr<LabelsNodeList> list = LabelsNodeList::create(this);
+    data->nodeLists()->m_labelsNodeListCache = list.get();
+    return list.release();
 }
 

trunk/Source/WebCore/html/LabelsNodeList.cpp

@@ -33 +33 @@
 using namespace HTMLNames;
 
-LabelsNodeList::LabelsNodeList(PassRefPtr<Node> forNode )
+LabelsNodeList::LabelsNodeList(Node* forNode )
     : DynamicNodeList(forNode->document()) , m_forNode(forNode)
 {

trunk/Source/WebCore/html/LabelsNodeList.h

@@ -33 +33 @@
 class LabelsNodeList : public DynamicNodeList {
 public:
-    static PassRefPtr<LabelsNodeList> create(PassRefPtr<Node> forNode)
+    static PassRefPtr<LabelsNodeList> create(Node* forNode)
     {
         return adoptRef(new LabelsNodeList(forNode));
@@ -40 +40 @@
 
 protected:
-    LabelsNodeList(PassRefPtr<Node> forNode);
+    LabelsNodeList(Node* forNode);
 
     virtual bool nodeMatches(Element*) const;