Changeset 84732 in webkit


Ignore:
Timestamp:
Apr 22, 2011 8:20:07 PM (13 years ago)
Author:
Nate Chapin
Message:

2011-04-22 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Don't use XMLTreeViewer when script is disabled (it uses Javascript
to build a prettified version of the xml document).
https://bugs.webkit.org/show_bug.cgi?id=59113

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r84731 r84732  
     12011-04-22  Nate Chapin  <japhet@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Don't use XMLTreeViewer when script is disabled (it uses Javascript
     6        to build a prettified version of the xml document).
     7        https://bugs.webkit.org/show_bug.cgi?id=59113
     8
     9        * xml/XMLTreeViewer.cpp:
     10        (WebCore::XMLTreeViewer::transformDocumentToTreeView):
     11
    1122011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
    213
  • trunk/Source/WebCore/xml/XMLTreeViewer.cpp

    r84371 r84732  
    7070void XMLTreeViewer::transformDocumentToTreeView()
    7171{
     72    // FIXME: Temporary hack to ensure that we still display some of the document (and don't crash)
     73    // when script is disabled. See https://bugs.webkit.org/show_bug.cgi?id=59113 for work on a
     74    // better solution.
     75    if (!m_document->frame()->script()->canExecuteScripts(NotAboutToExecuteScript))
     76        return;
     77
    7278    String scriptString(reinterpret_cast<const char*>(XMLViewer_js), sizeof(XMLViewer_js));
    7379    m_document->frame()->script()->evaluate(ScriptSourceCode(scriptString));
Note: See TracChangeset for help on using the changeset viewer.