Changeset 84815 in webkit
- Timestamp:
- Apr 25, 2011 3:54:02 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r84814 r84815 1 2011-04-25 James Robinson <jamesr@chromium.org> 2 3 Reviewed by Adam Barth. 4 5 Fix strict OwnPtr violations in Render*.cpp 6 https://bugs.webkit.org/show_bug.cgi?id=59361 7 8 * rendering/RenderBlock.cpp: 9 (WebCore::RenderBlock::RenderBlock): 10 (WebCore::RenderBlock::finishDelayUpdateScrollInfo): 11 * rendering/RenderBox.cpp: 12 (WebCore::RenderBox::addLayoutOverflow): 13 (WebCore::RenderBox::addVisualOverflow): 14 * rendering/RenderButton.cpp: 15 (WebCore::RenderButton::styleDidChange): 16 * rendering/RenderLayer.cpp: 17 (WebCore::RenderLayer::updateTransform): 18 (WebCore::RenderLayer::paintChildLayerIntoColumns): 19 (WebCore::RenderLayer::hitTestChildLayerColumns): 20 (WebCore::RenderLayer::ensureBacking): 21 * rendering/RenderTable.cpp: 22 (WebCore::RenderTable::styleDidChange): 23 * rendering/RenderView.cpp: 24 (WebCore::RenderView::compositor): 25 * rendering/style/RenderStyle.cpp: 26 (WebCore::RenderStyle::addCachedPseudoStyle): 27 (WebCore::RenderStyle::accessCounterDirectives): 28 (WebCore::RenderStyle::accessAnimations): 29 (WebCore::RenderStyle::accessTransitions): 30 * rendering/svg/RenderSVGResourceFilter.cpp: 31 (WebCore::RenderSVGResourceFilter::applyResource): 32 * rendering/svg/SVGResources.cpp: 33 (WebCore::SVGResources::SVGResources): 34 1 35 2011-04-25 Adam Barth <abarth@webkit.org> 2 36 -
trunk/Source/WebCore/rendering/RenderBlock.cpp
r84589 r84815 113 113 RenderBlock::RenderBlock(Node* node) 114 114 : RenderBox(node) 115 , m_floatingObjects(0)116 , m_positionedObjects(0)117 , m_rareData(0)118 115 , m_lineHeight(-1) 119 116 , m_beingDestroyed(false) … … 1093 1090 ASSERT(gDelayedUpdateScrollInfoSet); 1094 1091 1095 OwnPtr<DelayedUpdateScrollInfoSet> infoSet( gDelayedUpdateScrollInfoSet);1092 OwnPtr<DelayedUpdateScrollInfoSet> infoSet(adoptPtr(gDelayedUpdateScrollInfoSet)); 1096 1093 gDelayedUpdateScrollInfoSet = 0; 1097 1094 -
trunk/Source/WebCore/rendering/RenderBox.cpp
r84516 r84815 3270 3270 3271 3271 if (!m_overflow) 3272 m_overflow .set(new RenderOverflow(clientBox, borderBoxRect()));3272 m_overflow = adoptPtr(new RenderOverflow(clientBox, borderBoxRect())); 3273 3273 3274 3274 m_overflow->addLayoutOverflow(overflowRect); … … 3282 3282 3283 3283 if (!m_overflow) 3284 m_overflow .set(new RenderOverflow(clientBoxRect(), borderBox));3284 m_overflow = adoptPtr(new RenderOverflow(clientBoxRect(), borderBox)); 3285 3285 3286 3286 m_overflow->addVisualOverflow(rect); -
trunk/Source/WebCore/rendering/RenderButton.cpp
r75537 r84815 96 96 if (!m_default && theme()->isDefault(this)) { 97 97 if (!m_timer) 98 m_timer .set(new Timer<RenderButton>(this, &RenderButton::timerFired));98 m_timer = adoptPtr(new Timer<RenderButton>(this, &RenderButton::timerFired)); 99 99 m_timer->startRepeating(0.03); 100 100 m_default = true; -
trunk/Source/WebCore/rendering/RenderLayer.cpp
r84538 r84815 427 427 if (hasTransform != hadTransform) { 428 428 if (hasTransform) 429 m_transform .set(new TransformationMatrix);429 m_transform = adoptPtr(new TransformationMatrix); 430 430 else 431 431 m_transform.clear(); … … 2765 2765 newTransform.translateRight(offset.width(), offset.height()); 2766 2766 2767 childLayer->m_transform .set(new TransformationMatrix(newTransform));2767 childLayer->m_transform = adoptPtr(new TransformationMatrix(newTransform)); 2768 2768 childLayer->paintLayer(rootLayer, context, localDirtyRect, paintBehavior, paintingRoot, overlapTestRequests, paintFlags); 2769 2769 if (oldHasTransform) 2770 childLayer->m_transform .set(new TransformationMatrix(oldTransform));2770 childLayer->m_transform = adoptPtr(new TransformationMatrix(oldTransform)); 2771 2771 else 2772 2772 childLayer->m_transform.clear(); … … 3249 3249 newTransform.translateRight(offset.width(), offset.height()); 3250 3250 3251 childLayer->m_transform .set(new TransformationMatrix(newTransform));3251 childLayer->m_transform = adoptPtr(new TransformationMatrix(newTransform)); 3252 3252 hitLayer = childLayer->hitTestLayer(rootLayer, columnLayers[0], request, result, localClipRect, hitTestPoint, false, transformState, zOffset); 3253 3253 if (oldHasTransform) 3254 childLayer->m_transform .set(new TransformationMatrix(oldTransform));3254 childLayer->m_transform = adoptPtr(new TransformationMatrix(oldTransform)); 3255 3255 else 3256 3256 childLayer->m_transform.clear(); … … 3610 3610 { 3611 3611 if (!m_backing) 3612 m_backing .set(new RenderLayerBacking(this));3612 m_backing = adoptPtr(new RenderLayerBacking(this)); 3613 3613 return m_backing.get(); 3614 3614 } -
trunk/Source/WebCore/rendering/RenderTable.cpp
r82123 r84815 86 86 // explicit width is specified on the table. Auto width implies auto table layout. 87 87 if (style()->tableLayout() == TFIXED && !style()->logicalWidth().isAuto()) 88 m_tableLayout .set(new FixedTableLayout(this));88 m_tableLayout = adoptPtr(new FixedTableLayout(this)); 89 89 else 90 m_tableLayout .set(new AutoTableLayout(this));90 m_tableLayout = adoptPtr(new AutoTableLayout(this)); 91 91 } 92 92 } -
trunk/Source/WebCore/rendering/RenderView.cpp
r84454 r84815 783 783 { 784 784 if (!m_compositor) 785 m_compositor .set(new RenderLayerCompositor(this));785 m_compositor = adoptPtr(new RenderLayerCompositor(this)); 786 786 787 787 return m_compositor.get(); -
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
r84273 r84815 251 251 252 252 if (!m_cachedPseudoStyles) 253 m_cachedPseudoStyles .set(new PseudoStyleCache);253 m_cachedPseudoStyles = adoptPtr(new PseudoStyleCache); 254 254 255 255 m_cachedPseudoStyles->append(pseudo); … … 850 850 OwnPtr<CounterDirectiveMap>& map = rareNonInheritedData.access()->m_counterDirectives; 851 851 if (!map) 852 map .set(new CounterDirectiveMap);853 return *map .get();852 map = adoptPtr(new CounterDirectiveMap); 853 return *map; 854 854 } 855 855 … … 997 997 { 998 998 if (!rareNonInheritedData.access()->m_animations) 999 rareNonInheritedData.access()->m_animations .set(new AnimationList());999 rareNonInheritedData.access()->m_animations = adoptPtr(new AnimationList()); 1000 1000 return rareNonInheritedData->m_animations.get(); 1001 1001 } … … 1004 1004 { 1005 1005 if (!rareNonInheritedData.access()->m_transitions) 1006 rareNonInheritedData.access()->m_transitions .set(new AnimationList());1006 rareNonInheritedData.access()->m_transitions = adoptPtr(new AnimationList()); 1007 1007 return rareNonInheritedData->m_transitions.get(); 1008 1008 } -
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
r84101 r84815 154 154 } 155 155 156 OwnPtr<FilterData> filterData( new FilterData);156 OwnPtr<FilterData> filterData(adoptPtr(new FilterData)); 157 157 FloatRect targetBoundingBox = object->objectBoundingBox(); 158 158 -
trunk/Source/WebCore/rendering/svg/SVGResources.cpp
r79985 r84815 37 37 38 38 SVGResources::SVGResources() 39 : m_clipperFilterMaskerData(0) 40 , m_markerData(0) 41 , m_fillStrokeData(0) 42 , m_linkedResource(0) 39 : m_linkedResource(0) 43 40 { 44 41 }
Note: See TracChangeset
for help on using the changeset viewer.