Changeset 84877 in webkit

Timestamp:

Apr 25, 2011 10:05:05 PM (13 years ago)

Author:

jamesr@google.com

Message:

2011-04-25 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=59377

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): (WebCore::PropertyWrapperShadow::blend):
• rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): (WebCore::RenderStyle::setBoxShadow):
• rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textShadow):
• rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
• rendering/style/StyleRareInheritedData.h:
• rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSStyleSelector.cpp (modified) (1 diff)
• page/animation/AnimationBase.cpp (modified) (4 diffs)
• rendering/style/RenderStyle.cpp (modified) (1 diff)
• rendering/style/RenderStyle.h (modified) (3 diffs)
• rendering/style/StyleRareInheritedData.cpp (modified) (3 diffs)
• rendering/style/StyleRareInheritedData.h (modified) (1 diff)
• rendering/style/StyleRareNonInheritedData.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-25  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
+        https://bugs.webkit.org/show_bug.cgi?id=59377
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::applyProperty):
+        * page/animation/AnimationBase.cpp:
+        (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
+        (WebCore::PropertyWrapperShadow::blend):
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::setTextShadow):
+        (WebCore::RenderStyle::setBoxShadow):
+        * rendering/style/RenderStyle.h:
+        (WebCore::InheritedFlags::textShadow):
+        * rendering/style/StyleRareInheritedData.cpp:
+        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
+        (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
+        * rendering/style/StyleRareInheritedData.h:
+        * rendering/style/StyleRareNonInheritedData.cpp:
+        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
+
 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/css/CSSStyleSelector.cpp

@@ -5146 +5146 @@
             if (id == CSSPropertyTextShadow)
                 return m_style->setTextShadow(m_parentStyle->textShadow() ? new ShadowData(*m_parentStyle->textShadow()) : 0);
-            return m_style->setBoxShadow(m_parentStyle->boxShadow() ? new ShadowData(*m_parentStyle->boxShadow()) : 0);
+            return m_style->setBoxShadow(m_parentStyle->boxShadow() ? adoptPtr(new ShadowData(*m_parentStyle->boxShadow())) : PassOwnPtr<ShadowData>());
         }
         if (isInitial || primitiveValue) // initial | none

trunk/Source/WebCore/page/animation/AnimationBase.cpp

@@ -330 +330 @@
 class PropertyWrapperShadow : public PropertyWrapperBase {
 public:
-    PropertyWrapperShadow(int prop, const ShadowData* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(ShadowData*, bool))
+    PropertyWrapperShadow(int prop, const ShadowData* (RenderStyle::*getter)() const, void (RenderStyle::*setter)(PassOwnPtr<ShadowData>, bool))
         : PropertyWrapperBase(prop)
         , m_getter(getter)
@@ -366 +366 @@
         ShadowData defaultInsetShadowData(0, 0, 0, 0, Inset, property() == CSSPropertyWebkitBoxShadow, Color::transparent);
 
-        ShadowData* newShadowData = 0;
+        OwnPtr<ShadowData> newShadowData;
         ShadowData* lastShadow = 0;
         
@@ -375 +375 @@
             ShadowData* blendedShadow = blendFunc(anim, srcShadow, dstShadow, progress);
             if (!lastShadow)
-                newShadowData = blendedShadow;
+                newShadowData = adoptPtr(blendedShadow);
             else
                 lastShadow->setNext(blendedShadow);
@@ -385 +385 @@
         }
         
-        (dst->*m_setter)(newShadowData, false);
+        (dst->*m_setter)(newShadowData.release(), false);
     }
 
 private:
     const ShadowData* (RenderStyle::*m_getter)() const;
-    void (RenderStyle::*m_setter)(ShadowData*, bool);
+    void (RenderStyle::*m_setter)(PassOwnPtr<ShadowData>, bool);
 };
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -729 +729 @@
 }
 
-void RenderStyle::setTextShadow(ShadowData* val, bool add)
-{
-    ASSERT(!val || (!val->spread() && val->style() == Normal));
+void RenderStyle::setTextShadow(PassOwnPtr<ShadowData> shadowData, bool add)
+{
+    ASSERT(!shadowData || (!shadowData->spread() && shadowData->style() == Normal));
 
     StyleRareInheritedData* rareData = rareInheritedData.access();
     if (!add) {
-        delete rareData->textShadow;
-        rareData->textShadow = val;
+        rareData->textShadow = shadowData;
         return;
     }
 
-    val->setNext(rareData->textShadow);
-    rareData->textShadow = val;
-}
-
-void RenderStyle::setBoxShadow(ShadowData* shadowData, bool add)
+    rareData->textShadow = shadowData;
+}
+
+void RenderStyle::setBoxShadow(PassOwnPtr<ShadowData> shadowData, bool add)
 {
     StyleRareNonInheritedData* rareData = rareNonInheritedData.access();
     if (!add) {
-        rareData->m_boxShadow.set(shadowData);
+        rareData->m_boxShadow = shadowData;
         return;
     }
 
     shadowData->setNext(rareData->m_boxShadow.leakPtr());
-    rareData->m_boxShadow.set(shadowData);
+    rareData->m_boxShadow = shadowData;
 }
 

trunk/Source/WebCore/rendering/style/RenderStyle.h

@@ -651 +651 @@
     }
 
-    const ShadowData* textShadow() const { return rareInheritedData->textShadow; }
+    const ShadowData* textShadow() const { return rareInheritedData->textShadow.get(); }
     void getTextShadowExtent(int& top, int& right, int& bottom, int& left) const { getShadowExtent(textShadow(), top, right, bottom, left); }
     void getTextShadowHorizontalExtent(int& left, int& right) const { getShadowHorizontalExtent(textShadow(), left, right); }
@@ -1020 +1020 @@
     // CSS3 Setters
     void setOutlineOffset(int v) { SET_VAR(m_background, m_outline.m_offset, v) }
-    void setTextShadow(ShadowData* val, bool add=false);
+    void setTextShadow(PassOwnPtr<ShadowData>, bool add = false);
     void setTextStrokeColor(const Color& c) { SET_VAR(rareInheritedData, textStrokeColor, c) }
     void setTextStrokeWidth(float w) { SET_VAR(rareInheritedData, textStrokeWidth, w) }
@@ -1035 +1035 @@
     void setBoxOrient(EBoxOrient o) { SET_VAR(rareNonInheritedData.access()->flexibleBox, orient, o); }
     void setBoxPack(EBoxAlignment p) { SET_VAR(rareNonInheritedData.access()->flexibleBox, pack, p); }
-    void setBoxShadow(ShadowData* val, bool add=false);
+    void setBoxShadow(PassOwnPtr<ShadowData>, bool add = false);
     void setBoxReflect(PassRefPtr<StyleReflection> reflect) { if (rareNonInheritedData->m_boxReflect != reflect) rareNonInheritedData.access()->m_boxReflect = reflect; }
     void setBoxSizing(EBoxSizing s) { SET_VAR(m_box, m_boxSizing, s); }

trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp

@@ -33 +33 @@
 StyleRareInheritedData::StyleRareInheritedData()
     : textStrokeWidth(RenderStyle::initialTextStrokeWidth())
-    , textShadow(0)
     , indent(RenderStyle::initialTextIndent())
     , m_effectiveZoom(RenderStyle::initialZoom())
@@ -65 +64 @@
     , textFillColor(o.textFillColor)
     , textEmphasisColor(o.textEmphasisColor)
-    , textShadow(o.textShadow ? new ShadowData(*o.textShadow) : 0)
+    , textShadow(o.textShadow ? adoptPtr(new ShadowData(*o.textShadow)) : 0)
     , highlight(o.highlight)
     , cursorData(o.cursorData)
@@ -98 +97 @@
 StyleRareInheritedData::~StyleRareInheritedData()
 {
-    delete textShadow;
 }
 

trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h

@@ -59 +59 @@
     Color textEmphasisColor;
 
-    ShadowData* textShadow; // Our text shadow information for shadowed text drawing.
+    OwnPtr<ShadowData> textShadow; // Our text shadow information for shadowed text drawing.
     AtomicString highlight; // Apple-specific extension for custom highlight rendering.
     

trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp

@@ -35 +35 @@
     : lineClamp(RenderStyle::initialLineClamp())
     , opacity(RenderStyle::initialOpacity())
-    , m_content(0)
-    , m_counterDirectives(0)
     , userDrag(RenderStyle::initialUserDrag())
     , textOverflow(RenderStyle::initialTextOverflow())
@@ -50 +48 @@
     , m_runningAcceleratedAnimation(false)
 #endif
-    , m_boxShadow(0)
-    , m_animations(0)
-    , m_transitions(0)
     , m_mask(FillLayer(MaskFillLayer))
     , m_transformStyle3D(RenderStyle::initialTransformStyle3D())
@@ -72 +67 @@
     , m_multiCol(o.m_multiCol)
     , m_transform(o.m_transform)
-    , m_content(0)
-    , m_counterDirectives(0)
     , userDrag(o.userDrag)
     , textOverflow(o.textOverflow)
@@ -87 +80 @@
     , m_runningAcceleratedAnimation(o.m_runningAcceleratedAnimation)
 #endif
-    , m_boxShadow(o.m_boxShadow ? new ShadowData(*o.m_boxShadow) : 0)
+    , m_boxShadow(o.m_boxShadow ? adoptPtr(new ShadowData(*o.m_boxShadow)) : PassOwnPtr<ShadowData>())
     , m_boxReflect(o.m_boxReflect)
-    , m_animations(o.m_animations ? new AnimationList(*o.m_animations) : 0)
-    , m_transitions(o.m_transitions ? new AnimationList(*o.m_transitions) : 0)
+    , m_animations(o.m_animations ? adoptPtr(new AnimationList(*o.m_animations)) : PassOwnPtr<AnimationList>())
+    , m_transitions(o.m_transitions ? adoptPtr(new AnimationList(*o.m_transitions)) : PassOwnPtr<AnimationList>())
     , m_mask(o.m_mask)
     , m_maskBoxImage(o.m_maskBoxImage)