Changeset 84890 in webkit
- Timestamp:
- Apr 26, 2011 12:27:39 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 18 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r84888 r84890 1 2011-04-26 Adam Barth <abarth@webkit.org> 2 3 Reviewed by David Levin. 4 5 Fix more strict OwnPtr violations in WebCore 6 https://bugs.webkit.org/show_bug.cgi?id=59433 7 8 These manifest in the Chromium build. 9 10 * bindings/v8/ScriptController.cpp: 11 (WebCore::ScriptController::ScriptController): 12 * bindings/v8/ScriptDebugServer.cpp: 13 (WebCore::ScriptDebugServer::editScriptSource): 14 * bindings/v8/V8DOMMap.cpp: 15 (WebCore::DOMDataStoreHandle::DOMDataStoreHandle): 16 * bindings/v8/V8Proxy.cpp: 17 (WebCore::V8Proxy::precompileScript): 18 * bindings/v8/WorkerScriptController.cpp: 19 (WebCore::WorkerScriptController::WorkerScriptController): 20 * page/Page.cpp: 21 (WebCore::Page::Page): 22 (WebCore::Page::speechInput): 23 * platform/PlatformGestureRecognizer.cpp: 24 (WebCore::PlatformGestureRecognizer::create): 25 * platform/PlatformGestureRecognizer.h: 26 * platform/graphics/chromium/DrawingBufferChromium.cpp: 27 (WebCore::DrawingBuffer::DrawingBuffer): 28 * platform/graphics/chromium/cc/CCLayerImpl.cpp: 29 (WebCore::CCLayerImpl::CCLayerImpl): 30 * platform/graphics/gpu/Texture.cpp: 31 (WebCore::Texture::create): 32 * platform/image-decoders/bmp/BMPImageDecoder.cpp: 33 (WebCore::BMPImageDecoder::decodeHelper): 34 * platform/image-decoders/gif/GIFImageDecoder.cpp: 35 (WebCore::GIFImageDecoder::decode): 36 * platform/image-decoders/ico/ICOImageDecoder.cpp: 37 (WebCore::ICOImageDecoder::decodeAtIndex): 38 * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: 39 (WebCore::JPEGImageDecoder::decode): 40 * platform/image-decoders/png/PNGImageDecoder.cpp: 41 (WebCore::PNGImageDecoder::decode): 42 * storage/chromium/DatabaseTrackerChromium.cpp: 43 (WebCore::DatabaseTracker::addOpenDatabase): 44 1 45 2011-04-25 David Levin <levin@chromium.org> 2 46 -
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
r79981 r84890 113 113 , m_paused(false) 114 114 , m_allowPopupsFromPlugin(false) 115 , m_proxy( new V8Proxy(frame))115 , m_proxy(adoptPtr(new V8Proxy(frame))) 116 116 #if ENABLE(NETSCAPE_PLUGIN_API) 117 117 , m_windowScriptNPObject(0) -
trunk/Source/WebCore/bindings/v8/ScriptDebugServer.cpp
r83601 r84890 219 219 OwnPtr<v8::Context::Scope> contextScope; 220 220 if (!isPaused()) 221 contextScope .set(new v8::Context::Scope(v8::Debug::GetDebugContext()));221 contextScope = adoptPtr(new v8::Context::Scope(v8::Debug::GetDebugContext())); 222 222 223 223 v8::Handle<v8::Function> function = v8::Local<v8::Function>::Cast(m_debuggerScript.get()->Get(v8::String::New("editScriptSource"))); -
trunk/Source/WebCore/bindings/v8/V8DOMMap.cpp
r73907 r84890 40 40 41 41 DOMDataStoreHandle::DOMDataStoreHandle() 42 : m_store( new ScopedDOMDataStore(DOMData::getCurrent()))42 : m_store(adoptPtr(new ScopedDOMDataStore(DOMData::getCurrent()))) 43 43 { 44 44 } -
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
r84371 r84890 322 322 return v8::ScriptData::New(cachedMetadata->data(), cachedMetadata->size()); 323 323 324 OwnPtr<v8::ScriptData> scriptData (v8::ScriptData::PreCompile(code));324 OwnPtr<v8::ScriptData> scriptData = adoptPtr(v8::ScriptData::PreCompile(code)); 325 325 cachedScript->setCachedMetadata(dataTypeID, scriptData->Data(), scriptData->Length()); 326 326 -
trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp
r83900 r84890 52 52 WorkerScriptController::WorkerScriptController(WorkerContext* workerContext) 53 53 : m_workerContext(workerContext) 54 , m_proxy( new WorkerContextExecutionProxy(workerContext))54 , m_proxy(adoptPtr(new WorkerContextExecutionProxy(workerContext))) 55 55 , m_executionForbidden(false) 56 56 { -
trunk/Source/WebCore/page/Page.cpp
r84822 r84890 133 133 #endif 134 134 #if ENABLE(DEVICE_ORIENTATION) 135 , m_deviceMotionController(RuntimeEnabledFeatures::deviceMotionEnabled() ? new DeviceMotionController(pageClients.deviceMotionClient) : 0)136 , m_deviceOrientationController(RuntimeEnabledFeatures::deviceOrientationEnabled() ? new DeviceOrientationController(this, pageClients.deviceOrientationClient) : 0)135 , m_deviceMotionController(RuntimeEnabledFeatures::deviceMotionEnabled() ? adoptPtr(new DeviceMotionController(pageClients.deviceMotionClient)) : PassOwnPtr<DeviceMotionController>()) 136 , m_deviceOrientationController(RuntimeEnabledFeatures::deviceOrientationEnabled() ? adoptPtr(new DeviceOrientationController(this, pageClients.deviceOrientationClient)) : PassOwnPtr<DeviceOrientationController>()) 137 137 #endif 138 138 #if ENABLE(INPUT_SPEECH) … … 846 846 ASSERT(m_speechInputClient); 847 847 if (!m_speechInput.get()) 848 m_speechInput .set(new SpeechInput(m_speechInputClient));848 m_speechInput = adoptPtr(new SpeechInput(m_speechInputClient)); 849 849 return m_speechInput.get(); 850 850 } -
trunk/Source/WebCore/platform/PlatformGestureRecognizer.cpp
r81618 r84890 39 39 // To get a useful GestureRecognizer, a specific platform should return something 40 40 // here that meets its needs. EventHandler will ignore null GestureRecognizers. 41 P latformGestureRecognizer*PlatformGestureRecognizer::create()41 PassOwnPtr<PlatformGestureRecognizer> PlatformGestureRecognizer::create() 42 42 { 43 return 0;43 return PassOwnPtr<PlatformGestureRecognizer>(); 44 44 } 45 45 -
trunk/Source/WebCore/platform/PlatformGestureRecognizer.h
r81618 r84890 32 32 #define PlatformGestureRecognizer_h 33 33 34 #include <wtf/PassOwnPtr.h> 35 34 36 namespace WebCore { 35 37 … … 47 49 48 50 public: 51 static PassOwnPtr<PlatformGestureRecognizer> create(); 49 52 virtual ~PlatformGestureRecognizer(); 50 53 … … 55 58 // Returns true if the event resulted in firing a synthetic event. 56 59 virtual bool processTouchEventForGesture(const PlatformTouchEvent&, EventHandler*, bool handled) = 0; 57 58 // Factory method for GestureManagers.59 static PlatformGestureRecognizer* create();60 60 }; 61 61 -
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
r84163 r84890 87 87 , m_multisampleFBO(0) 88 88 , m_multisampleColorBuffer(0) 89 , m_internal( new DrawingBufferInternal)89 , m_internal(adoptPtr(new DrawingBufferInternal)) 90 90 #if ENABLE(SKIA_GPU) 91 91 , m_grContext(0) -
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp
r83915 r84890 77 77 , m_debugBorderColor(0, 0, 0, 0) 78 78 , m_debugBorderWidth(0) 79 , m_renderSurface(0)80 79 , m_layerRenderer(0) 81 80 { -
trunk/Source/WebCore/platform/graphics/gpu/Texture.cpp
r83960 r84890 93 93 int numTiles = tiling.numTiles(); 94 94 95 OwnPtr<Vector<unsigned int> > textureIds (new Vector<unsigned int>(numTiles));95 OwnPtr<Vector<unsigned int> > textureIds = adoptPtr(new Vector<unsigned int>(numTiles)); 96 96 textureIds->fill(0, numTiles); 97 97 -
trunk/Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp
r75748 r84890 33 33 34 34 #include "BMPImageReader.h" 35 #include <wtf/PassOwnPtr.h> 35 36 36 37 namespace WebCore { … … 110 111 111 112 if (!m_reader) { 112 m_reader .set(new BMPImageReader(this, m_decodedOffset, imgDataOffset, false));113 m_reader = adoptPtr(new BMPImageReader(this, m_decodedOffset, imgDataOffset, false)); 113 114 m_reader->setData(m_data.get()); 114 115 } -
trunk/Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp
r79282 r84890 26 26 #include "config.h" 27 27 #include "GIFImageDecoder.h" 28 28 29 #include "GIFImageReader.h" 30 #include <wtf/PassOwnPtr.h> 29 31 30 32 namespace WebCore { … … 313 315 314 316 if (!m_reader) 315 m_reader .set(new GIFImageReader(this));317 m_reader = adoptPtr(new GIFImageReader(this)); 316 318 317 319 // If we couldn't decode the image but we've received all the data, decoding -
trunk/Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp
r75748 r84890 36 36 #include "BMPImageReader.h" 37 37 #include "PNGImageDecoder.h" 38 #include <wtf/PassOwnPtr.h> 38 39 39 40 namespace WebCore { … … 192 193 // we must not resize it again later (see caution in frameCount()). 193 194 ASSERT(m_frameBufferCache.size() == m_dirEntries.size()); 194 m_bmpReaders[index] .set(new BMPImageReader(this, dirEntry.m_imageOffset, 0, true));195 m_bmpReaders[index] = adoptPtr(new BMPImageReader(this, dirEntry.m_imageOffset, 0, true)); 195 196 m_bmpReaders[index]->setData(m_data.get()); 196 197 m_bmpReaders[index]->setBuffer(&m_frameBufferCache[index]); … … 203 204 204 205 if (!m_pngDecoders[index]) { 205 m_pngDecoders[index] .set(206 m_pngDecoders[index] = adoptPtr( 206 207 new PNGImageDecoder(m_premultiplyAlpha ? ImageSource::AlphaPremultiplied : ImageSource::AlphaNotPremultiplied, 207 208 m_ignoreGammaAndColorProfile ? ImageSource::GammaAndColorProfileIgnored : ImageSource::GammaAndColorProfileApplied)); -
trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
r78548 r84890 41 41 #include "JPEGImageDecoder.h" 42 42 #include <stdio.h> // Needed by jpeglib.h for FILE. 43 #include <wtf/PassOwnPtr.h> 43 44 44 45 #if OS(WINCE) || PLATFORM(BREWMP_SIMULATOR) … … 529 530 530 531 if (!m_reader) 531 m_reader .set(new JPEGImageReader(this));532 m_reader = adoptPtr(new JPEGImageReader(this)); 532 533 533 534 // If we couldn't decode the image but we've received all the data, decoding -
trunk/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp
r82344 r84890 40 40 #include "config.h" 41 41 #include "PNGImageDecoder.h" 42 42 43 #include "png.h" 44 #include <wtf/PassOwnPtr.h> 43 45 44 46 #if defined(PNG_LIBPNG_VER_MAJOR) && defined(PNG_LIBPNG_VER_MINOR) && (PNG_LIBPNG_VER_MAJOR > 1 || (PNG_LIBPNG_VER_MAJOR == 1 && PNG_LIBPNG_VER_MINOR >= 4)) … … 425 427 426 428 if (!m_reader) 427 m_reader .set(new PNGImageReader(this));429 m_reader = adoptPtr(new PNGImageReader(this)); 428 430 429 431 // If we couldn't decode the image but we've received all the data, decoding -
trunk/Source/WebCore/storage/chromium/DatabaseTrackerChromium.cpp
r64384 r84890 77 77 MutexLocker openDatabaseMapLock(m_openDatabaseMapGuard); 78 78 if (!m_openDatabaseMap) 79 m_openDatabaseMap .set(new DatabaseOriginMap());79 m_openDatabaseMap = adoptPtr(new DatabaseOriginMap()); 80 80 81 81 DatabaseNameMap* nameMap = m_openDatabaseMap->get(database->securityOrigin());
Note: See TracChangeset
for help on using the changeset viewer.