Changeset 84966 in webkit

Timestamp:

Apr 26, 2011 3:58:25 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement isChecked in DRT
​https://bugs.webkit.org/show_bug.cgi?id=59385

• platform/gtk/Skipped: Unskip the layout test accessibility/aria-checkbox-checked.html.

2011-04-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement isChecked in DRT
​https://bugs.webkit.org/show_bug.cgi?id=59385

• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isChecked): Implemented.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Eric Seidel.
+
+        [GTK] Implement isChecked in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=59385
+
+        * platform/gtk/Skipped: Unskip the layout test
+        accessibility/aria-checkbox-checked.html.
+
 2011-04-26  Alejandro G. Castro  <alex@igalia.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -325 +325 @@
 # TESTS FAILING
 ###############################################################################
-accessibility/aria-checkbox-checked.html
 accessibility/aria-combobox.html
 accessibility/aria-help.html

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Eric Seidel.
+
+        [GTK] Implement isChecked in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=59385
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (AccessibilityUIElement::isChecked): Implemented.
+
 2011-04-26  Alejandro G. Castro  <alex@igalia.com>
 

trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

@@ -443 +443 @@
 bool AccessibilityUIElement::isChecked() const
 {
-    return intValue();
+    if (!ATK_IS_OBJECT(m_element))
+        return false;
+
+    GRefPtr<AtkStateSet> stateSet = adoptGRef(atk_object_ref_state_set(ATK_OBJECT(m_element)));
+    gboolean isChecked = atk_state_set_contains_state(stateSet.get(), ATK_STATE_CHECKED);
+
+    return isChecked;
 }