Changeset 85002 in webkit

Timestamp:

Apr 26, 2011 7:06:05 PM (13 years ago)

Author:

jamesr@google.com

Message:

2011-04-26 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Only reset tiles if the LayerRendererChromium is actually changing
​https://bugs.webkit.org/show_bug.cgi?id=59572

​http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
when LayerRendererChromium was set. We set this pointer every frame
and should only reset the tiles if the new LayerRendererChromium is
different from the old one (indicating a context loss), not just reset
on every frame.

• platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setLayerRenderer):
• platform/graphics/chromium/LayerTilerChromium.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/LayerTilerChromium.cpp (modified) (1 diff)
• platform/graphics/chromium/LayerTilerChromium.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-26  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Kenneth Russell.
+
+        [chromium] Only reset tiles if the LayerRendererChromium is actually changing
+        https://bugs.webkit.org/show_bug.cgi?id=59572
+
+        http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
+        when LayerRendererChromium was set.  We set this pointer every frame
+        and should only reset the tiles if the new LayerRendererChromium is
+        different from the old one (indicating a context loss), not just reset
+        on every frame.
+
+        * platform/graphics/chromium/LayerTilerChromium.cpp:
+        (WebCore::LayerTilerChromium::setLayerRenderer):
+        * platform/graphics/chromium/LayerTilerChromium.h:
+
 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
 

trunk/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp

@@ -59 +59 @@
 }
 
+void LayerTilerChromium::setLayerRenderer(LayerRendererChromium* layerRenderer)
+{
+    if (m_layerRenderer != layerRenderer)
+        reset();
+    m_layerRenderer = layerRenderer;
+}
+
 LayerTilerChromium::~LayerTilerChromium()
 {

trunk/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.h

@@ -78 +78 @@
     // Change the tile size.  This may invalidate all the existing tiles.
     void setTileSize(const IntSize& size);
-    void setLayerRenderer(LayerRendererChromium* layerRenderer) { m_layerRenderer = layerRenderer; reset(); }
+    void setLayerRenderer(LayerRendererChromium*);
 
     bool skipsDraw() const { return m_skipsDraw; }