Changeset 85030 in webkit


Ignore:
Timestamp:
Apr 27, 2011 12:37:02 AM (13 years ago)
Author:
mihaip@chromium.org
Message:

2011-04-27 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

Frame.h shouldn't include Document.h
​https://bugs.webkit.org/show_bug.cgi?id=59560

Frame can use a forward-declared Document if we move
Frame::displayStringModifiedByEncoding's implementation out of the
header.

Size #includes Size * #includes

Before: page/Frame.h: 0.746 653 487.138

dom/Document.h: 0.220 1306 287.320

After: page/Frame.h: 0.646 653 421.838

dom/Document.h: 0.220 1189 261.580

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp:
  • bindings/generic/BindingSecurityBase.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • dom/CharacterData.cpp:
  • dom/UserTypingGestureIndicator.cpp:
  • editing/chromium/SelectionControllerChromium.cpp:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorInstrumentation.h:
  • loader/PingLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/appcache/DOMApplicationCache.cpp:
  • loader/cache/CachedResourceRequest.cpp:
  • page/Frame.cpp: (WebCore::Frame::displayStringModifiedByEncoding):
  • page/Frame.h:
  • page/Geolocation.cpp:
  • page/Location.cpp:
  • page/Navigator.cpp:
  • page/PageGroupLoadDeferrer.cpp:
  • page/PerformanceTiming.cpp:
  • xml/XSLTProcessorLibxslt.cpp:

2011-04-27 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

Frame.h shouldn't include Document.h
​https://bugs.webkit.org/show_bug.cgi?id=59560

Add Document.h #includes for files that were relying on transitive
#includes via Frame.h.

  • src/LocalFileSystemChromium.cpp:
  • src/StorageEventDispatcherImpl.cpp:
  • src/WebFrameImpl.h:
  • src/WebWorkerBase.cpp:
Location:
trunk/Source
Files:
28 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r85027 r85030  
     12011-04-27  Mihai Parparita  <mihaip@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Frame.h shouldn't include Document.h
     6        https://bugs.webkit.org/show_bug.cgi?id=59560
     7
     8        Frame can use a forward-declared Document if we move
     9        Frame::displayStringModifiedByEncoding's implementation out of the
     10        header.
     11                                Size  #includes  Size * #includes
     12        Before: page/Frame.h:   0.746       653           487.138
     13                dom/Document.h: 0.220      1306           287.320
     14       
     15        After:  page/Frame.h:   0.646       653           421.838
     16                dom/Document.h: 0.220      1189           261.580
     17
     18        * WebCore.exp.in:
     19        * bindings/ScriptControllerBase.cpp:
     20        * bindings/generic/BindingSecurityBase.cpp:
     21        * bindings/v8/V8Proxy.cpp:
     22        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
     23        * dom/CharacterData.cpp:
     24        * dom/UserTypingGestureIndicator.cpp:
     25        * editing/chromium/SelectionControllerChromium.cpp:
     26        * inspector/InspectorDOMStorageResource.cpp:
     27        * inspector/InspectorInstrumentation.h:
     28        * loader/PingLoader.cpp:
     29        * loader/SubresourceLoader.cpp:
     30        * loader/appcache/DOMApplicationCache.cpp:
     31        * loader/cache/CachedResourceRequest.cpp:
     32        * page/Frame.cpp:
     33        (WebCore::Frame::displayStringModifiedByEncoding):
     34        * page/Frame.h:
     35        * page/Geolocation.cpp:
     36        * page/Location.cpp:
     37        * page/Navigator.cpp:
     38        * page/PageGroupLoadDeferrer.cpp:
     39        * page/PerformanceTiming.cpp:
     40        * xml/XSLTProcessorLibxslt.cpp:
     41
    1422011-04-27  James Robinson  <jamesr@chromium.org>
    243

  • trunk/Source/WebCore/WebCore.exp.in

    r84934 r85030  
    12121212__ZNK7WebCore5Frame15layerTreeAsTextEb
    12131213__ZNK7WebCore5Frame18documentTypeStringEv
     1214__ZNK7WebCore5Frame31displayStringModifiedByEncodingERKN3WTF6StringE
    12141215__ZNK7WebCore5Frame8settingsEv
    12151216__ZNK7WebCore5Frame9domWindowEv

  • trunk/Source/WebCore/bindings/ScriptControllerBase.cpp

    r82028 r85030  
    2323
    2424#include "ContentSecurityPolicy.h"
     25#include "Document.h"
    2526#include "DocumentLoader.h"
    2627#include "Frame.h"

  • trunk/Source/WebCore/bindings/generic/BindingSecurityBase.cpp

    r52810 r85030  
    3333
    3434#include "DOMWindow.h"
     35#include "Document.h"
    3536#include "Frame.h"
    3637#include "SecurityOrigin.h"

  • trunk/Source/WebCore/bindings/v8/V8Proxy.cpp

    r84890 r85030  
    3535#include "CachedMetadata.h"
    3636#include "DateExtension.h"
     37#include "Document.h"
    3738#include "DocumentLoader.h"
    3839#include "Frame.h"

  • trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

    r76600 r85030  
    3333
    3434#include "ArrayBuffer.h"
     35#include "Document.h"
    3536#include "Frame.h"
    3637#include "InspectorInstrumentation.h"

  • trunk/Source/WebCore/dom/CharacterData.cpp

    r80526 r85030  
    2323#include "CharacterData.h"
    2424
     25#include "Document.h"
    2526#include "EventNames.h"
    2627#include "ExceptionCode.h"

  • trunk/Source/WebCore/dom/UserTypingGestureIndicator.cpp

    r63927 r85030  
    2727#include "UserTypingGestureIndicator.h"
    2828
     29#include "Document.h"
    2930#include "Frame.h"
    3031#include "Node.h"

  • trunk/Source/WebCore/editing/chromium/SelectionControllerChromium.cpp

    r79196 r85030  
    3333
    3434#include "AXObjectCache.h"
     35#include "Document.h"
    3536#include "Frame.h"
    3637

  • trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp

    r81572 r85030  
    3636
    3737#include "DOMWindow.h"
     38#include "Document.h"
    3839#include "EventNames.h"
    3940#include "Frame.h"

  • trunk/Source/WebCore/inspector/InspectorInstrumentation.h

    r84773 r85030  
    3333
    3434#include "Console.h"
     35#include "Document.h"
    3536#include "Frame.h"
    3637#include "Page.h"
    … …  
    4344class DOMWrapperWorld;
    4445class Database;
    45 class Document;
    4646class Element;
    4747class EventContext;

  • trunk/Source/WebCore/loader/PingLoader.cpp

    r84478 r85030  
    3333#include "PingLoader.h"
    3434
     35#include "Document.h"
    3536#include "FormData.h"
    3637#include "Frame.h"

  • trunk/Source/WebCore/loader/SubresourceLoader.cpp

    r84681 r85030  
    3030#include "SubresourceLoader.h"
    3131
     32#include "Document.h"
    3233#include "DocumentLoader.h"
    3334#include "Frame.h"

  • trunk/Source/WebCore/loader/appcache/DOMApplicationCache.cpp

    r53596 r85030  
    3030
    3131#include "ApplicationCacheHost.h"
     32#include "Document.h"
    3233#include "DocumentLoader.h"
    3334#include "Event.h"

  • trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp

    r84110 r85030  
    2525#include "CachedResourceRequest.h"
    2626
    27 #include "MemoryCache.h"
    2827#include "CachedImage.h"
    2928#include "CachedResource.h"
    3029#include "CachedResourceLoader.h"
     30#include "Document.h"
    3131#include "Frame.h"
    3232#include "FrameLoader.h"
    3333#include "Logging.h"
     34#include "MemoryCache.h"
    3435#include "ResourceHandle.h"
    3536#include "ResourceLoadScheduler.h"

  • trunk/Source/WebCore/page/Frame.cpp

    r84810 r85030  
    809809}
    810810
     811String Frame::displayStringModifiedByEncoding(const String& str) const
     812{
     813    return document() ? document()->displayStringModifiedByEncoding(str) : str;
     814}
     815
    811816VisiblePosition Frame::visiblePositionForPoint(const IntPoint& framePoint)
    812817{

  • trunk/Source/WebCore/page/Frame.h

    r84769 r85030  
    3030
    3131#include "AnimationController.h"
    32 #include "Document.h"
    3332#include "DragImage.h"
    3433#include "Editor.h"
    … …  
    6362namespace WebCore {
    6463
     64    class Document;
    6565    class FrameView;
    6666    class HTMLTableCellElement;
    … …  
    175175        String documentTypeString() const;
    176176
    177         String displayStringModifiedByEncoding(const String& str) const
    178         {
    179             return document() ? document()->displayStringModifiedByEncoding(str) : str;
    180         }
     177        String displayStringModifiedByEncoding(const String&) const;
    181178
    182179        DragImageRef nodeImage(Node*);

  • trunk/Source/WebCore/page/Geolocation.cpp

    r81018 r85030  
    3232
    3333#include "Chrome.h"
     34#include "Document.h"
    3435#include "Frame.h"
    3536#include "Page.h"

  • trunk/Source/WebCore/page/Location.cpp

    r76872 r85030  
    3131
    3232#include "DOMWindow.h"
     33#include "Document.h"
    3334#include "ExceptionCode.h"
    3435#include "Frame.h"

  • trunk/Source/WebCore/page/Navigator.cpp

    r84371 r85030  
    2828#include "DOMMimeTypeArray.h"
    2929#include "DOMPluginArray.h"
     30#include "Document.h"
    3031#include "ExceptionCode.h"
    3132#include "Frame.h"

  • trunk/Source/WebCore/page/PageGroupLoadDeferrer.cpp

    r81198 r85030  
    2222#include "PageGroupLoadDeferrer.h"
    2323
     24#include "Document.h"
    2425#include "DocumentParser.h"
    2526#include "Frame.h"

  • trunk/Source/WebCore/page/PerformanceTiming.cpp

    r83491 r85030  
    3434#if ENABLE(WEB_TIMING)
    3535
     36#include "Document.h"
    3637#include "DocumentLoadTiming.h"
    3738#include "DocumentLoader.h"

  • trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp

    r79159 r85030  
    2727#include "XSLTProcessor.h"
    2828
     29#include "CachedResourceLoader.h"
    2930#include "Console.h"
    3031#include "DOMWindow.h"
    31 #include "CachedResourceLoader.h"
     32#include "Document.h"
    3233#include "Frame.h"
    3334#include "ResourceError.h"

  • trunk/Source/WebKit/chromium/ChangeLog

    r85023 r85030  
     12011-04-27  Mihai Parparita  <mihaip@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Frame.h shouldn't include Document.h
     6        https://bugs.webkit.org/show_bug.cgi?id=59560
     7       
     8        Add Document.h #includes for files that were relying on transitive
     9        #includes via Frame.h.
     10
     11        * src/LocalFileSystemChromium.cpp:
     12        * src/StorageEventDispatcherImpl.cpp:
     13        * src/WebFrameImpl.h:
     14        * src/WebWorkerBase.cpp:
     15
    1162011-04-26  Jay Civelli  <jcivelli@chromium.org>
    217

  • trunk/Source/WebKit/chromium/src/LocalFileSystemChromium.cpp

    r81640 r85030  
    3535
    3636#include "AsyncFileSystem.h"
     37#include "Document.h"
    3738#include "ErrorCallback.h"
    3839#include "FileSystemCallback.h"

  • trunk/Source/WebKit/chromium/src/StorageEventDispatcherImpl.cpp

    r58571 r85030  
    3535
    3636#include "DOMWindow.h"
     37#include "Document.h"
    3738#include "EventNames.h"
    3839#include "Frame.h"

  • trunk/Source/WebKit/chromium/src/WebFrameImpl.h

    r85001 r85030  
    4343namespace WebCore {
    4444class GraphicsContext;
     45class HTMLInputElement;
    4546class HistoryItem;
    4647class KURL;

  • trunk/Source/WebKit/chromium/src/WebWorkerBase.cpp

    r82481 r85030  
    3434#include "CrossThreadTask.h"
    3535#include "DatabaseTask.h"
     36#include "Document.h"
    3637#include "MessagePortChannel.h"
    3738#include "PlatformMessagePortChannel.h"
Note: See TracChangeset for help on using the changeset viewer.