Changeset 85094 in webkit
- Timestamp:
- Apr 27, 2011 2:25:22 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 22 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r85090 r85094 1 2011-04-27 Darin Adler <darin@apple.com> 2 3 Reviewed by David Levin. 4 5 Fix strict OwnPtr issues seen in about 30 more files 6 https://bugs.webkit.org/show_bug.cgi?id=59615 7 8 * bindings/js/JSCallbackData.h: 9 (WebCore::DeleteCallbackDataTask::create): Use adoptPtr. 10 * bindings/js/JSMessageEventCustom.cpp: 11 (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr. 12 * css/CSSParser.cpp: 13 (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr, 14 adoptPtr, and release. 15 * dom/MessageEvent.cpp: 16 (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr, 17 and release. 18 * dom/MessagePortChannel.cpp: 19 (WebCore::MessagePortChannel::EventData::create): Use adoptPtr. 20 * dom/ScriptExecutionContext.cpp: 21 (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr. 22 * dom/XMLDocumentParserLibxml2.cpp: 23 (WebCore::XMLDocumentParser::doEnd): Use adoptPtr. 24 * dom/default/PlatformMessagePortChannel.cpp: 25 (WebCore::MessagePortChannel::create): Use adoptPtr. 26 * html/HTMLFormControlElement.cpp: 27 (WebCore::HTMLFormControlElement::detach): Use nullptr. 28 * inspector/InspectorAgent.cpp: 29 (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr. 30 * inspector/InspectorConsoleAgent.cpp: 31 (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr. 32 (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr. 33 (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr. 34 * inspector/InspectorController.cpp: 35 (WebCore::InspectorController::connectFrontend): Use adoptPtr. 36 * inspector/InspectorDOMAgent.cpp: 37 (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr. 38 * inspector/InspectorResourceAgent.cpp: 39 (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr. 40 * page/FrameActionScheduler.cpp: 41 (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr. 42 * platform/graphics/ShadowBlur.cpp: 43 (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr. 44 * platform/graphics/ca/GraphicsLayerCA.cpp: 45 (WebCore::GraphicsLayer::create): Use adoptPtr. 46 (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr. 47 (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr. 48 * rendering/RenderBlock.cpp: 49 (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr. 50 (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr. 51 (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr. 52 (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr. 53 * rendering/RenderLayerBacking.cpp: 54 (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr. 55 (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr. 56 (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr. 57 (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr. 58 * rendering/RenderLayerCompositor.cpp: 59 (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr. 60 (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr. 61 (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr. 62 * rendering/style/StyleRareNonInheritedData.cpp: 63 (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed 64 explicit initializations of OwnPtr members to 0. Use adoptPtr. 65 * workers/SharedWorkerContext.cpp: 66 (WebCore::createConnectEvent): Use adoptPtr. 67 * workers/Worker.cpp: 68 (WebCore::Worker::notifyFinished): Use nullptr. 69 1 70 2011-04-27 Enrica Casucci <enrica@apple.com> 2 71 -
trunk/Source/WebCore/bindings/js/JSCallbackData.h
r83385 r85094 78 78 static PassOwnPtr<DeleteCallbackDataTask> create(JSCallbackData* data) 79 79 { 80 return new DeleteCallbackDataTask(data);80 return adoptPtr(new DeleteCallbackDataTask(data)); 81 81 } 82 82 -
trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp
r84670 r85094 68 68 OwnPtr<MessagePortArray> messagePorts; 69 69 if (!exec->argument(7).isUndefinedOrNull()) { 70 messagePorts = new MessagePortArray();70 messagePorts = adoptPtr(new MessagePortArray); 71 71 fillMessagePortArray(exec, exec->argument(7), *messagePorts); 72 72 if (exec->hadException()) -
trunk/Source/WebCore/css/CSSParser.cpp
r85077 r85094 6388 6388 return; 6389 6389 6390 CSSParserSelector* elementNameSelector = new CSSParserSelector;6390 OwnPtr<CSSParserSelector> elementNameSelector = adoptPtr(new CSSParserSelector); 6391 6391 elementNameSelector->setTag(tag); 6392 lastShadowDescendant->setTagHistory(elementNameSelector );6392 lastShadowDescendant->setTagHistory(elementNameSelector.release()); 6393 6393 lastShadowDescendant->setRelation(CSSSelector::ShadowDescendant); 6394 6394 } -
trunk/Source/WebCore/dom/MessageEvent.cpp
r49214 r85094 78 78 void MessageEvent::initMessageEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, DOMWindow* source, MessagePort* port) 79 79 { 80 MessagePortArray* ports = 0;80 OwnPtr<MessagePortArray> ports; 81 81 if (port) { 82 ports = new MessagePortArray();82 ports = adoptPtr(new MessagePortArray); 83 83 ports->append(port); 84 84 } 85 initMessageEvent(type, canBubble, cancelable, data, origin, lastEventId, source, ports );85 initMessageEvent(type, canBubble, cancelable, data, origin, lastEventId, source, ports.release()); 86 86 } 87 87 -
trunk/Source/WebCore/dom/MessagePortChannel.cpp
r66850 r85094 36 36 PassOwnPtr<MessagePortChannel::EventData> MessagePortChannel::EventData::create(PassRefPtr<SerializedScriptValue> message, PassOwnPtr<MessagePortChannelArray> channels) 37 37 { 38 return new EventData(message, channels);38 return adoptPtr(new EventData(message, channels)); 39 39 } 40 40 -
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
r81399 r85094 61 61 static PassOwnPtr<ProcessMessagesSoonTask> create() 62 62 { 63 return new ProcessMessagesSoonTask;63 return adoptPtr(new ProcessMessagesSoonTask); 64 64 } 65 65 -
trunk/Source/WebCore/dom/XMLDocumentParserLibxml2.cpp
r84881 r85094 1352 1352 if (m_sawXSLTransform) { 1353 1353 void* doc = xmlDocPtrForString(document()->cachedResourceLoader(), m_originalSourceForTransform, document()->url().string()); 1354 document()->setTransformSource( new TransformSource(doc));1354 document()->setTransformSource(adoptPtr(new TransformSource(doc))); 1355 1355 1356 1356 document()->setParsing(false); // Make the document think it's done, so it will apply XSL stylesheets. -
trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.cpp
r50427 r85094 45 45 PassOwnPtr<MessagePortChannel> MessagePortChannel::create(PassRefPtr<PlatformMessagePortChannel> channel) 46 46 { 47 return new MessagePortChannel(channel);47 return adoptPtr(new MessagePortChannel(channel)); 48 48 } 49 49 -
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
r84693 r85094 82 82 void HTMLFormControlElement::detach() 83 83 { 84 m_validationMessage = 0;84 m_validationMessage = nullptr; 85 85 HTMLElement::detach(); 86 86 } -
trunk/Source/WebCore/inspector/InspectorAgent.cpp
r85035 r85094 331 331 static PassOwnPtr<PostWorkerNotificationToFrontendTask> create(PassRefPtr<InspectorWorkerResource> worker, InspectorAgent::WorkerAction action) 332 332 { 333 return new PostWorkerNotificationToFrontendTask(worker, action);333 return adoptPtr(new PostWorkerNotificationToFrontendTask(worker, action)); 334 334 } 335 335 -
trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp
r83175 r85094 129 129 if (!m_inspectorAgent->enabled()) 130 130 return; 131 addConsoleMessage( new ConsoleMessage(source, type, level, message, arguments, callStack));131 addConsoleMessage(adoptPtr(new ConsoleMessage(source, type, level, message, arguments, callStack))); 132 132 } 133 133 … … 136 136 if (!m_inspectorAgent->enabled()) 137 137 return; 138 addConsoleMessage( new ConsoleMessage(source, type, level, message, lineNumber, sourceID));138 addConsoleMessage(adoptPtr(new ConsoleMessage(source, type, level, message, lineNumber, sourceID))); 139 139 } 140 140 … … 208 208 if (response.httpStatusCode() >= 400) { 209 209 String message = makeString("Failed to load resource: the server responded with a status of ", String::number(response.httpStatusCode()), " (", response.httpStatusText(), ')'); 210 addConsoleMessage( new ConsoleMessage(OtherMessageSource, NetworkErrorMessageType, ErrorMessageLevel, message, response.url().string(), identifier));210 addConsoleMessage(adoptPtr(new ConsoleMessage(OtherMessageSource, NetworkErrorMessageType, ErrorMessageLevel, message, response.url().string(), identifier))); 211 211 } 212 212 } … … 221 221 if (!error.localizedDescription().isEmpty()) 222 222 message += ": " + error.localizedDescription(); 223 addConsoleMessage( new ConsoleMessage(OtherMessageSource, NetworkErrorMessageType, ErrorMessageLevel, message, error.failingURL(), identifier));223 addConsoleMessage(adoptPtr(new ConsoleMessage(OtherMessageSource, NetworkErrorMessageType, ErrorMessageLevel, message, error.failingURL(), identifier))); 224 224 } 225 225 -
trunk/Source/WebCore/inspector/InspectorController.cpp
r84833 r85094 106 106 { 107 107 m_openingFrontend = false; 108 m_inspectorFrontend = new InspectorFrontend(m_inspectorClient);108 m_inspectorFrontend = adoptPtr(new InspectorFrontend(m_inspectorClient)); 109 109 m_injectedScriptManager->injectedScriptHost()->setFrontend(m_inspectorFrontend.get()); 110 110 m_inspectorAgent->setFrontend(m_inspectorFrontend.get()); … … 115 115 116 116 ASSERT(m_inspectorClient); 117 m_inspectorBackendDispatcher = new InspectorBackendDispatcher(117 m_inspectorBackendDispatcher = adoptPtr(new InspectorBackendDispatcher( 118 118 m_inspectorClient, 119 119 #if ENABLE(OFFLINE_WEB_APPLICATIONS) … … 145 145 , m_inspectorAgent->workerAgent() 146 146 #endif 147 ) ;147 )); 148 148 149 149 if (m_startUserInitiatedDebuggingWhenFrontedIsConnected) { -
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
r85047 r85094 1294 1294 1295 1295 if (!m_revalidateStyleAttrTask) 1296 m_revalidateStyleAttrTask = new RevalidateStyleAttributeTask(this);1296 m_revalidateStyleAttrTask = adoptPtr(new RevalidateStyleAttributeTask(this)); 1297 1297 m_revalidateStyleAttrTask->scheduleFor(static_cast<Element*>(node)); 1298 1298 } -
trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp
r84774 r85094 375 375 { 376 376 if (backgroundEventsCollectionEnabled()) { 377 m_eventsCollector = new EventsCollector();378 m_inspectorFrontendProxy = new InspectorFrontendProxy(m_eventsCollector.get());377 m_eventsCollector = adoptPtr(new EventsCollector); 378 m_inspectorFrontendProxy = adoptPtr(new InspectorFrontendProxy(m_eventsCollector.get())); 379 379 // Create mock frontend, so we can collect network events. 380 m_mockFrontend = new InspectorFrontend::Network(m_inspectorFrontendProxy.get());380 m_mockFrontend = adoptPtr(new InspectorFrontend::Network(m_inspectorFrontendProxy.get())); 381 381 m_frontend = m_mockFrontend.get(); 382 382 enable(); -
trunk/Source/WebCore/page/FrameActionScheduler.cpp
r80210 r85094 105 105 void FrameActionScheduler::scheduleEvent(PassRefPtr<Event> event, PassRefPtr<Node> eventTarget) 106 106 { 107 scheduleAction( new EventFrameAction(event, eventTarget));107 scheduleAction(adoptPtr(new EventFrameAction(event, eventTarget))); 108 108 } 109 109 -
trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp
r84522 r85094 141 141 void clearScratchBuffer() 142 142 { 143 m_imageBuffer = 0;143 m_imageBuffer = nullptr; 144 144 m_lastRadius = FloatSize(); 145 145 } -
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
r85036 r85094 240 240 PassOwnPtr<GraphicsLayer> GraphicsLayer::create(GraphicsLayerClient* client) 241 241 { 242 return new GraphicsLayerCA(client);242 return adoptPtr(new GraphicsLayerCA(client)); 243 243 } 244 244 … … 2152 2152 2153 2153 if (!m_layerClones) 2154 m_layerClones = new LayerMap;2154 m_layerClones = adoptPtr(new LayerMap); 2155 2155 2156 2156 if (!m_structuralLayerClones && m_structuralLayer) 2157 m_structuralLayerClones = new LayerMap;2157 m_structuralLayerClones = adoptPtr(new LayerMap); 2158 2158 2159 2159 if (!m_contentsLayerClones && m_contentsLayer) 2160 m_contentsLayerClones = new LayerMap;2160 m_contentsLayerClones = adoptPtr(new LayerMap); 2161 2161 2162 2162 primaryLayer = findOrMakeClone(cloneID, m_layer.get(), m_layerClones.get(), cloneLevel); … … 2167 2167 void GraphicsLayerCA::removeCloneLayers() 2168 2168 { 2169 m_layerClones = 0;2170 m_structuralLayerClones = 0;2171 m_contentsLayerClones = 0;2169 m_layerClones = nullptr; 2170 m_structuralLayerClones = nullptr; 2171 m_contentsLayerClones = nullptr; 2172 2172 } 2173 2173 -
trunk/Source/WebCore/rendering/RenderBlock.cpp
r85011 r85094 5588 5588 if (pos == RenderBlockRareData::positiveMarginBeforeDefault(this) && neg == RenderBlockRareData::negativeMarginBeforeDefault(this)) 5589 5589 return; 5590 m_rareData = new RenderBlockRareData(this);5590 m_rareData = adoptPtr(new RenderBlockRareData(this)); 5591 5591 } 5592 5592 m_rareData->m_margins.setPositiveMarginBefore(pos); … … 5599 5599 if (pos == RenderBlockRareData::positiveMarginAfterDefault(this) && neg == RenderBlockRareData::negativeMarginAfterDefault(this)) 5600 5600 return; 5601 m_rareData = new RenderBlockRareData(this);5601 m_rareData = adoptPtr(new RenderBlockRareData(this)); 5602 5602 } 5603 5603 m_rareData->m_margins.setPositiveMarginAfter(pos); … … 5610 5610 if (!strut) 5611 5611 return; 5612 m_rareData = new RenderBlockRareData(this);5612 m_rareData = adoptPtr(new RenderBlockRareData(this)); 5613 5613 } 5614 5614 m_rareData->m_paginationStrut = strut; … … 5620 5620 if (!logicalOffset) 5621 5621 return; 5622 m_rareData = new RenderBlockRareData(this);5622 m_rareData = adoptPtr(new RenderBlockRareData(this)); 5623 5623 } 5624 5624 m_rareData->m_pageLogicalOffset = logicalOffset; -
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
r85036 r85094 124 124 m_graphicsLayer->removeFromParent(); 125 125 126 m_graphicsLayer = 0;127 m_foregroundLayer = 0;128 m_clippingLayer = 0;129 m_maskLayer = 0;126 m_graphicsLayer = nullptr; 127 m_foregroundLayer = nullptr; 128 m_clippingLayer = nullptr; 129 m_maskLayer = nullptr; 130 130 } 131 131 … … 542 542 } else if (m_ancestorClippingLayer) { 543 543 m_ancestorClippingLayer->removeFromParent(); 544 m_ancestorClippingLayer = 0;544 m_ancestorClippingLayer = nullptr; 545 545 layersChanged = true; 546 546 } … … 557 557 } else if (m_clippingLayer) { 558 558 m_clippingLayer->removeFromParent(); 559 m_clippingLayer = 0;559 m_clippingLayer = nullptr; 560 560 layersChanged = true; 561 561 } … … 653 653 } else if (m_foregroundLayer) { 654 654 m_foregroundLayer->removeFromParent(); 655 m_foregroundLayer = 0;655 m_foregroundLayer = nullptr; 656 656 layerChanged = true; 657 657 } … … 679 679 } 680 680 } else if (m_maskLayer) { 681 m_maskLayer = 0;681 m_maskLayer = nullptr; 682 682 layerChanged = true; 683 683 } -
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
r84805 r85094 1509 1509 } else if (m_layerForHorizontalScrollbar) { 1510 1510 m_layerForHorizontalScrollbar->removeFromParent(); 1511 m_layerForHorizontalScrollbar = 0;1511 m_layerForHorizontalScrollbar = nullptr; 1512 1512 layersChanged = true; 1513 1513 } … … 1522 1522 } else if (m_layerForVerticalScrollbar) { 1523 1523 m_layerForVerticalScrollbar->removeFromParent(); 1524 m_layerForVerticalScrollbar = 0;1524 m_layerForVerticalScrollbar = nullptr; 1525 1525 layersChanged = true; 1526 1526 } … … 1535 1535 } else if (m_layerForScrollCorner) { 1536 1536 m_layerForScrollCorner->removeFromParent(); 1537 m_layerForScrollCorner = 0;1537 m_layerForScrollCorner = nullptr; 1538 1538 layersChanged = true; 1539 1539 } … … 1594 1594 } else { 1595 1595 if (m_overflowControlsHostLayer) { 1596 m_overflowControlsHostLayer = 0;1597 m_clipLayer = 0;1598 m_scrollLayer = 0;1596 m_overflowControlsHostLayer = nullptr; 1597 m_clipLayer = nullptr; 1598 m_scrollLayer = nullptr; 1599 1599 } 1600 1600 } … … 1616 1616 if (m_layerForHorizontalScrollbar) { 1617 1617 m_layerForHorizontalScrollbar->removeFromParent(); 1618 m_layerForHorizontalScrollbar = 0;1618 m_layerForHorizontalScrollbar = nullptr; 1619 1619 if (Scrollbar* horizontalScrollbar = m_renderView->frameView()->verticalScrollbar()) 1620 1620 m_renderView->frameView()->invalidateScrollbar(horizontalScrollbar, IntRect(IntPoint(0, 0), horizontalScrollbar->frameRect().size())); … … 1623 1623 if (m_layerForVerticalScrollbar) { 1624 1624 m_layerForVerticalScrollbar->removeFromParent(); 1625 m_layerForVerticalScrollbar = 0;1625 m_layerForVerticalScrollbar = nullptr; 1626 1626 if (Scrollbar* verticalScrollbar = m_renderView->frameView()->verticalScrollbar()) 1627 1627 m_renderView->frameView()->invalidateScrollbar(verticalScrollbar, IntRect(IntPoint(0, 0), verticalScrollbar->frameRect().size())); … … 1629 1629 1630 1630 if (m_layerForScrollCorner) { 1631 m_layerForScrollCorner = 0;1631 m_layerForScrollCorner = nullptr; 1632 1632 m_renderView->frameView()->invalidateScrollCorner(); 1633 1633 } 1634 1634 1635 1635 if (m_overflowControlsHostLayer) { 1636 m_overflowControlsHostLayer = 0;1637 m_clipLayer = 0;1638 m_scrollLayer = 0;1636 m_overflowControlsHostLayer = nullptr; 1637 m_clipLayer = nullptr; 1638 m_scrollLayer = nullptr; 1639 1639 } 1640 1640 ASSERT(!m_scrollLayer); 1641 m_rootPlatformLayer = 0;1641 m_rootPlatformLayer = nullptr; 1642 1642 } 1643 1643 -
trunk/Source/WebCore/workers/SharedWorkerContext.cpp
r48701 r85094 45 45 PassRefPtr<MessageEvent> createConnectEvent(PassRefPtr<MessagePort> port) 46 46 { 47 RefPtr<MessageEvent> event = MessageEvent::create( new MessagePortArray(1, port));47 RefPtr<MessageEvent> event = MessageEvent::create(adoptPtr(new MessagePortArray(1, port))); 48 48 event->initEvent(eventNames().connectEvent, false, false); 49 49 return event;
Note: See TracChangeset
for help on using the changeset viewer.