Changeset 85123 in webkit


Ignore:
Timestamp:
Apr 27, 2011 5:00:43 PM (13 years ago)
Author:
ojan@chromium.org
Message:

2011-04-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

remove test that didn't make sense
https://bugs.webkit.org/show_bug.cgi?id=59658

It was artifically saying the test wasn't expected to pass,
but the expectations string was empty. The case of unexpected
passes with a real expectations string is tested later in the
same test.

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r85120 r85123  
     12011-04-27  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        remove test that didn't make sense
     6        https://bugs.webkit.org/show_bug.cgi?id=59658
     7
     8        It was artifically saying the test wasn't expected to pass,
     9        but the expectations string was empty. The case of unexpected
     10        passes with a real expectations string is tested later in the
     11        same test.
     12
     13        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
     14
    1152011-04-27  Sam Weinig  <sam@webkit.org>
    216
  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py

    r84594 r85123  
    544544        self.assertFalse(out.empty())
    545545
    546         # test unexpected flaky results
    547         err.reset()
    548         out.reset()
    549         ur = get_unexpected_results(expected=False, passing=True, flaky=False)
    550         printer.print_unexpected_results(ur)
    551         self.assertTrue(err.empty())
    552         self.assertFalse(out.empty())
    553 
    554         # test unexpected passes
     546        # test unexpected flaky
    555547        err.reset()
    556548        out.reset()
Note: See TracChangeset for help on using the changeset viewer.