Changeset 85195 in webkit

Timestamp:

Apr 28, 2011 9:38:55 AM (13 years ago)

Author:

ddkilzer@apple.com

Message:

<​http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called

Reviewed by Simon Fraser.

• wtf/mac/MainThreadMac.mm:

(WTF::postTimer): Use RetainPtr to plug the leak.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/mac/MainThreadMac.mm (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-04-28  David Kilzer  <ddkilzer@apple.com>
+
+        <http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called
+
+        Reviewed by Simon Fraser.
+
+        * wtf/mac/MainThreadMac.mm:
+        (WTF::postTimer): Use RetainPtr to plug the leak.
+
 2011-04-27  Sam Weinig  <sam@webkit.org>
 

trunk/Source/JavaScriptCore/wtf/mac/MainThreadMac.mm

@@ -34 +34 @@
 #import <stdio.h>
 #import <wtf/Assertions.h>
+#import <wtf/RetainPtr.h>
 #import <wtf/Threading.h>
 
@@ -96 +97 @@
 
     isTimerPosted = true;
-    CFRunLoopAddTimer(CFRunLoopGetCurrent(), CFRunLoopTimerCreate(0, 0, 0, 0, 0, timerFired, 0), kCFRunLoopCommonModes);
+    RetainPtr<CFRunLoopTimerRef> runLoopTimer(AdoptCF, CFRunLoopTimerCreate(0, 0, 0, 0, 0, timerFired, 0));
+    CFRunLoopAddTimer(CFRunLoopGetCurrent(), runLoopTimer.get(), kCFRunLoopCommonModes);
 }