Changeset 85198 in webkit
- Timestamp:
- Apr 28, 2011 9:48:46 AM (13 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 6 edited
- 2 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r85197 r85198 1 2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 Reviewed by Martin Robinson. 4 5 [GTK] Move WebView to UIProcess/API/gtk 6 https://bugs.webkit.org/show_bug.cgi?id=59686 7 8 And rename it as PageClientImpl, since it's a page client 9 implementation, not a web view. 10 11 * GNUmakefile.am: 12 * UIProcess/API/C/gtk/WKView.cpp: 13 * UIProcess/API/gtk/PageClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebView.cpp. 14 (WebKit::backspaceCallback): 15 (WebKit::selectAllCallback): 16 (WebKit::cutClipboardCallback): 17 (WebKit::copyClipboardCallback): 18 (WebKit::pasteClipboardCallback): 19 (WebKit::toggleOverwriteCallback): 20 (WebKit::popupMenuCallback): 21 (WebKit::showHelpCallback): 22 (WebKit::deleteFromCursorCallback): 23 (WebKit::moveCursorCallback): 24 (WebKit::PageClientImpl::PageClientImpl): 25 (WebKit::PageClientImpl::~PageClientImpl): 26 (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): 27 (WebKit::PageClientImpl::createDrawingAreaProxy): 28 (WebKit::PageClientImpl::setViewNeedsDisplay): 29 (WebKit::PageClientImpl::displayView): 30 (WebKit::PageClientImpl::scrollView): 31 (WebKit::PageClientImpl::viewSize): 32 (WebKit::PageClientImpl::isViewWindowActive): 33 (WebKit::PageClientImpl::isViewFocused): 34 (WebKit::PageClientImpl::isViewVisible): 35 (WebKit::PageClientImpl::isViewInWindow): 36 (WebKit::PageClientImpl::PageClientImpl::processDidCrash): 37 (WebKit::PageClientImpl::didRelaunchProcess): 38 (WebKit::PageClientImpl::takeFocus): 39 (WebKit::PageClientImpl::toolTipChanged): 40 (WebKit::PageClientImpl::setCursor): 41 (WebKit::PageClientImpl::setViewportArguments): 42 (WebKit::PageClientImpl::registerEditCommand): 43 (WebKit::PageClientImpl::clearAllEditCommands): 44 (WebKit::PageClientImpl::canUndoRedo): 45 (WebKit::PageClientImpl::executeUndoRedo): 46 (WebKit::PageClientImpl::convertToDeviceSpace): 47 (WebKit::PageClientImpl::convertToUserSpace): 48 (WebKit::PageClientImpl::windowToScreen): 49 (WebKit::PageClientImpl::doneWithKeyEvent): 50 (WebKit::PageClientImpl::didNotHandleKeyEvent): 51 (WebKit::PageClientImpl::createPopupMenuProxy): 52 (WebKit::PageClientImpl::createContextMenuProxy): 53 (WebKit::PageClientImpl::setFindIndicator): 54 (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing): 55 (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing): 56 (WebKit::PageClientImpl::didCommitLoadForMainFrame): 57 (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): 58 (WebKit::PageClientImpl::customRepresentationZoomFactor): 59 (WebKit::PageClientImpl::setCustomRepresentationZoomFactor): 60 (WebKit::PageClientImpl::pageClosed): 61 (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame): 62 (WebKit::PageClientImpl::flashBackingStoreUpdates): 63 (WebKit::PageClientImpl::findStringInCustomRepresentation): 64 (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): 65 * UIProcess/API/gtk/PageClientImpl.h: Renamed from Source/WebKit2/UIProcess/gtk/WebView.h. 66 (WebKit::PageClientImpl::create): 67 (WebKit::PageClientImpl::addPendingEditorCommand): 68 (WebKit::PageClientImpl::userSpaceScaleFactor): 69 * UIProcess/API/gtk/WebKitWebViewBase.cpp: 70 (webkitWebViewBaseInit): 71 (webkitWebViewBaseCreate): 72 * UIProcess/API/gtk/WebKitWebViewBase.h: 73 * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: 74 1 75 2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com> 2 76 -
trunk/Source/WebKit2/GNUmakefile.am
r85059 r85198 351 351 Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp \ 352 352 Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h \ 353 Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h \ 354 Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp \ 353 355 Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.h \ 354 356 Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp \ … … 381 383 Source/WebKit2/UIProcess/gtk/WebPageProxyGtk.cpp \ 382 384 Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp \ 383 Source/WebKit2/UIProcess/gtk/WebView.cpp \384 Source/WebKit2/UIProcess/gtk/WebView.h \385 385 Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp \ 386 386 Source/WebKit2/UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp \ -
trunk/Source/WebKit2/UIProcess/API/C/gtk/WKView.cpp
r85196 r85198 31 31 #include "WKAPICast.h" 32 32 #include "WebKitWebViewBase.h" 33 #include "WebView.h"34 33 #include <wtf/PassRefPtr.h> 35 34 #include <wtf/RefPtr.h> -
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
r85197 r85198 27 27 28 28 #include "config.h" 29 #include " WebView.h"29 #include "PageClientImpl.h" 30 30 31 31 #include "ChunkedUpdateDrawingAreaProxy.h" … … 46 46 namespace WebKit { 47 47 48 static void backspaceCallback(GtkWidget* widget, WebView* client)48 static void backspaceCallback(GtkWidget* widget, PageClientImpl* client) 49 49 { 50 50 g_signal_stop_emission_by_name(widget, "backspace"); … … 52 52 } 53 53 54 static void selectAllCallback(GtkWidget* widget, gboolean select, WebView* client)54 static void selectAllCallback(GtkWidget* widget, gboolean select, PageClientImpl* client) 55 55 { 56 56 g_signal_stop_emission_by_name(widget, "select-all"); … … 58 58 } 59 59 60 static void cutClipboardCallback(GtkWidget* widget, WebView* client)60 static void cutClipboardCallback(GtkWidget* widget, PageClientImpl* client) 61 61 { 62 62 g_signal_stop_emission_by_name(widget, "cut-clipboard"); … … 64 64 } 65 65 66 static void copyClipboardCallback(GtkWidget* widget, WebView* client)66 static void copyClipboardCallback(GtkWidget* widget, PageClientImpl* client) 67 67 { 68 68 g_signal_stop_emission_by_name(widget, "copy-clipboard"); … … 70 70 } 71 71 72 static void pasteClipboardCallback(GtkWidget* widget, WebView* client)72 static void pasteClipboardCallback(GtkWidget* widget, PageClientImpl* client) 73 73 { 74 74 g_signal_stop_emission_by_name(widget, "paste-clipboard"); … … 106 106 }; 107 107 108 static void deleteFromCursorCallback(GtkWidget* widget, GtkDeleteType deleteType, gint count, WebView* client)108 static void deleteFromCursorCallback(GtkWidget* widget, GtkDeleteType deleteType, gint count, PageClientImpl* client) 109 109 { 110 110 g_signal_stop_emission_by_name(widget, "delete-from-cursor"); … … 165 165 }; 166 166 167 static void moveCursorCallback(GtkWidget* widget, GtkMovementStep step, gint count, gboolean extendSelection, WebView* client)167 static void moveCursorCallback(GtkWidget* widget, GtkMovementStep step, gint count, gboolean extendSelection, PageClientImpl* client) 168 168 { 169 169 g_signal_stop_emission_by_name(widget, "move-cursor"); … … 221 221 }; 222 222 223 WebView::WebView(GtkWidget* viewWidget)223 PageClientImpl::PageClientImpl(GtkWidget* viewWidget) 224 224 : m_viewWidget(viewWidget) 225 225 , m_nativeWidget(gtk_text_view_new()) … … 237 237 } 238 238 239 WebView::~WebView()240 { 241 } 242 243 void WebView::getEditorCommandsForKeyEvent(const NativeWebKeyboardEvent& event, Vector<WTF::String>& commandList)239 PageClientImpl::~PageClientImpl() 240 { 241 } 242 243 void PageClientImpl::getEditorCommandsForKeyEvent(const NativeWebKeyboardEvent& event, Vector<WTF::String>& commandList) 244 244 { 245 245 m_pendingEditorCommands.clear(); … … 288 288 289 289 // PageClient's pure virtual functions 290 PassOwnPtr<DrawingAreaProxy> WebView::createDrawingAreaProxy()290 PassOwnPtr<DrawingAreaProxy> PageClientImpl::createDrawingAreaProxy() 291 291 { 292 292 WebKitWebViewBase* view = WEBKIT_WEB_VIEW_BASE(m_viewWidget); … … 294 294 } 295 295 296 void WebView::setViewNeedsDisplay(const WebCore::IntRect&)297 { 298 notImplemented(); 299 } 300 301 void WebView::displayView()302 { 303 notImplemented(); 304 } 305 306 void WebView::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset)307 { 308 notImplemented(); 309 } 310 311 WebCore::IntSize WebView::viewSize()296 void PageClientImpl::setViewNeedsDisplay(const WebCore::IntRect&) 297 { 298 notImplemented(); 299 } 300 301 void PageClientImpl::displayView() 302 { 303 notImplemented(); 304 } 305 306 void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset) 307 { 308 notImplemented(); 309 } 310 311 WebCore::IntSize PageClientImpl::viewSize() 312 312 { 313 313 GtkAllocation allocation; … … 316 316 } 317 317 318 bool WebView::isViewWindowActive()318 bool PageClientImpl::isViewWindowActive() 319 319 { 320 320 notImplemented(); … … 322 322 } 323 323 324 bool WebView::isViewFocused()324 bool PageClientImpl::isViewFocused() 325 325 { 326 326 notImplemented(); … … 328 328 } 329 329 330 bool WebView::isViewVisible()330 bool PageClientImpl::isViewVisible() 331 331 { 332 332 notImplemented(); … … 334 334 } 335 335 336 bool WebView::isViewInWindow()336 bool PageClientImpl::isViewInWindow() 337 337 { 338 338 notImplemented(); … … 340 340 } 341 341 342 void WebView::WebView::processDidCrash()343 { 344 notImplemented(); 345 } 346 347 void WebView::didRelaunchProcess()348 { 349 notImplemented(); 350 } 351 352 void WebView::takeFocus(bool)353 { 354 notImplemented(); 355 } 356 357 void WebView::toolTipChanged(const String&, const String&)358 { 359 notImplemented(); 360 } 361 362 void WebView::setCursor(const Cursor& cursor)342 void PageClientImpl::PageClientImpl::processDidCrash() 343 { 344 notImplemented(); 345 } 346 347 void PageClientImpl::didRelaunchProcess() 348 { 349 notImplemented(); 350 } 351 352 void PageClientImpl::takeFocus(bool) 353 { 354 notImplemented(); 355 } 356 357 void PageClientImpl::toolTipChanged(const String&, const String&) 358 { 359 notImplemented(); 360 } 361 362 void PageClientImpl::setCursor(const Cursor& cursor) 363 363 { 364 364 // [GTK] Widget::setCursor() gets called frequently … … 373 373 } 374 374 375 void WebView::setViewportArguments(const WebCore::ViewportArguments&)376 { 377 notImplemented(); 378 } 379 380 void WebView::registerEditCommand(PassRefPtr<WebEditCommandProxy>, WebPageProxy::UndoOrRedo)381 { 382 notImplemented(); 383 } 384 385 void WebView::clearAllEditCommands()386 { 387 notImplemented(); 388 } 389 390 bool WebView::canUndoRedo(WebPageProxy::UndoOrRedo)375 void PageClientImpl::setViewportArguments(const WebCore::ViewportArguments&) 376 { 377 notImplemented(); 378 } 379 380 void PageClientImpl::registerEditCommand(PassRefPtr<WebEditCommandProxy>, WebPageProxy::UndoOrRedo) 381 { 382 notImplemented(); 383 } 384 385 void PageClientImpl::clearAllEditCommands() 386 { 387 notImplemented(); 388 } 389 390 bool PageClientImpl::canUndoRedo(WebPageProxy::UndoOrRedo) 391 391 { 392 392 notImplemented(); … … 394 394 } 395 395 396 void WebView::executeUndoRedo(WebPageProxy::UndoOrRedo)397 { 398 notImplemented(); 399 } 400 401 FloatRect WebView::convertToDeviceSpace(const FloatRect& viewRect)396 void PageClientImpl::executeUndoRedo(WebPageProxy::UndoOrRedo) 397 { 398 notImplemented(); 399 } 400 401 FloatRect PageClientImpl::convertToDeviceSpace(const FloatRect& viewRect) 402 402 { 403 403 notImplemented(); … … 405 405 } 406 406 407 FloatRect WebView::convertToUserSpace(const FloatRect& viewRect)407 FloatRect PageClientImpl::convertToUserSpace(const FloatRect& viewRect) 408 408 { 409 409 notImplemented(); … … 411 411 } 412 412 413 IntRect WebView::windowToScreen(const IntRect& rect)413 IntRect PageClientImpl::windowToScreen(const IntRect& rect) 414 414 { 415 415 notImplemented(); … … 417 417 } 418 418 419 void WebView::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled)420 { 421 notImplemented(); 422 } 423 424 void WebView::didNotHandleKeyEvent(const NativeWebKeyboardEvent& event)425 { 426 notImplemented(); 427 } 428 429 PassRefPtr<WebPopupMenuProxy> WebView::createPopupMenuProxy(WebPageProxy*)419 void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled) 420 { 421 notImplemented(); 422 } 423 424 void PageClientImpl::didNotHandleKeyEvent(const NativeWebKeyboardEvent& event) 425 { 426 notImplemented(); 427 } 428 429 PassRefPtr<WebPopupMenuProxy> PageClientImpl::createPopupMenuProxy(WebPageProxy*) 430 430 { 431 431 notImplemented(); … … 433 433 } 434 434 435 PassRefPtr<WebContextMenuProxy> WebView::createContextMenuProxy(WebPageProxy*)435 PassRefPtr<WebContextMenuProxy> PageClientImpl::createContextMenuProxy(WebPageProxy*) 436 436 { 437 437 notImplemented(); … … 439 439 } 440 440 441 void WebView::setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut)441 void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut) 442 442 { 443 443 notImplemented(); … … 445 445 446 446 #if USE(ACCELERATED_COMPOSITING) 447 void WebView::pageDidEnterAcceleratedCompositing()448 { 449 notImplemented(); 450 } 451 452 void WebView::pageDidLeaveAcceleratedCompositing()447 void PageClientImpl::pageDidEnterAcceleratedCompositing() 448 { 449 notImplemented(); 450 } 451 452 void PageClientImpl::pageDidLeaveAcceleratedCompositing() 453 453 { 454 454 notImplemented(); … … 456 456 #endif // USE(ACCELERATED_COMPOSITING) 457 457 458 void WebView::didCommitLoadForMainFrame(bool useCustomRepresentation)459 { 460 } 461 462 void WebView::didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&)463 { 464 } 465 466 double WebView::customRepresentationZoomFactor()458 void PageClientImpl::didCommitLoadForMainFrame(bool useCustomRepresentation) 459 { 460 } 461 462 void PageClientImpl::didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&) 463 { 464 } 465 466 double PageClientImpl::customRepresentationZoomFactor() 467 467 { 468 468 notImplemented(); … … 470 470 } 471 471 472 void WebView::setCustomRepresentationZoomFactor(double)473 { 474 notImplemented(); 475 } 476 477 void WebView::pageClosed()478 { 479 notImplemented(); 480 } 481 482 void WebView::didChangeScrollbarsForMainFrame() const483 { 484 } 485 486 void WebView::flashBackingStoreUpdates(const Vector<IntRect>&)487 { 488 notImplemented(); 489 } 490 491 void WebView::findStringInCustomRepresentation(const String&, FindOptions, unsigned)492 { 493 notImplemented(); 494 } 495 496 void WebView::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned)472 void PageClientImpl::setCustomRepresentationZoomFactor(double) 473 { 474 notImplemented(); 475 } 476 477 void PageClientImpl::pageClosed() 478 { 479 notImplemented(); 480 } 481 482 void PageClientImpl::didChangeScrollbarsForMainFrame() const 483 { 484 } 485 486 void PageClientImpl::flashBackingStoreUpdates(const Vector<IntRect>&) 487 { 488 notImplemented(); 489 } 490 491 void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned) 492 { 493 notImplemented(); 494 } 495 496 void PageClientImpl::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned) 497 497 { 498 498 notImplemented(); -
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h
r85197 r85198 26 26 */ 27 27 28 #ifndef WebView_h29 #define WebView_h28 #ifndef PageClientImpl_h 29 #define PageClientImpl_h 30 30 31 31 #include "PageClient.h" … … 40 40 class WebPageNamespace; 41 41 42 class WebView: public PageClient {42 class PageClientImpl : public PageClient { 43 43 public: 44 ~ WebView();45 static PassOwnPtr< WebView> create(GtkWidget* viewWidget)44 ~PageClientImpl(); 45 static PassOwnPtr<PageClientImpl> create(GtkWidget* viewWidget) 46 46 { 47 return adoptPtr(new WebView(viewWidget));47 return adoptPtr(new PageClientImpl(viewWidget)); 48 48 } 49 49 … … 51 51 52 52 private: 53 WebView(GtkWidget*);53 PageClientImpl(GtkWidget*); 54 54 55 // PageClient56 55 virtual PassOwnPtr<DrawingAreaProxy> createDrawingAreaProxy(); 57 56 virtual void setViewNeedsDisplay(const WebCore::IntRect&); … … 99 98 virtual void setCustomRepresentationZoomFactor(double); 100 99 101 // Members of WebViewclass100 // Members of PageClientImpl class 102 101 GtkWidget* m_viewWidget; 103 102 Vector<WTF::String> m_pendingEditorCommands; … … 107 106 } // namespace WebKit 108 107 109 #endif // WebView_h108 #endif // PageClientImpl_h -
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
r85197 r85198 34 34 #include "NativeWebMouseEvent.h" 35 35 #include "NotImplemented.h" 36 #include "PageClientImpl.h" 36 37 #include "RefPtrCairo.h" 37 38 #include "WebContext.h" … … 46 47 47 48 struct _WebKitWebViewBasePrivate { 48 OwnPtr< WebView> webViewInstance;49 OwnPtr<PageClientImpl> pageClient; 49 50 RefPtr<WebPageProxy> page; 50 51 gboolean isPageActive; … … 147 148 priv->previousClickTime = 0; 148 149 149 priv-> webViewInstance = WebView::create(GTK_WIDGET(webkitWebViewBase));150 priv->pageClient = PageClientImpl::create(GTK_WIDGET(webkitWebViewBase)); 150 151 } 151 152 … … 396 397 WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv; 397 398 398 priv->page = context->createWebPage(priv-> webViewInstance.get(), pageGroup);399 priv->page = context->createWebPage(priv->pageClient.get(), pageGroup); 399 400 priv->page->initializeWebPage(); 400 401 -
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.h
r85197 r85198 29 29 #define WebKitWebViewBase_h 30 30 31 #include "WebView.h" 32 31 #include "WebPageProxy.h" 33 32 #include <gtk/gtk.h> 34 33 -
trunk/Source/WebKit2/UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp
r85193 r85198 33 33 #include "WebKitWebViewBase.h" 34 34 #include "WebProcessProxy.h" 35 #include "WebView.h"36 35 #include <WebCore/GtkVersioning.h> 37 36 #include <gdk/gdk.h>
Note: See TracChangeset
for help on using the changeset viewer.