Changeset 85209 in webkit


Ignore:
Timestamp:
Apr 28, 2011 10:52:15 AM (13 years ago)
Author:
Dimitri Glazkov
Message:

2011-04-28 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Unskip fast/dom/shadow/gc-shadow.html on Mac with expected failure
​https://bugs.webkit.org/show_bug.cgi?id=59647

  • fast/dom/shadow/gc-shadow.html: Actually GC the shadow roots now.
  • fast/dom/shadow/gc-shadow-expected.txt: Updated.
  • platform/mac/Skipped: Unskip gc-shadow.html.
  • platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r85207 r85209  
     12011-04-28  Dominic Cooney  <dominicc@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Unskip fast/dom/shadow/gc-shadow.html on Mac with expected failure
     6        https://bugs.webkit.org/show_bug.cgi?id=59647
     7
     8        * fast/dom/shadow/gc-shadow.html: Actually GC the shadow roots now.
     9        * fast/dom/shadow/gc-shadow-expected.txt: Updated.
     10        * platform/mac/Skipped: Unskip gc-shadow.html.
     11        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.
     12
    1132011-04-28  Arno Renevier  <arno@renevier.net>
    214

  • trunk/LayoutTests/fast/dom/shadow/gc-shadow-expected.txt

    r84749 r85209  
    22are not prematurely garbage collected.
    33
    4 PASS shadow.tattoo is "I <3 WebKit"
     4PASS layoutTestController.shadowRoot(ps[0]).tattoo is "I <3 WebKit"
     5PASS layoutTestController.shadowRoot(ps[1]).tattoo is "I <3 WebKit"
     6PASS layoutTestController.shadowRoot(ps[2]).tattoo is "I <3 WebKit"
     7PASS layoutTestController.shadowRoot(ps[3]).tattoo is "I <3 WebKit"
     8PASS layoutTestController.shadowRoot(ps[4]).tattoo is "I <3 WebKit"
     9PASS layoutTestController.shadowRoot(ps[5]).tattoo is "I <3 WebKit"
     10PASS layoutTestController.shadowRoot(ps[6]).tattoo is "I <3 WebKit"
     11PASS layoutTestController.shadowRoot(ps[7]).tattoo is "I <3 WebKit"
     12PASS layoutTestController.shadowRoot(ps[8]).tattoo is "I <3 WebKit"
     13PASS layoutTestController.shadowRoot(ps[9]).tattoo is "I <3 WebKit"
    514PASS successfullyParsed is true
    615

  • trunk/LayoutTests/fast/dom/shadow/gc-shadow.html

    r84749 r85209  
    1111</pre>
    1212<script>
     13function gc() {
     14    if (window.GCController) {
     15        GCController.collect();
     16        return;
     17    }
     18
     19    for (var i = 0; i < 10000; i++)
     20        new String(i);
     21}
     22
    1323if (window.layoutTestController) {
    14     var p = document.createElement('p');
    15     var shadow = layoutTestController.ensureShadowRoot(p);
    16     shadow.tattoo = 'I <3 WebKit';
    17     shadow = null;
     24    var ps = [];
    1825
    19     GCController.collect();
     26    for (var i = 0; i < 10; i++) {
     27        var p = document.createElement('p');
     28        ps.push(p);
    2029
    21     shadow = layoutTestController.shadowRoot(p);
    22     shouldBe('shadow.tattoo', '"I <3 WebKit"');
     30        var shadow = layoutTestController.ensureShadowRoot(p);
     31        shadow.tattoo = 'I <3 WebKit';
     32        shadow = null;
     33    }
     34
     35    gc();
     36
     37    for (i = 0; i < ps.length; i++) {
     38        shouldBe('layoutTestController.shadowRoot(ps[' + i + ']).tattoo', '"I <3 WebKit"');
     39    }
    2340}
    2441

  • trunk/LayoutTests/platform/mac/Skipped

    r85202 r85209  
    342342
    343343# Unskip when https://bugs.webkit.org/show_bug.cgi?id=59571 is fixed
    344 fast/dom/shadow/gc-shadow.html
    345344fast/dom/shadow/no-renderers-for-light-children.html
    346345
Note: See TracChangeset for help on using the changeset viewer.