Changeset 85237 in webkit

Timestamp:

Apr 28, 2011 2:02:31 PM (13 years ago)

Author:

ddkilzer@apple.com

Message:

Follow-up fix: <​http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects

Addresses review comment from Darin Adler.

• WebView/WebPDFView.mm:

(-[WebPDFView menuForEvent:]): Use a local variable and -release
instead of -autorelease.

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebPDFView.mm (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2011-04-28  David Kilzer  <ddkilzer@apple.com>
+
+        Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
+
+        Addresses review comment from Darin Adler.
+
+        * WebView/WebPDFView.mm:
+        (-[WebPDFView menuForEvent:]): Use a local variable and -release
+        instead of -autorelease.
+
 2011-04-28  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebPDFView.mm

@@ -393 +393 @@
             // copy menuItem since a given menuItem can be in only one menu at a time, and we don't
             // want to mess with the menu returned from PDFKit.
-            [menu addItem:[[menuItem copy] autorelease]];
+            NSMenuItem *menuItemCopy = [menuItem copy];
+            [menu addItem:menuItemCopy];
+            [menuItemCopy release];
         }
     }