Changeset 85266 in webkit

Timestamp:

Apr 28, 2011 5:06:27 PM (13 years ago)

Author:

loislo@chromium.org

Message:

2011-04-28 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85101.
​http://trac.webkit.org/changeset/85101
​https://bugs.webkit.org/show_bug.cgi?id=59757

it'd be better to rollout the patch and do another one with

another property name. Current one will bring us to a problem
at first run after upgrade because it's type was changed from
int to string. (Requested by loislo on #webkit).

• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r85101.
+        http://trac.webkit.org/changeset/85101
+        https://bugs.webkit.org/show_bug.cgi?id=59757
+
+         it'd be better to rollout the patch and do another one with
+        another property name. Current one will bring us to a problem
+        at first run after upgrade because it's type was changed from
+        int to string. (Requested by loislo on #webkit).
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
+        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
+        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
+
 2011-04-28  Mike Reed  <reed@google.com>
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -447 +447 @@
     _debuggerWasEnabled: function()
     {
-        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionState);
+        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionStateString);
 
         if (this._debuggerEnabled)
@@ -716 +716 @@
 
             this._pauseOnExceptionButton.state = pauseOnExceptionsState;
-            WebInspector.settings.pauseOnExceptionState = pauseOnExceptionsState;
+            WebInspector.settings.pauseOnExceptionStateString = pauseOnExceptionsState;
         }
         DebuggerAgent.setPauseOnExceptions(pauseOnExceptionsState, callback.bind(this));