Changeset 85482 in webkit

Timestamp:

May 2, 2011 9:52:44 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

StringImpl::endsWith has some insane code
​https://bugs.webkit.org/show_bug.cgi?id=59900

• wtf/text/StringImpl.cpp: (WTF::StringImpl::endsWith):
  • m_data shadows a member variable of the same name.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/StringImpl.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-05-02  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        StringImpl::endsWith has some insane code
+        https://bugs.webkit.org/show_bug.cgi?id=59900
+
+        * wtf/text/StringImpl.cpp:
+        (WTF::StringImpl::endsWith):
+            - m_data shadows a member variable of the same name.
+
 2011-05-02  Gabor Loki  <loki@webkit.org>
 

trunk/Source/JavaScriptCore/wtf/text/StringImpl.cpp

@@ -762 +762 @@
 }
 
-bool StringImpl::endsWith(StringImpl* m_data, bool caseSensitive)
-{
-    ASSERT(m_data);
-    if (m_length >= m_data->m_length) {
-        unsigned start = m_length - m_data->m_length;
-        return (caseSensitive ? find(m_data, start) : findIgnoringCase(m_data, start)) == start;
+bool StringImpl::endsWith(StringImpl* matchString, bool caseSensitive)
+{
+    ASSERT(matchString);
+    if (m_length >= matchString->m_length) {
+        unsigned start = m_length - matchString->m_length;
+        return (caseSensitive ? find(matchString, start) : findIgnoringCase(matchString, start)) == start;
     }
     return false;