Changeset 85527 in webkit
- Timestamp:
- May 2, 2011 3:13:38 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 4 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r85525 r85527 1 2011-04-27 Adrienne Walker <enne@google.com> 2 3 Reviewed by James Robinson. 4 5 Add test for multiple invalidations of the same size. 6 https://bugs.webkit.org/show_bug.cgi?id=58907 7 8 This tests a bug in Chromium where canvas state was not being properly 9 reset between draw calls and a cached canvas of the same size was 10 being used to paint into that retained incorrect state. 11 12 * compositing/repaint/same-size-invalidation-expected.txt: Added. 13 * compositing/repaint/same-size-invalidation.html: Added. 14 * platform/chromium-gpu/compositing/repaint/same-size-invalidation-expected.png: Added. 15 1 16 2011-05-02 Alpha Lam <hclam@chromium.org> 2 17 -
trunk/Source/WebCore/ChangeLog
r85526 r85527 1 2011-04-19 Adrienne Walker <enne@google.com> 2 3 Reviewed by James Robinson. 4 5 [chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor 6 https://bugs.webkit.org/show_bug.cgi?id=58907 7 8 Additionally, move the context save/restore logic to a place where it 9 will reset the translation added in LayerTilerChromium. 10 11 Test: compositing/repaint/same-size-invalidation.html 12 13 * platform/graphics/chromium/ContentLayerChromium.cpp: 14 (WebCore::ContentLayerPainter::paint): 15 * platform/graphics/chromium/PlatformCanvas.cpp: 16 (WebCore::PlatformCanvas::resize): 17 (WebCore::PlatformCanvas::Painter::Painter): 18 (WebCore::PlatformCanvas::Painter::~Painter): 19 * platform/graphics/chromium/PlatformCanvas.h: 20 1 21 2011-05-02 Csaba Osztrogonác <ossy@webkit.org> 2 22 -
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp
r84582 r85527 78 78 virtual void paint(GraphicsContext& context, const IntRect& contentRect) 79 79 { 80 context.save();81 80 context.clearRect(contentRect); 82 81 context.clip(contentRect); 83 82 m_owner->paintGraphicsLayerContents(context, contentRect); 84 context.restore();85 83 } 86 84 private: -
trunk/Source/WebCore/platform/graphics/chromium/PlatformCanvas.cpp
r84101 r85527 51 51 void PlatformCanvas::resize(const IntSize& size) 52 52 { 53 if (m_size == size) 54 return; 53 55 m_size = size; 54 56 #if USE(SKIA) … … 108 110 m_context = adoptPtr(new GraphicsContext(m_contextCG.get())); 109 111 #endif 112 context()->save(); 110 113 } 111 114 112 115 PlatformCanvas::Painter::~Painter() 113 116 { 117 context()->restore(); 114 118 } 115 119 -
trunk/Source/WebCore/platform/graphics/chromium/PlatformCanvas.h
r84101 r85527 82 82 83 83 Painter(PlatformCanvas*, TextOption); 84 // Destructor restores canvas context to pre-construction state. 84 85 ~Painter(); 85 86
Note: See TracChangeset
for help on using the changeset viewer.