Changeset 85677 in webkit

Timestamp:

May 3, 2011 3:33:25 PM (13 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
​https://bugs.webkit.org/show_bug.cgi?id=60067

Reviewed by Darin Adler.

No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.

• rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderText.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-03  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Darin Adler.
+
+        <rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
+        https://bugs.webkit.org/show_bug.cgi?id=60067
+
+        No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.
+
+        * rendering/RenderText.cpp:
+        (WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
+        and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
+        results for flipped writing modes.
+
 2011-05-03  Anton Muhin  <antonm@chromium.org>
 

trunk/Source/WebCore/rendering/RenderText.cpp

@@ -292 +292 @@
         // Note: box->end() returns the index of the last character, not the index past it
         if (start <= box->start() && box->end() < end) {
-            IntRect r = IntRect(box->x(), box->y(), box->logicalWidth(), box->logicalHeight());
+            IntRect r = box->calculateBoundaries();
             if (useSelectionHeight) {
                 IntRect selectionRect = box->selectionRect(0, 0, start, end);
-                r.setHeight(selectionRect.height());
-                r.setY(selectionRect.y());
+                if (box->isHorizontal()) {
+                    r.setHeight(selectionRect.height());
+                    r.setY(selectionRect.y());
+                } else {
+                    r.setWidth(selectionRect.width());
+                    r.setX(selectionRect.x());
+                }
             }
-            FloatPoint origin = localToAbsolute(r.location());
-            r.setX(origin.x());
-            r.setY(origin.y());
-            rects.append(r);
+            rects.append(localToAbsoluteQuad(FloatQuad(r)).enclosingBoundingBox());
         } else {
             unsigned realEnd = min(box->end() + 1, end);
@@ -308 +310 @@
                 if (!useSelectionHeight) {
                     // change the height and y position because selectionRect uses selection-specific values
-                    r.setHeight(box->logicalHeight());
-                    r.setY(box->y());
+                    if (box->isHorizontal()) {
+                        r.setHeight(box->logicalHeight());
+                        r.setY(box->y());
+                    } else {
+                        r.setWidth(box->logicalWidth());
+                        r.setX(box->x());
+                    }
                 }
-                FloatPoint origin = localToAbsolute(r.location());
-                localToAbsolute(origin);
-                r.setX(origin.x());
-                r.setY(origin.y());
-                rects.append(r);
+                rects.append(localToAbsoluteQuad(FloatQuad(r)).enclosingBoundingBox());
             }
         }