Changeset 85767 in webkit

Timestamp:

May 4, 2011 11:39:26 AM (13 years ago)

Author:

jer.noble@apple.com

Message:

2011-05-04 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Entering full screen fails >= second time on Vimeo.com.
​https://bugs.webkit.org/show_bug.cgi?id=60143

Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
at the end of an animation, if it determined that the RenderFullScreen would still require
a layer even when not animating.

• rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): Clear the renderer's layer.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderFullScreen.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-04  Jer Noble  <jer.noble@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Entering full screen fails >= second time on Vimeo.com.
+        https://bugs.webkit.org/show_bug.cgi?id=60143
+
+        Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
+        Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
+        at the end of an animation, if it determined that the RenderFullScreen would still require
+        a layer even when not animating.
+
+        * rendering/RenderFullScreen.cpp:
+        (RenderFullScreen::setAnimating): Clear the renderer's layer.
+
 2011-05-04  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderFullScreen.cpp

@@ -31 +31 @@
 #include "RenderLayer.h"
 
+#if USE(ACCELERATED_COMPOSITING)
+#include "RenderLayerCompositor.h"
+#endif
+
 using namespace WebCore;
 
@@ -37 +41 @@
     m_isAnimating = animating;
 #if USE(ACCELERATED_COMPOSITING)
-    if (layer())
+    if (layer()) {
         layer()->contentChanged(RenderLayer::FullScreenChanged);
+        // Clearing the layer's backing will force the compositor to reparent
+        // the layer the next time layers are synchronized.
+        layer()->clearBacking();
+    }
 #endif
 }