Changeset 85770 in webkit
- Timestamp:
- May 4, 2011 11:55:18 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r85769 r85770 1 2011-05-04 Mark Pilgrim <pilgrim@chromium.org> 2 3 Reviewed by Tony Chang. 4 5 IndexedDB open (database) should fail if name is null 6 https://bugs.webkit.org/show_bug.cgi?id=60022 7 8 * storage/indexeddb/mozilla/open-database-null-name-expected.txt: Added. 9 * storage/indexeddb/mozilla/open-database-null-name.html: Added. 10 1 11 2011-05-04 Ojan Vafai <ojan@chromium.org> 2 12 -
trunk/Source/WebCore/ChangeLog
r85767 r85770 1 2011-05-04 Mark Pilgrim <pilgrim@chromium.org> 2 3 Reviewed by Tony Chang. 4 5 IndexedDB open (database) should fail if name is null 6 https://bugs.webkit.org/show_bug.cgi?id=60022 7 8 Test: storage/indexeddb/mozilla/open-database-null-name.html 9 10 Combination problem: Bug in IDL didn't pass null values to .cpp layer, 11 then .cpp layer didn't check for null value anyway. 12 13 * storage/IDBFactory.cpp: 14 (WebCore::IDBFactory::open): check for null name 15 * storage/IDBFactory.idl: pass null name as null 16 1 17 2011-05-04 Jer Noble <jer.noble@apple.com> 2 18 -
trunk/Source/WebCore/storage/IDBFactory.cpp
r85395 r85770 70 70 return 0; 71 71 72 73 // FIXME: Raise a NON_TRANSIENT_ERR if the name is invalid. 74 72 if (name.isNull()) { 73 ec = IDBDatabaseException::NON_TRANSIENT_ERR; 74 return 0; 75 } 75 76 76 77 RefPtr<IDBRequest> request = IDBRequest::create(document, IDBAny::create(this), 0); -
trunk/Source/WebCore/storage/IDBFactory.idl
r72753 r85770 29 29 Conditional=INDEXED_DATABASE 30 30 ] IDBFactory { 31 [CallWith=ScriptExecutionContext] IDBRequest open(in DOMString name)31 [CallWith=ScriptExecutionContext] IDBRequest open(in [ConvertNullToNullString] DOMString name) 32 32 raises (IDBDatabaseException); 33 33 };
Note: See TracChangeset
for help on using the changeset viewer.