Changeset 85797 in webkit


Ignore:
Timestamp:
May 4, 2011 3:45:07 PM (13 years ago)
Author:
koz@chromium.org
Message:

2011-05-04 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Add method to make a Port able to retrieve TestOutputSets from its builders.
https://bugs.webkit.org/show_bug.cgi?id=58211

This will be used in the new rebaseline script - TestOutputs are
potential new baselines.

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r85792 r85797  
     12011-05-04  James Kozianski  <koz@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Add method to make a Port able to retrieve TestOutputSets from its builders.
     6        https://bugs.webkit.org/show_bug.cgi?id=58211
     7
     8        This will be used in the new rebaseline script - TestOutputs are
     9        potential new baselines.
     10
     11        * Scripts/webkitpy/common/config/urls.py:
     12        * Scripts/webkitpy/layout_tests/port/base.py:
     13        * Scripts/webkitpy/layout_tests/port/chromium.py:
     14        * Scripts/webkitpy/layout_tests/port/factory.py:
     15        * Scripts/webkitpy/layout_tests/port/webkit.py:
     16
    1172011-05-04  Eric Seidel  <eric@webkit.org>
    218
  • trunk/Tools/Scripts/webkitpy/common/config/urls.py

    r85727 r85797  
    3838
    3939
     40def chromium_results_zip_url(builder_name):
     41    return 'http://build.chromium.org/f/chromium/layout_test_results/%s/layout-test-results.zip' % builder_name
     42
    4043chromium_lkgr_url = "http://chromium-status.appspot.com/lkgr"
    41 
    4244contribution_guidelines = "http://webkit.org/coding/contributing.html"
    4345
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py

    r85735 r85797  
    4141import time
    4242
     43from webkitpy.common.net.testoutputset import AggregateTestOutputSet
     44
    4345# Handle Python < 2.6 where multiprocessing isn't available.
    4446try:
     
    532534        expectations, determining search paths, and logging information."""
    533535        return self._version
     536
     537    def _results_for_platform(self, platform):
     538        """Returns a TestOutputSet for the bots of the given platform."""
     539        raise NotImplementedError('Port._results_for_platform')
     540
     541    def buildbot_test_output_set(self, platforms):
     542        """Returns a TestOutputSet for the specified platforms for this ports buildbots."""
     543        return AggregateTestOutputSet([self._results_for_platform(platform) for platform in platforms])
    534544
    535545    def graphics_type(self):
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py

    r85040 r85797  
    8484PORT_TO_BUILDER_NAME.update(CHROMIUM_PORT_TO_BUILDER_NAME)
    8585PORT_TO_BUILDER_NAME.update(WEBKIT_PORT_TO_BUILDER_NAME)
     86
     87
     88def builder_name_for_platform(platform):
     89    return PORT_TO_BUILDER_NAME.get(platform)
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py

    r85735 r85797  
    3939import webbrowser
    4040
     41from webkitpy.common.config import urls
     42from webkitpy.common.net.testoutputset import TestOutputSet
    4143from webkitpy.common.system import executive
    4244from webkitpy.common.system.path import cygpath
     45from webkitpy.common.system.zipfileset import ZipFileSet
    4346from webkitpy.layout_tests.layout_package import test_expectations
    4447from webkitpy.layout_tests.port import base
     48from webkitpy.layout_tests.port import builders
    4549from webkitpy.layout_tests.port import http_server
    4650from webkitpy.layout_tests.port import websocket_server
     
    198202            'chromium', 'test_expectations.txt')
    199203
     204    def _results_for_platform(self, platform):
     205        builder_name = builders.builder_name_for_platform(platform)
     206        if not builder_name:
     207            raise Exception("Can't find builder for %s" % platform)
     208        zip_url = urls.chromium_results_zip_url(builder_name)
     209        return TestOutputSet(builder_name, platform, ZipFileSet(zip_url),
     210                include_expected=False)
     211
    200212    def default_results_directory(self):
    201213        try:
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py

    r85735 r85797  
    4242import webbrowser
    4343
     44from webkitpy.common.net.buildbot import BuildBot
    4445from webkitpy.common.system import ospath
    45 from webkitpy.layout_tests.port import base
    46 from webkitpy.layout_tests.port import server_process
     46from webkitpy.layout_tests.port import base, builders, server_process
    4747
    4848_log = logging.getLogger("webkitpy.layout_tests.port.webkit")
     
    6767        return self._filesystem.join(self._webkit_baseline_path(self._name),
    6868                                     'test_expectations.txt')
     69
     70    def _results_for_platform(self, platform):
     71        builder_name = builders.builder_name_for_platform(platform)
     72        if not builder_name:
     73            raise Exception("Can't find builder for %s" % platform)
     74        builders_by_name = dict([(builder.name(), builder) for builder in BuildBot().builders()])
     75        builder = builders_by_name[builder_name]
     76        result_set = builder.latest_cached_build().results()
     77        result_set.set_platform(platform)
     78        return result_set
    6979
    7080    def _build_driver(self):
Note: See TracChangeset for help on using the changeset viewer.