Changeset 85825 in webkit


Ignore:
Timestamp:
May 4, 2011 8:03:24 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-04 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
​https://bugs.webkit.org/show_bug.cgi?id=60202

Adds a regression test for composited content changing from transform-style: preserve-3d to flat.

  • compositing/repaint/transform-style-change-expected.png: Added.
  • compositing/repaint/transform-style-change-expected.txt: Added.
  • compositing/repaint/transform-style-change.html: Added.

2011-05-04 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
​https://bugs.webkit.org/show_bug.cgi?id=60202

In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check. This switches
the order back and adds a regression test.

Test: compositing/repaint/transform-style-change.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r85824 r85825  
     12011-05-04  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
     6        https://bugs.webkit.org/show_bug.cgi?id=60202
     7
     8        Adds a regression test for composited content changing from transform-style: preserve-3d to flat.
     9
     10        * compositing/repaint/transform-style-change-expected.png: Added.
     11        * compositing/repaint/transform-style-change-expected.txt: Added.
     12        * compositing/repaint/transform-style-change.html: Added.
     13
    1142011-05-04  MORITA Hajime <morrita@google.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r85823 r85825  
     12011-05-04  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
     6        https://bugs.webkit.org/show_bug.cgi?id=60202
     7
     8        In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check.  This switches
     9        the order back and adds a regression test.
     10
     11        Test: compositing/repaint/transform-style-change.html
     12
     13        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
     14        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
     15
    1162011-05-04  Cris Neckar  <cdn@chromium.org>
    217

  • trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp

    r85136 r85825  
    589589    } else if (!m_preserves3D && m_transformLayer) {
    590590        // Relace the transformLayer in the parent with this layer.
     591        m_layer->removeFromSuperlayer();
    591592        if (m_transformLayer->superlayer())
    592593            m_transformLayer->superlayer()->replaceSublayer(m_transformLayer.get(), m_layer.get());
    593         m_layer->removeFromSuperlayer();
    594594
    595595        // Release the transform layer.
Note: See TracChangeset for help on using the changeset viewer.