Changeset 85895 in webkit


Ignore:
Timestamp:
May 5, 2011 3:39:16 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-05 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
​https://bugs.webkit.org/show_bug.cgi?id=60173

  • platform/chromium/test_expectations.txt: Adding expected failures for the the switch to Ganesh

2011-05-05 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
​https://bugs.webkit.org/show_bug.cgi?id=60173

  • page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): Flipping the switch to make Skia the default for the accelerated 2d canvas
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r85894 r85895  
     12011-05-05  Justin Novosad  <junov@chromium.org>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
     6        https://bugs.webkit.org/show_bug.cgi?id=60173
     7
     8        * platform/chromium/test_expectations.txt:
     9        Adding expected failures for the the switch to Ganesh
     10
    1112011-05-05  Tony Gentilcore  <tonyg@chromium.org>
    212

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r85880 r85895  
    996996BUGCR10322 SKIP : platform/mac/accessibility = PASS FAIL
    997997BUGCR10322 SKIP : platform/win/accessibility = PASS FAIL
     998
     999// -----------------------------------------------------------------
     1000// Test failures with Skia GPU rendering of canvas 2D
     1001// -----------------------------------------------------------------
     1002
     1003// shadow rendering issues
     1004BUGCR79896 WIN LINUX GPU : fast/canvas/shadow-offset-1.html = IMAGE
     1005BUGCR79896 WIN LINUX GPU : fast/canvas/shadow-offset-2.html = IMAGE
     1006BUGCR79896 WIN LINUX GPU : fast/canvas/shadow-offset-3.html = IMAGE
     1007BUGCR79896 WIN LINUX GPU : fast/canvas/shadow-offset-4.html = IMAGE
     1008BUGCR79896 WIN LINUX GPU : fast/canvas/shadow-offset-5.html = IMAGE
     1009BUGCR79896 WIN LINUX GPU : fast/canvas/shadow-offset-6.html = IMAGE
     1010BUGCR79896 WIN LINUX GPU : fast/canvas/shadow-offset-7.html = IMAGE
     1011BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.fillRect.shadow.html = TEXT
     1012BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.alpha.2.html = TEXT
     1013BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.clip.1.html = TEXT
     1014BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.clip.3.html = TEXT
     1015BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.enable.x.html = TEXT
     1016BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.enable.y.html = TEXT
     1017BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.gradient.alpha.html = TEXT
     1018BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.gradient.basic.html = TEXT
     1019BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.gradient.transparent.2.html = TEXT
     1020BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.outside.html = TEXT
     1021BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.pattern.alpha.html = TEXT
     1022BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.pattern.basic.html = TEXT
     1023BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.pattern.transparent.2.html = TEXT
     1024BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.stroke.basic.html = TEXT
     1025BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.stroke.cap.2.html = TEXT
     1026BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.stroke.join.2.html = TEXT
     1027BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.transform.1.html = TEXT
     1028BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.shadow.transform.2.html = TEXT
     1029BUGCR79896 WIN LINUX GPU : canvas/philip/tests/2d.strokeRect.shadow.html = TEXT
     1030BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-createPattern-fillRect-shadow.html = TEXT
     1031BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-fillRect-gradient-shadow.html = TEXT
     1032BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-fillRect-shadow.html = TEXT
     1033BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-scale-fillPath-shadow.html = TEXT
     1034BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-scale-fillRect-shadow.html = TEXT
     1035BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-scale-shadowBlur.html = TEXT
     1036BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-scale-strokePath-shadow.html = TEXT
     1037BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-fillPath-shadow.html = TEXT
     1038BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-shadow.html = TEXT
     1039
     1040// Once BUGCR79896 is resolved, these 4 tests may still be expected to time out (BUGWK57547)
     1041BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-strokePath-gradient-shadow.html = TEXT TIMEOUT
     1042BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-strokeRect-gradient-shadow.html = TEXT TIMEOUT
     1043BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-fillPath-gradient-shadow.html = TEXT TIMEOUT
     1044BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-fillPath-pattern-shadow.html = TEXT TIMEOUT
     1045
     1046BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-strokePath-shadow.html = TEXT
     1047BUGCR79896 WIN LINUX GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT
     1048
     1049// Flaky test
     1050BUGCR81585 LINUX GPU : canvas/philip/tests/2d.drawImage.alpha.html = TEXT
     1051BUGCR81585 LINUX GPU : canvas/philip/tests/2d.drawImage.9arg.basic.html = TEXT
     1052
     1053// Misc. render failures
     1054BUGCR81718 WIN LINUX GPU : compositing/tiling/huge-layer-img.html = CRASH
     1055BUGCR80593 WIN LINUX GPU : canvas/philip/tests/2d.strokeRect.zero.4.html = TEXT
     1056BUGCR79741 WIN LINUX GPU : fast/canvas/canvasDrawingIntoSelf.html = IMAGE
     1057BUGCR79741 WIN LINUX GPU : fast/canvas/drawImage.html = IMAGE
     1058BUGCR81601 WIN LINUX GPU : fast/repaint/canvas-putImageData.html = IMAGE+TEXT
     1059BUGCR81600 WIN LINUX GPU : canvas/philip/tests/2d.line.miter.lineedge.html = TEXT
     1060BUGCR81606 WIN LINUX GPU : fast/canvas/drawImage-with-globalAlpha.html = IMAGE
     1061BUGCR81668 WIN LINUX GPU : compositing/geometry/object-clip-rects-assertion.html = TEXT
     1062BUGCR81670 WIN LINUX GPU : fast/canvas/webgl/css-webkit-canvas-repaint.html = IMAGE
     1063BUGCR81670 WIN LINUX GPU : fast/canvas/webgl/css-webkit-canvas.html = IMAGE
     1064
     1065// fillRect failures
     1066BUGCR78457 WIN LINUX GPU : fast/canvas/fillrect_gradient.html = IMAGE
     1067BUGCR78457 WIN LINUX GPU : fast/canvas/image-object-in-canvas.html = IMAGE
     1068BUGCR78457 WIN LINUX GPU : fast/canvas/image-pattern-rotate.html = IMAGE
     1069BUGCR78457 WIN LINUX GPU : fast/canvas/patternfill-repeat.html = IMAGE
     1070BUGCR78457 WIN LINUX GPU : media/video-canvas-alpha.html = IMAGE
     1071BUGCR78457 WIN LINUX GPU : fast/canvas/canvas-transforms-during-path.html = IMAGE
     1072BUGCR78457 WIN LINUX GPU : fast/canvas/fillrect-gradient-zero-stops.html = IMAGE
     1073BUGCR78457 WIN LINUX GPU : fast/canvas/canvas-longlived-context.html = TEXT
     1074
     1075//Text rendering failures
     1076BUGCR81605 WIN LINUX GPU : fast/canvas/canvas-text-alignment.html = IMAGE
     1077BUGCR81605 WIN LINUX GPU : fast/canvas/canvas-text-baseline.html = IMAGE
     1078
     1079// Skia/GPU Anti-aliasing
     1080BUGCR78458 WIN LINUX GPU : fast/canvas/arc360.html = IMAGE
     1081BUGCR78458 WIN LINUX GPU : fast/canvas/quadraticCurveTo.xml = IMAGE
     1082BUGCR78458 WIN LINUX GPU : fast/canvas/canvas-composite.html = IMAGE
    9981083
    9991084// -----------------------------------------------------------------
    … …  
    30563141
    30573142// Seems to blend scrollbars very slightly differently in debug vs. release.
    3058 // Commented out because BUGWK57113 supersedes it below.
     3143// Commented out because BUGWK57113 supersedes it below, and BUGCR78457
    30593144//BUGWK58587 DEBUG GPU LINUX : compositing/geometry/horizontal-scroll-composited.html = IMAGE
    3060 BUGWK58587 DEBUG GPU LINUX : fast/canvas/image-object-in-canvas.html = IMAGE
     3145//BUGWK58587 DEBUG GPU LINUX : fast/canvas/image-object-in-canvas.html = IMAGE
    30613146//BUGWK58587 DEBUG GPU LINUX : platform/chromium/compositing/layout-width-change.html = IMAGE
    30623147BUGWK58587 GPU LINUX : compositing/direct-image-compositing.html = IMAGE
    … …  
    32393324BUGWK60094 : fast/encoding/parser-tests-110.html = TIMEOUT PASS
    32403325BUGWK60094 : fast/encoding/parser-tests-120.html = TIMEOUT PASS
    3241 
    3242 BUGWK57547 WIN LINUX GPU : fast/canvas/canvas-strokePath-gradient-shadow.html = TIMEOUT
    3243 BUGWK57547 WIN LINUX GPU : fast/canvas/canvas-strokeRect-gradient-shadow.html = TIMEOUT
    3244 BUGWK57547 WIN LINUX GPU : fast/canvas/canvas-fillPath-gradient-shadow.html = TIMEOUT
    3245 BUGWK57547 WIN LINUX GPU : fast/canvas/canvas-fillPath-pattern-shadow.html = TIMEOUT
    32463326
    32473327// Flaky since creation because we lack layoutTestController.setSerializeHTTPLoads
    … …  
    36333713BUGWK60102 LINUX GPU : compositing/masks/masked-ancestor.html = IMAGE
    36343714BUGWK60102 LINUX GPU : compositing/masks/simple-composited-mask.html = IMAGE
    3635 BUGWK60102 LINUX DEBUG GPU : fast/canvas/canvas-text-alignment.html = IMAGE
     3715// Commented because of BUGCR81605
     3716//BUGWK60102 LINUX DEBUG GPU : fast/canvas/canvas-text-alignment.html = IMAGE
    36363717BUGWK60102 LINUX GPU : platform/chromium/compositing/layout-width-change.html = IMAGE
    36373718
    … …  
    39804061
    39814062// Failure since r85661.
    3982 BUG_HCLAM GPU : compositing/tiling/huge-layer-img.html = FAIL
     4063BUG_HCLAM MAC GPU : compositing/tiling/huge-layer-img.html = FAIL
    39834064
    39844065BUGWK60079 LINUX : platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE

  • trunk/Source/WebCore/ChangeLog

    r85894 r85895  
     12011-05-05  Justin Novosad  <junov@chromium.org>
     2
     3        Reviewed by Kenneth Russell.
     4
     5        [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
     6        https://bugs.webkit.org/show_bug.cgi?id=60173
     7
     8        * page/Page.cpp:
     9        (WebCore::Page::sharedGraphicsContext3D):
     10        Flipping the switch to make Skia the default for the accelerated 2d canvas
     11
    1122011-05-05  Tony Gentilcore  <tonyg@chromium.org>
    213

  • trunk/Source/WebCore/page/Page.cpp

    r85864 r85895  
    756756#if USE(SKIA)
    757757        // Temporary code to postpone massive test rebaselining
    758         m_sharedGraphicsContext3D = SharedGraphicsContext3D::create(chrome(), 0 /*settings()->legacyAccelerated2dCanvasEnabled() ? 0 : SharedGraphicsContext3D::UseSkiaGPU*/);
     758        m_sharedGraphicsContext3D = SharedGraphicsContext3D::create(chrome(), settings()->legacyAccelerated2dCanvasEnabled() ? 0 : SharedGraphicsContext3D::UseSkiaGPU);
    759759#else
    760760        m_sharedGraphicsContext3D = SharedGraphicsContext3D::create(chrome(), 0);
Note: See TracChangeset for help on using the changeset viewer.