Changeset 85922 in webkit

Timestamp:

May 6, 2011 12:06:56 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-05-06 Adam Barth <​abarth@webkit.org>

EWS can't reject patches
​https://bugs.webkit.org/show_bug.cgi?id=60345

We're supposed to use patch.id() for the attachment ID, silly.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/earlywarningsystem.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-06  Adam Barth  <abarth@webkit.org>
+
+        EWS can't reject patches
+        https://bugs.webkit.org/show_bug.cgi?id=60345
+
+        We're supposed to use patch.id() for the attachment ID, silly.
+
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+
 2011-05-05  Steve Lacey  <sjl@chromium.org>
 

trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

@@ -107 +107 @@
         if cls.watchers:
             tool.bugs.add_cc_to_bug(patch.bug_id(), cls.watchers)
-        tool.bugs.set_flag_on_attachment(patch.bug_id(), "commit-queue", "-", message, extra_message_text)
+        tool.bugs.set_flag_on_attachment(patch.id(), "commit-queue", "-", message, extra_message_text)
 
     @classmethod

trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

@@ -73 +73 @@
         tool = MockTool()
         patch = tool.bugs.fetch_attachment(197)
-        expected_stderr = """MOCK setting flag 'commit-queue' to '-' on attachment '42' with comment 'Attachment 197 did not pass mock-ews (win):
+        expected_stderr = """MOCK setting flag 'commit-queue' to '-' on attachment '197' with comment 'Attachment 197 did not pass mock-ews (win):
 Output: http://dummy_url' and additional comment 'EXTRA'
 """
@@ -119 +119 @@
             "process_work_item": "MOCK: update_status: %(name)s Pass\nMOCK: release_work_item: %(name)s 197\n" % string_replacemnts,
             "handle_script_error": """MOCK: update_status: %(name)s ScriptError error message
-MOCK setting flag 'commit-queue' to '-' on attachment '42' with comment 'Attachment 197 did not pass %(name)s (%(port)s):
+MOCK setting flag 'commit-queue' to '-' on attachment '197' with comment 'Attachment 197 did not pass %(name)s (%(port)s):
 Output: http://dummy_url' and additional comment 'None'
 """ % string_replacemnts,