Changeset 86088 in webkit


Ignore:
Timestamp:
May 9, 2011 2:42:41 PM (13 years ago)
Author:
arv@chromium.org
Message:

2011-05-09 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
https://bugs.webkit.org/show_bug.cgi?id=32013

  • fast/forms/radio-group-keyboard-change-event-expected.txt: Added.
  • fast/forms/radio-group-keyboard-change-event.html: Added.

2011-05-09 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
https://bugs.webkit.org/show_bug.cgi?id=32013

Test: fast/forms/radio-group-keyboard-change-event.html

  • html/RadioInputType.cpp: (WebCore::RadioInputType::handleKeydownEvent): Ensure that we do not check the radio input before we simulate the click

event. The simulated click event will check it for us but more importantly it will fire the "change" event as
expected.

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r86086 r86088  
     12011-05-09  Erik Arvidsson  <arv@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        radiogroup: onchange not detected when triggered by keyboard
     6        https://bugs.webkit.org/show_bug.cgi?id=32013
     7
     8        * fast/forms/radio-group-keyboard-change-event-expected.txt: Added.
     9        * fast/forms/radio-group-keyboard-change-event.html: Added.
     10
    1112011-05-09  Robert Hogan  <robert@webkit.org>
    212
  • trunk/Source/WebCore/ChangeLog

    r86087 r86088  
     12011-05-09  Erik Arvidsson  <arv@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        radiogroup: onchange not detected when triggered by keyboard
     6        https://bugs.webkit.org/show_bug.cgi?id=32013
     7
     8        Test: fast/forms/radio-group-keyboard-change-event.html
     9
     10        * html/RadioInputType.cpp:
     11        (WebCore::RadioInputType::handleKeydownEvent): Ensure that we do not check the radio input before we simulate the click
     12            event. The simulated click event will check it for us but more importantly it will fire the "change" event as
     13            expected.
     14
    1152011-05-09  Adam Barth  <abarth@webkit.org>
    216
  • trunk/Source/WebCore/html/RadioInputType.cpp

    r74895 r86088  
    9595            break;
    9696        if (inputElement->isRadioButton() && inputElement->name() == element()->name() && inputElement->isFocusable()) {
    97             inputElement->setChecked(true);
    9897            document->setFocusedNode(inputElement);
    9998            inputElement->dispatchSimulatedClick(event, false, false);
Note: See TracChangeset for help on using the changeset viewer.