Changeset 86175 in webkit

Timestamp:

May 10, 2011 11:57:22 AM (13 years ago)

Author:

andersca@apple.com

Message:

2011-05-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Remove incorrect ASSERTs from CoreIPC::Connection::processIncomingSyncReply
​https://bugs.webkit.org/show_bug.cgi?id=60567
<rdar://problem/9377845>

It is possible to receive an incoming sync reply that is for a request we don't know about.
This could happen if the sync message send timed out for example.

• Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingSyncReply):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/Connection.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-05-10  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Remove incorrect ASSERTs from CoreIPC::Connection::processIncomingSyncReply
+        https://bugs.webkit.org/show_bug.cgi?id=60567
+        <rdar://problem/9377845>
+
+        It is possible to receive an incoming sync reply that is for a request we don't know about.
+        This could happen if the sync message send timed out for example.
+
+        * Platform/CoreIPC/Connection.cpp:
+        (CoreIPC::Connection::processIncomingSyncReply):
+
 2011-05-05  Brent Fulgham  <bfulgham@webkit.org> and Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp

@@ -478 +478 @@
 {
     MutexLocker locker(m_syncReplyStateMutex);
-    ASSERT(!m_pendingSyncReplies.isEmpty());
 
     // Go through the stack of sync requests that have pending replies and see which one
@@ -500 +499 @@
     }
 
-    // We got a reply for a message we never sent.
-    // FIXME: Dispatch a didReceiveInvalidMessage callback on the client.
-    ASSERT_NOT_REACHED();
+    // If we get here, it means we got a reply for a message that wasn't in the sync request stack.
+    // This can happen if the send timed out, so it's fine to ignore.
 }