Changeset 86224 in webkit
- Timestamp:
- May 11, 2011 2:11:36 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 11 added
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r86221 r86224 1 2011-05-11 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Hajime Morita. 4 5 The position of validation message bubble is wrong for non text fields. 6 https://bugs.webkit.org/show_bug.cgi?id=60341 7 8 * fast/forms/resources/common.js: Added. Helper functions for fast/forms. 9 * fast/forms/validation-message-on-checkbox-expected.txt: Added. 10 * fast/forms/validation-message-on-checkbox.html: Added. 11 * fast/forms/validation-message-on-listbox-expected.txt: Added. 12 * fast/forms/validation-message-on-listbox.html: Added. 13 * fast/forms/validation-message-on-menulist-expected.txt: Added. 14 * fast/forms/validation-message-on-menulist.html: Added. 15 * fast/forms/validation-message-on-radio-expected.txt: Added. 16 * fast/forms/validation-message-on-radio.html: Added. 17 * fast/forms/validation-message-on-textarea-expected.txt: Added. 18 * fast/forms/validation-message-on-textarea.html: Added. 19 * platform/chromium/test_expectations.txt: 20 * platform/gtk/Skipped: 21 * platform/mac/fast/forms/validation-message-appearance-expected.png: Updated. 22 * platform/mac/fast/forms/validation-message-appearance-expected.txt: Updated. 23 * platform/qt/Skipped: 24 * platform/win/Skipped: 25 1 26 2011-05-10 Yury Semikhatsky <yurys@chromium.org> 2 27 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r86204 r86224 3975 3975 BUGWK59768 WIN LINUX GPU : canvas/philip/tests/2d.shadow.alpha.5.html = TEXT 3976 3976 3977 // just needs new baselines? 3977 // Need rebaseline. 3978 BUGWK60341 : fast/forms/validation-message-appearance.html = FAIL 3978 3979 3979 3980 // flakiness on the deps bots (noted r~83476) -
trunk/LayoutTests/platform/gtk/Skipped
r86204 r86224 1140 1140 editing/pasteboard/files-during-page-drags.html 1141 1141 1142 # The feature was disabled due to a compatibility issue. 1143 # https://bugs.webkit.org/show_bug.cgi?id=40520 1142 # Need to call Settings::setInteractiveFormValidationEnabled(true). 1144 1143 fast/forms/interactive-validation-prevented.html 1145 1144 fast/forms/interactive-validation-attach-assertion.html … … 1147 1146 fast/forms/interactive-validation-select-crash.html 1148 1147 fast/forms/interactive-validation-crash-by-style-override.html 1148 # Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT. 1149 1149 fast/forms/validation-message-appearance.html 1150 fast/forms/validation-message-on-checkbox.html 1151 fast/forms/validation-message-on-listbox.html 1152 fast/forms/validation-message-on-menulist.html 1153 fast/forms/validation-message-on-radio.html 1154 fast/forms/validation-message-on-textarea.html 1150 1155 1151 1156 # Tests that seem to be Mac only, assume that smart drag-and-drop -
trunk/LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.txt
r82386 r86224 15 15 layer at (13,13) size 119x13 16 16 RenderBlock {DIV} at (3,3) size 119x13 17 layer at (1 3,26) size 220x10018 RenderBlock (positioned) zI: 2147483647 {DIV} at (1 3,26) size 220x10019 layer at (1 3,26) size 220x16 scrollHeight 2617 layer at (10,29) size 220x100 18 RenderBlock (positioned) zI: 2147483647 {DIV} at (10,29) size 220x100 19 layer at (10,29) size 220x16 scrollHeight 26 20 20 RenderBlock {DIV} at (0,0) size 220x16 21 layer at (1 3,38) size 220x8421 layer at (10,41) size 220x84 22 22 RenderBlock (relative positioned) zI: 2147483644 {DIV} at (0,16) size 220x84 [border: (2px solid #440000)] 23 23 RenderInline {B} at (0,0) size 93x16 … … 31 31 text run at (10,42) width 177: "Should not be identical with" 32 32 text run at (10,58) width 139: "the current password." 33 layer at (4 5,26) size 18x18 backgroundClip at (13,26) size 220x16 clip at (13,26) size 220x16 outlineClip at (13,26) size 220x1633 layer at (42,29) size 18x18 backgroundClip at (10,29) size 220x16 clip at (10,29) size 220x16 outlineClip at (10,29) size 220x16 34 34 RenderBlock (relative positioned) zI: 2147483645 {DIV} at (0,0) size 18x18 [bgcolor=#F8ECEC] [border: (2px solid #440000) none (2px solid #440000)] 35 35 caret: position 0 of child 0 {DIV} of child 1 {INPUT} of child 0 {FORM} of body -
trunk/LayoutTests/platform/qt/Skipped
r86204 r86224 2171 2171 http/tests/xmlhttprequest/remember-bad-password.html 2172 2172 2173 # The feature was disabled due to a compatibility issue. 2174 # https://bugs.webkit.org/show_bug.cgi?id=40520 2173 # Need to call Settings::setInteractiveFormValidationEnabled(true). 2175 2174 fast/forms/interactive-validation-prevented.html 2176 2175 fast/forms/interactive-validation-attach-assertion.html … … 2178 2177 fast/forms/interactive-validation-select-crash.html 2179 2178 fast/forms/interactive-validation-crash-by-style-override.html 2179 # Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT. 2180 2180 fast/forms/validation-message-appearance.html 2181 fast/forms/validation-message-on-checkbox.html 2182 fast/forms/validation-message-on-listbox.html 2183 fast/forms/validation-message-on-menulist.html 2184 fast/forms/validation-message-on-radio.html 2185 fast/forms/validation-message-on-textarea.html 2181 2186 2182 2187 # [Qt] REGRESSION(63862): animations/play-state.html fails intermittently -
trunk/LayoutTests/platform/win/Skipped
r86047 r86224 1081 1081 printing/setPrinting.html 1082 1082 1083 # The feature was disabled due to a compatibility issue. 1084 # https://bugs.webkit.org/show_bug.cgi?id=40520 1083 # Need to call Settings::setInteractiveFormValidationEnabled(true). 1085 1084 fast/forms/interactive-validation-prevented.html 1086 1085 fast/forms/interactive-validation-attach-assertion.html … … 1088 1087 fast/forms/interactive-validation-select-crash.html 1089 1088 fast/forms/interactive-validation-crash-by-style-override.html 1089 # Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT. 1090 1090 fast/forms/validation-message-appearance.html 1091 fast/forms/validation-message-on-checkbox.html 1092 fast/forms/validation-message-on-listbox.html 1093 fast/forms/validation-message-on-menulist.html 1094 fast/forms/validation-message-on-radio.html 1095 fast/forms/validation-message-on-textarea.html 1091 1096 1092 1097 # Web Timing is not enabled. -
trunk/Source/WebCore/ChangeLog
r86222 r86224 1 2011-05-11 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Hajime Morita. 4 5 The position of validation message bubble is wrong for non text fields. 6 https://bugs.webkit.org/show_bug.cgi?id=60341 7 8 Tests: fast/forms/validation-message-on-checkbox.html 9 fast/forms/validation-message-on-listbox.html 10 fast/forms/validation-message-on-menulist.html 11 fast/forms/validation-message-on-radio.html 12 fast/forms/validation-message-on-textarea.html 13 14 * css/html.css: 15 (::-webkit-validation-bubble-message): 16 Add white-space:normal in order not to inherit white-space:pre for <select>. 17 * html/ValidationMessage.cpp: 18 (WebCore::adjustBubblePosition): 19 Adjust the bubble position. 20 - The top of the bubble should be same as the bottom of the target control. 21 - The left of the bubble should be same as the left of the target control. 22 But If the left+32 is larger than the center of the target control, 23 left+32 should be at the center of the target control. 24 But the left position should not be less than 0. 25 (WebCore::ValidationMessage::buildBubbleTree): Call adjustBubblePosition(). 26 1 27 2011-05-11 Emil A Eklund <eae@chromium.org> 2 28 -
trunk/Source/WebCore/css/html.css
r84991 r86224 649 649 inset 2px 2px 1px white; 650 650 line-height: normal; 651 white-space: normal; 651 652 z-index: 2147483644; 652 653 } -
trunk/Source/WebCore/html/ValidationMessage.cpp
r84850 r86224 122 122 }; 123 123 124 static void adjustBubblePosition(const IntRect& hostRect, HTMLElement* bubble) 125 { 126 ASSERT(bubble); 127 if (hostRect.isEmpty()) 128 return; 129 bubble->getInlineStyleDecl()->setProperty(CSSPropertyTop, static_cast<double>(hostRect.y() + hostRect.height()), CSSPrimitiveValue::CSS_PX); 130 // The 'left' value of ::-webkit-validation-bubble-arrow. 131 const int bubbleArrowTopOffset = 32; 132 double bubbleX = hostRect.x(); 133 if (hostRect.width() / 2 < bubbleArrowTopOffset) 134 bubbleX = max(hostRect.x() + hostRect.width() / 2 - bubbleArrowTopOffset, 0); 135 bubble->getInlineStyleDecl()->setProperty(CSSPropertyLeft, bubbleX, CSSPrimitiveValue::CSS_PX); 136 } 137 124 138 void ValidationMessage::buildBubbleTree(Timer<ValidationMessage>*) 125 139 { … … 130 144 // contains non-absolute or non-fixed renderers as children. 131 145 m_bubble->getInlineStyleDecl()->setProperty(CSSPropertyPosition, CSSValueAbsolute); 146 adjustBubblePosition(host->getRect(), m_bubble.get()); 132 147 ExceptionCode ec = 0; 133 148 host->ensureShadowRoot()->appendChild(m_bubble.get(), ec); … … 142 157 143 158 // FIXME: Use transition to show the bubble. 144 145 // We don't need to adjust the bubble location. The default position is enough.146 159 } 147 160
Note: See TracChangeset
for help on using the changeset viewer.