Changeset 86232 in webkit

Timestamp:

May 11, 2011 8:08:40 AM (13 years ago)

Author:

Philippe Normand

Message:

2011-05-04 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[Gtk+] deadlock in gstreamer video player when exiting fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=58548

Block data flow towards the pipeline branch to remove to avoid
potential deadlocks during the PAUSED->READY transitions of the
elements to remove.

• platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::exitFullscreen):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/GStreamerGWorld.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-04  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [Gtk+] deadlock in gstreamer video player when exiting fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=58548
+
+        Block data flow towards the pipeline branch to remove to avoid
+        potential deadlocks during the PAUSED->READY transitions of the
+        elements to remove.
+
+        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
+        (WebCore::GStreamerGWorld::exitFullscreen):
+
 2011-05-11  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp

@@ -179 +179 @@
     GstPad* sinkPad = gst_element_get_static_pad(queue, "sink");
 
+    // Block data flow towards the pipeline branch to remove.
+    gst_pad_set_blocked(srcPad, true);
+
     // Unlink and release request pad.
     gst_pad_unlink(srcPad, sinkPad);