Changeset 86242 in webkit

Timestamp:

May 11, 2011 9:56:20 AM (13 years ago)

Author:

Adam Roben

Message:

Use case-insensitive comparisons when checking plugin filenames on Windows

Windows paths are nearly always case-insensitive.

I couldn't think of a good way to test this.

Fixes <​http://webkit.org/b/60633> WebKit1 loads Windows Presentation Foundation plugin, but
should not

Reviewed by Steve Falkenburg.

• plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::isPluginBlacklisted): Use equalIgnoringCase instead of == when
checking plugin filenames.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/win/PluginPackageWin.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-11  Adam Roben  <aroben@apple.com>
+
+        Use case-insensitive comparisons when checking plugin filenames on Windows
+
+        Windows paths are nearly always case-insensitive.
+
+        I couldn't think of a good way to test this.
+
+        Fixes <http://webkit.org/b/60633> WebKit1 loads Windows Presentation Foundation plugin, but
+        should not
+
+        Reviewed by Steve Falkenburg.
+
+        * plugins/win/PluginPackageWin.cpp:
+        (WebCore::PluginPackage::isPluginBlacklisted): Use equalIgnoringCase instead of == when
+        checking plugin filenames.
+
 2011-05-11  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebCore/plugins/win/PluginPackageWin.cpp

@@ -72 +72 @@
         if (compareFileVersion(slPluginMinRequired) < 0)
             return true;
-    } else if (fileName() == "npmozax.dll") {
+    } else if (equalIgnoringCase(fileName(), "npmozax.dll")) {
         // Bug 15217: Mozilla ActiveX control complains about missing xpcom_core.dll
         return true;
-    } else if (fileName() == "npwpf.dll") {
+    } else if (equalIgnoringCase(fileName(), "npwpf.dll")) {
         // Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll
         return true;