Changeset 86352 in webkit


Ignore:
Timestamp:
May 12, 2011 9:57:18 AM (13 years ago)
Author:
rwlbuis@webkit.org
Message:

2011-05-12 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Darin Adler.

REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
​https://bugs.webkit.org/show_bug.cgi?id=59941

Improve test to not need a click. Offer a stroke-opacity variant as well.

  • platform/mac/svg/custom/fill-opacity-update-expected.png:
  • platform/mac/svg/custom/fill-opacity-update-expected.txt:
  • platform/mac/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/mac/svg/custom/stroke-opacity-update-expected.txt: Added.
  • svg/custom/fill-opacity-update.svg:
  • svg/custom/stroke-opacity-update.svg: Added.
Location:
trunk/LayoutTests
Files:
3 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r86351 r86352  
     12011-05-12  Rob Buis  <rwlbuis@gmail.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
     6        https://bugs.webkit.org/show_bug.cgi?id=59941
     7
     8        Improve test to not need a click. Offer a stroke-opacity variant as well.
     9
     10        * platform/mac/svg/custom/fill-opacity-update-expected.png:
     11        * platform/mac/svg/custom/fill-opacity-update-expected.txt:
     12        * platform/mac/svg/custom/stroke-opacity-update-expected.png: Added.
     13        * platform/mac/svg/custom/stroke-opacity-update-expected.txt: Added.
     14        * svg/custom/fill-opacity-update.svg:
     15        * svg/custom/stroke-opacity-update.svg: Added.
     16
    1172011-05-12  Simon Fraser  <simon.fraser@apple.com>
    218

  • trunk/LayoutTests/platform/mac/svg/custom/fill-opacity-update-expected.txt

    r86331 r86352  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 226x188
    4   RenderSVGRoot {svg} at (75,47) size 76x76
    5     RenderSVGPath {circle} at (75,47) size 76x76 [fill={[type=SOLID] [color=#008000]}] [cx=300.00] [cy=225.00] [r=100.00]
     3layer at (0,0) size 800x600
     4  RenderSVGRoot {svg} at (0,0) size 200x200
     5    RenderSVGPath {circle} at (0,0) size 200x200 [fill={[type=SOLID] [color=#008000]}] [cx=100.00] [cy=100.00] [r=100.00]

  • trunk/LayoutTests/svg/custom/fill-opacity-update.svg

    r86331 r86352  
    1 <?xml version="1.0" standalone="no"?>
    2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
    3   "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
    4 <svg width="6cm" height="5cm" viewBox="0 0 600 500"
    5      xmlns="http://www.w3.org/2000/svg" version="1.1" onload="setTimeout('runTest()', 0)">
     1<svg xmlns="http://www.w3.org/2000/svg" version="1.1" onload="setTimeout('runTest()', 0)">
     2<circle cx="100" cy="100" r="100" fill="green" fill-opacity="0"/>
    63<script>
    74    if (window.layoutTestController)
    85        window.layoutTestController.waitUntilDone();
    9 function circle_click(evt) {
    10     evt.target.setAttribute("fill-opacity", "1");
    11     if (window.layoutTestController)
    12         layoutTestController.notifyDone();
    13 }
    14 function runTest() {
    15     if (window.eventSender) {
    16         eventSender.mouseMoveTo(100, 100);
    17         eventSender.mouseDown();
    18         eventSender.mouseUp();
     6    function runTest() {
     7        document.getElementsByTagName("circle")[0].setAttribute("fill-opacity", "1");
     8        if (window.layoutTestController)
     9            window.layoutTestController.notifyDone();
    1910    }
    20 }
    2111</script>
    22 <circle onclick="circle_click(evt)" cx="300" cy="225" r="100" fill="green" fill-opacity="0"/>
    2312</svg>
Note: See TracChangeset for help on using the changeset viewer.