Changeset 86413 in webkit


Ignore:
Timestamp:
May 12, 2011 10:25:47 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-12 Ben Wells <​benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
​https://bugs.webkit.org/show_bug.cgi?id=58999

Converted the new tests to be text tests with pixel results
(using dumpAsText(true)).
Updated test_expectations comments to be more helpful and accurate and split
new expectations into two groups for skia / chromium-mac as chromium-mac can be
rebaselined now.

  • fast/borders/outline-alpha-block-expected.txt: Added.
  • fast/borders/outline-alpha-block.html:
  • fast/borders/outline-alpha-inline-expected.txt: Added.
  • fast/borders/outline-alpha-inline.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/outline-alpha-block-expected.txt: Removed.
  • platform/mac/fast/borders/outline-alpha-inline-expected.txt: Removed.

2011-05-12 Ben Wells <​benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
​https://bugs.webkit.org/show_bug.cgi?id=58999

Added FIXMEs near temporary $if !USE(SKIA)s, referencing bug 60342.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
Location:
trunk
Files:
2 added
2 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r86408 r86413  
     12011-05-12  Ben Wells  <benwells@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        RGBA colors in outlines show overpainting at the corners
     6        https://bugs.webkit.org/show_bug.cgi?id=58999
     7
     8        Converted the new tests to be text tests with pixel results
     9        (using dumpAsText(true)).
     10        Updated test_expectations comments to be more helpful and accurate and split
     11        new expectations into two groups for skia / chromium-mac as chromium-mac can be
     12        rebaselined now.
     13
     14        * fast/borders/outline-alpha-block-expected.txt: Added.
     15        * fast/borders/outline-alpha-block.html:
     16        * fast/borders/outline-alpha-inline-expected.txt: Added.
     17        * fast/borders/outline-alpha-inline.html:
     18        * platform/chromium/test_expectations.txt:
     19        * platform/mac/fast/borders/outline-alpha-block-expected.txt: Removed.
     20        * platform/mac/fast/borders/outline-alpha-inline-expected.txt: Removed.
     21
    1222011-05-12  David Grogan  <dgrogan@chromium.org>
    223

  • trunk/LayoutTests/fast/borders/outline-alpha-block.html

    r86314 r86413  
    128128outset
    129129
     130<script>
     131    if (window.layoutTestController)
     132      layoutTestController.dumpAsText(true);
     133</script>

  • trunk/LayoutTests/fast/borders/outline-alpha-inline.html

    r86314 r86413  
    9090</div>
    9191outset
     92
     93<script>
     94    if (window.layoutTestController)
     95      layoutTestController.dumpAsText(true);
     96</script>

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r86402 r86413  
    40324032BUGCR82419 : svg/custom/fill-opacity-update.svg = IMAGE
    40334033
    4034 // New pixel tests added for bug 58999, rebaseline when webkit 58999 rolls.
    4035 BUGWK58999 WIN LINUX MAC : fast/borders/outline-alpha-block.html = IMAGE+TEXT IMAGE
    4036 BUGWK58999 WIN LINUX MAC : fast/borders/outline-alpha-inline.html = IMAGE+TEXT IMAGE
     4034// New pixel tests added for bug 58999. These will fail on windows and linux until bug
     4035// 60342 is fixed and the 58999 fix enabled for skia.
     4036BUGWK58999 WIN LINUX : fast/borders/outline-alpha-block.html = IMAGE
     4037BUGWK58999 WIN LINUX : fast/borders/outline-alpha-inline.html = IMAGE
     4038
     4039// New pixel tests added for bug 58999. These should be rebaselined for chromium-mac
     4040// as the bug fix is available on that platform but there are image differences due to fonts
     4041BUGWK58999 MAC : fast/borders/outline-alpha-block.html = IMAGE
     4042BUGWK58999 MAC : fast/borders/outline-alpha-inline.html = IMAGE
    40374043
    40384044BUGWK60738 LINUX WIN : compositing/color-matching/image-color-matching.html = IMAGE+TEXT IMAGE

  • trunk/Source/WebCore/ChangeLog

    r86407 r86413  
     12011-05-12  Ben Wells  <benwells@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        RGBA colors in outlines show overpainting at the corners
     6        https://bugs.webkit.org/show_bug.cgi?id=58999
     7
     8        Added FIXMEs near temporary $if !USE(SKIA)s, referencing bug 60342.
     9
     10        * rendering/RenderInline.cpp:
     11        (WebCore::RenderInline::paintOutline):
     12        * rendering/RenderObject.cpp:
     13        (WebCore::RenderObject::paintOutline):
     14
    1152011-05-12  Adele Peterson  <adele@apple.com>
    216

  • trunk/Source/WebCore/rendering/RenderInline.cpp

    r86314 r86413  
    13991399
    14001400    Color outlineColor = styleToUse->visitedDependentColor(CSSPropertyOutlineColor);
     1401// FIXME: Using a transparency layer for rgba outlines exacerbates an existing SKIA bug. The #if
     1402// below prevents this; it should be removed when https://bugs.webkit.org/show_bug.cgi?id=60342 is fixed.
    14011403#if !USE(SKIA)
    14021404    bool useTransparencyLayer = outlineColor.hasAlpha();
    … …  
    14101412        paintOutlineForLine(graphicsContext, tx, ty, rects.at(i - 1), rects.at(i), rects.at(i + 1), outlineColor);
    14111413
     1414// FIXME: Using a transparency layer for rgba outlines exacerbates an existing SKIA bug. The #if
     1415// below prevents this; it should be removed when https://bugs.webkit.org/show_bug.cgi?id=60342 is fixed.
    14121416#if !USE(SKIA)
    14131417    if (useTransparencyLayer)

  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r86400 r86413  
    10501050        return;
    10511051
     1052// FIXME: Using a transparency layer for rgba outlines exacerbates an existing SKIA bug. The #if
     1053// below prevents this; it should be removed when https://bugs.webkit.org/show_bug.cgi?id=60342 is fixed.
    10521054#if !USE(SKIA)
    10531055    bool useTransparencyLayer = outlineColor.hasAlpha();
    … …  
    10721074    drawLineForBoxSide(graphicsContext, leftOuter, bottomInner, rightOuter, bottomOuter, BSBottom, outlineColor, outlineStyle, outlineWidth, outlineWidth);
    10731075
     1076// FIXME: Using a transparency layer for rgba outlines exacerbates an existing SKIA bug. The #if
     1077// below prevents this; it should be removed when https://bugs.webkit.org/show_bug.cgi?id=60342 is fixed.
    10741078#if !USE(SKIA)
    10751079    if (useTransparencyLayer)
Note: See TracChangeset for help on using the changeset viewer.