Changeset 86495 in webkit

Timestamp:

May 14, 2011 1:41:58 PM (13 years ago)

Author:

mitz@apple.com

Message:

WKView does not draw after forced repaint before the first update
​https://bugs.webkit.org/show_bug.cgi?id=60845

Reviewed by Alice Liu.

• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint): Added.

• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::waitForBackingStoreUpdateOnNextPaint): Set m_hasReceivedFirstUpdate
to true, ensuring that paint() will wait for an update if needed.

• UIProcess/DrawingAreaProxyImpl.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint): Call DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint().

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/DrawingAreaProxy.h (modified) (1 diff)
• UIProcess/DrawingAreaProxyImpl.cpp (modified) (1 diff)
• UIProcess/DrawingAreaProxyImpl.h (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-05-14  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Alice Liu.
+
+        WKView does not draw after forced repaint before the first update
+        https://bugs.webkit.org/show_bug.cgi?id=60845
+
+        * UIProcess/DrawingAreaProxy.h:
+        (WebKit::DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint): Added.
+        * UIProcess/DrawingAreaProxyImpl.cpp:
+        (WebKit::DrawingAreaProxyImpl::waitForBackingStoreUpdateOnNextPaint): Set m_hasReceivedFirstUpdate
+        to true, ensuring that paint() will wait for an update if needed.
+        * UIProcess/DrawingAreaProxyImpl.h:
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::forceRepaint): Call DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint().
+
 2011-05-14  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h

@@ -87 +87 @@
     virtual void visibilityDidChange() { }
     virtual void setBackingStoreIsDiscardable(bool) { }
-    
+
+    virtual void waitForBackingStoreUpdateOnNextPaint() { }
+
     virtual void setPageIsVisible(bool isVisible) = 0;
 

trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp

@@ -163 +163 @@
 }
 
+void DrawingAreaProxyImpl::waitForBackingStoreUpdateOnNextPaint()
+{
+    m_hasReceivedFirstUpdate = true;
+}
+
 void DrawingAreaProxyImpl::update(uint64_t backingStoreStateID, const UpdateInfo& updateInfo)
 {

trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h

@@ -56 +56 @@
     virtual void setPageIsVisible(bool);
     virtual void setBackingStoreIsDiscardable(bool);
+    virtual void waitForBackingStoreUpdateOnNextPaint();
 
     // CoreIPC message handlers

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -1306 +1306 @@
     uint64_t callbackID = callback->callbackID();
     m_voidCallbacks.set(callbackID, callback.get());
+    m_drawingArea->waitForBackingStoreUpdateOnNextPaint();
     process()->send(Messages::WebPage::ForceRepaint(callbackID), m_pageID); 
 }