Changeset 86561 in webkit

Timestamp:

May 16, 2011 5:42:32 AM (13 years ago)

Author:

andreas.kling@nokia.com

Message:

2011-05-16 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

CSS: Fast path for 'px' lengths should be case-insensitive.
​https://bugs.webkit.org/show_bug.cgi?id=60703

No new tests, this is an optimization that avoids creating
a full CSSParser to parse the value.

• css/CSSParser.cpp: (WebCore::parseSimpleLengthValue):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-16  Andreas Kling  <kling@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        CSS: Fast path for 'px' lengths should be case-insensitive.
+        https://bugs.webkit.org/show_bug.cgi?id=60703
+
+        No new tests, this is an optimization that avoids creating
+        a full CSSParser to parse the value.
+
+        * css/CSSParser.cpp:
+        (WebCore::parseSimpleLengthValue):
+
 2011-05-16  Naiem Shaik  <naiem.shaik@gmail.com>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -376 +376 @@
 
     CSSPrimitiveValue::UnitTypes unit = CSSPrimitiveValue::CSS_NUMBER;
-    if (length > 2 && characters[length - 2] == 'p' && characters[length - 1] == 'x') {
+    if (length > 2 && (characters[length - 2] | 0x20) == 'p' && (characters[length - 1] | 0x20) == 'x') {
         length -= 2;
         unit = CSSPrimitiveValue::CSS_PX;