Changeset 86582 in webkit

Timestamp:

May 16, 2011 10:09:58 AM (13 years ago)

Author:

andreas.kling@nokia.com

Message:

2011-05-16 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
​https://bugs.webkit.org/show_bug.cgi?id=60892

Don't set the ItemClipsChildrenToShape flag for the root platform layer,
since that is now the overflow controls layer. The clip layer, which was
previously the root platform layer, already gets the flag by way of
the GraphicsLayer mask-to-bounds flag.

• WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Location:

trunk/Source/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/PageClientQt.cpp (modified) (1 diff)

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2011-05-16  Andreas Kling  <kling@webkit.org>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
+        https://bugs.webkit.org/show_bug.cgi?id=60892
+
+        Don't set the ItemClipsChildrenToShape flag for the root platform layer,
+        since that is now the overflow controls layer. The clip layer, which was
+        previously the root platform layer, already gets the flag by way of
+        the GraphicsLayer mask-to-bounds flag.
+
+        * WebCoreSupport/PageClientQt.cpp:
+        (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
+
 2011-05-16  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp

@@ -290 +290 @@
 
     if (rootGraphicsLayer) {
-        rootGraphicsLayer.data()->setFlag(QGraphicsItem::ItemClipsChildrenToShape, true);
         rootGraphicsLayer.data()->setParentItem(view);
         rootGraphicsLayer.data()->setZValue(RootGraphicsLayerZValue);