Changeset 86683 in webkit

Timestamp:

May 17, 2011 10:27:19 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

2011-05-17 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: navigating from elements panel does not show source view.
​https://bugs.webkit.org/show_bug.cgi?id=60970

• inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextViewer.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-17  Pavel Feldman  <pfeldman@google.com>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: navigating from elements panel does not show source view.
+        https://bugs.webkit.org/show_bug.cgi?id=60970
+
+        * inspector/front-end/TextViewer.js:
+        (WebInspector.TextViewer.prototype.highlightLine):
+        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
+
 2011-05-17  Sam Magnuson  <smagnuson@netflix.com>
 

trunk/Source/WebCore/inspector/front-end/TextViewer.js

@@ -109 +109 @@
     highlightLine: function(lineNumber)
     {
+        if (typeof lineNumber !== "number" || lineNumber < 0)
+            return;
+
         lineNumber = Math.min(lineNumber, this._textModel.linesCount - 1);
         this._mainPanel.highlightLine(lineNumber);
@@ -426 +429 @@
         var chunkNumber = this._chunkNumberForLine(lineNumber);
         var oldChunk = this._textChunks[chunkNumber];
+
+        if (!oldChunk) {
+            console.error("No chunk for line number: " + lineNumber);
+            return;
+        }
+
         if (oldChunk.linesCount === 1)
             return oldChunk;