Changeset 86816 in webkit

Timestamp:

May 18, 2011 8:21:04 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-18 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
​https://bugs.webkit.org/show_bug.cgi?id=61010

• platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint):

2011-05-18 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
​https://bugs.webkit.org/show_bug.cgi?id=61010

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::paint): (WebKit::WebViewImplContentPainter::paint):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/chromium/ContentLayerChromium.cpp (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/WebViewImpl.cpp (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-18  Nat Duca  <nduca@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Add histograms for paint times
+        https://bugs.webkit.org/show_bug.cgi?id=61010
+
+        * platform/graphics/chromium/ContentLayerChromium.cpp:
+        (WebCore::ContentLayerPainter::paint):
+
 2011-05-18  Adrienne Walker  <enne@google.com>
 

trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp

@@ -42 +42 @@
 #include "LayerTextureUpdaterCanvas.h"
 #include "LayerTilerChromium.h"
+#include "PlatformBridge.h"
 #include "RenderLayerBacking.h"
 #include "TextStream.h"
+#include <wtf/CurrentTime.h>
 
 // Maximum size the width or height of this layer can be before enabling tiling
@@ -64 +66 @@
     virtual void paint(GraphicsContext& context, const IntRect& contentRect)
     {
+        double paintStart = currentTime();
         context.clearRect(contentRect);
         context.clip(contentRect);
         m_owner->paintGraphicsLayerContents(context, contentRect);
+        double paintEnd = currentTime();
+        double pixelsPerSec = (contentRect.width() * contentRect.height()) / (paintEnd - paintStart);
+        PlatformBridge::histogramCustomCounts("Renderer4.AccelContentPaintDurationMS", (paintEnd - paintStart) * 1000, 0, 120, 30);
+        PlatformBridge::histogramCustomCounts("Renderer4.AccelContentPaintMegapixPerSecond", pixelsPerSec / 1000000, 10, 210, 30);
     }
 private:

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-05-18  Nat Duca  <nduca@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Add histograms for paint times
+        https://bugs.webkit.org/show_bug.cgi?id=61010
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::animate):
+        (WebKit::WebViewImpl::layout):
+        (WebKit::WebViewImpl::paint):
+        (WebKit::WebViewImplContentPainter::paint):
+
 2011-05-17  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -1005 +1005 @@
 void WebViewImpl::animate()
 {
+    TRACE_EVENT("WebViewImpl::animate", this, 0);
 #if ENABLE(REQUEST_ANIMATION_FRAME)
     WebFrameImpl* webframe = mainFrameImpl();
@@ -1022 +1023 @@
 void WebViewImpl::layout()
 {
+    TRACE_EVENT("WebViewImpl::layout", this, 0);
 #if USE(ACCELERATED_COMPOSITING)
     // FIXME: RTL style not supported by the compositor yet.
@@ -1097 +1099 @@
 #endif
     } else {
+        double paintStart = currentTime();
         WebFrameImpl* webframe = mainFrameImpl();
         if (webframe)
             webframe->paint(canvas, rect);
+        double paintEnd = currentTime();
+        double pixelsPerSec = (rect.width * rect.height) / (paintEnd - paintStart);
+        PlatformBridge::histogramCustomCounts("Renderer4.SoftwarePaintDurationMS", (paintEnd - paintStart) * 1000, 0, 120, 30);
+        PlatformBridge::histogramCustomCounts("Renderer4.SoftwarePaintMegapixPerSecond", pixelsPerSec / 1000000, 10, 210, 30);
     }
 }
@@ -2421 +2428 @@
     virtual void paint(GraphicsContext& context, const IntRect& contentRect)
     {
+        double paintStart = currentTime();
         Page* page = m_webViewImpl->page();
         if (!page)
@@ -2426 +2434 @@
         FrameView* view = page->mainFrame()->view();
         view->paintContents(&context, contentRect);
+        double paintEnd = currentTime();
+        double pixelsPerSec = (contentRect.width() * contentRect.height()) / (paintEnd - paintStart);
+        PlatformBridge::histogramCustomCounts("Renderer4.AccelRootPaintDurationMS", (paintEnd - paintStart) * 1000, 0, 120, 30);
+        PlatformBridge::histogramCustomCounts("Renderer4.AccelRootPaintMegapixPerSecond", pixelsPerSec / 1000000, 10, 210, 30);
     }