Changeset 86830 in webkit


Ignore:
Timestamp:
May 19, 2011 2:45:53 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-19 David Barr <​davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
​https://bugs.webkit.org/show_bug.cgi?id=38788

  • fast/css/border-radius-non-negative-expected.txt: Added.
  • fast/css/border-radius-non-negative.html: Added.
  • platform/mac/fast/css/border-radius-non-negative-expected.png: Added.

2011-05-19 David Barr <​davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
​https://bugs.webkit.org/show_bug.cgi?id=38788

Ignore border-radius properties with negative values.

Test: fast/css/border-radius-non-negative.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBorderRadius):
Location:
trunk
Files:
3 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r86828 r86830  
     12011-05-19  David Barr  <davidbarr@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        CSS3: We fail 'border radius sum of radii' test
     6        https://bugs.webkit.org/show_bug.cgi?id=38788
     7
     8        * fast/css/border-radius-non-negative-expected.txt: Added.
     9        * fast/css/border-radius-non-negative.html: Added.
     10        * platform/mac/fast/css/border-radius-non-negative-expected.png: Added.
     11
    1122011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
    213

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r86811 r86830  
    41164116// Random crashes started between: http://trac.webkit.org/log/?verbose=on&rev=86756&stop_rev=86755
    41174117BUGWK61103 MAC : fast/canvas/canvas-putImageData.html = CRASH PASS
     4118
     4119// New pixel tests added for bug 38788, rebaseline when webkit 38788 rolls.
     4120BUGWK38788 WIN LINUX: fast/css/border-radius-non-negative.html = IMAGE

  • trunk/Source/WebCore/ChangeLog

    r86829 r86830  
     12011-05-19  David Barr  <davidbarr@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        CSS3: We fail 'border radius sum of radii' test
     6        https://bugs.webkit.org/show_bug.cgi?id=38788
     7
     8        Ignore border-radius properties with negative values.
     9
     10        Test: fast/css/border-radius-non-negative.html
     11
     12        * WebCore.xcodeproj/project.pbxproj:
     13        * css/CSSParser.cpp:
     14        (WebCore::CSSParser::parseValue):
     15        (WebCore::CSSParser::parseBorderRadius):
     16
    1172011-05-19  Yuta Kitamura  <yutak@chromium.org>
    218

  • trunk/Source/WebCore/css/CSSParser.cpp

    r86561 r86830  
    13921392        if (num != 1 && num != 2)
    13931393            return false;
    1394         validPrimitive = validUnit(value, FLength | FPercent, m_strict);
     1394        validPrimitive = validUnit(value, FLength | FPercent | FNonNeg, m_strict);
    13951395        if (!validPrimitive)
    13961396            return false;
    … …  
    13991399        if (num == 2) {
    14001400            value = m_valueList->next();
    1401             validPrimitive = validUnit(value, FLength | FPercent, m_strict);
     1401            validPrimitive = validUnit(value, FLength | FPercent | FNonNeg, m_strict);
    14021402            if (!validPrimitive)
    14031403                return false;
    … …  
    49664966            return false;
    49674967
    4968         if (!validUnit(value, FLength | FPercent, m_strict))
     4968        if (!validUnit(value, FLength | FPercent | FNonNeg, m_strict))
    49694969            return false;
    49704970
Note: See TracChangeset for help on using the changeset viewer.