Changeset 86904 in webkit


Ignore:
Timestamp:
May 19, 2011 4:17:00 PM (13 years ago)
Author:
jer.noble@apple.com
Message:

2011-05-18 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
https://bugs.webkit.org/show_bug.cgi?id=61109

  • media/video-src-invalid-poster-expected.txt: Added.
  • media/video-src-invalid-poster.html: Added.

2011-05-18 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
https://bugs.webkit.org/show_bug.cgi?id=61109

Test: media/video-src-invalid-poster.html

In the case where no video sources are playable, update the display state and
renderer, allowing the poster image to display.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::waitForSourceChange):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r86899 r86904  
     12011-05-18  Jeremy Noble  <jer.noble@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Poster is not shown in Safari for video element with no playable source elements.
     6        https://bugs.webkit.org/show_bug.cgi?id=61109
     7
     8        * media/video-src-invalid-poster-expected.txt: Added.
     9        * media/video-src-invalid-poster.html: Added.
     10
    1112011-05-19  Andrew Wilson  <atwilson@chromium.org>
    212
  • trunk/Source/WebCore/ChangeLog

    r86899 r86904  
     12011-05-18  Jeremy Noble  <jer.noble@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Poster is not shown in Safari for video element with no playable source elements.
     6        https://bugs.webkit.org/show_bug.cgi?id=61109
     7
     8        Test: media/video-src-invalid-poster.html
     9
     10        In the case where no video sources are playable, update the display state and
     11        renderer, allowing the poster image to display.
     12
     13        * html/HTMLMediaElement.cpp:
     14        (WebCore::HTMLMediaElement::waitForSourceChange):
     15
    1162011-05-19  Andrew Wilson  <atwilson@chromium.org>
    217
  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r86501 r86904  
    773773    // 6.18 - Set the element's delaying-the-load-event flag to false. This stops delaying the load event.
    774774    setShouldDelayLoadEvent(false);
     775
     776    updateDisplayState();
     777
     778    if (renderer())
     779        renderer()->updateFromElement();
    775780}
    776781
Note: See TracChangeset for help on using the changeset viewer.