Changeset 86970 in webkit


Ignore:
Timestamp:
May 20, 2011 11:30:35 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-05-20 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createObjectStore should throw if name is null
​https://bugs.webkit.org/show_bug.cgi?id=58465

  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt: Added.
  • storage/indexeddb/mozilla/create-objectstore-null-name.html: Added.

2011-05-20 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createObjectStore should throw if name is null
​https://bugs.webkit.org/show_bug.cgi?id=58465

Test: storage/indexeddb/mozilla/create-objectstore-null-name.html

  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore):
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r86966 r86970  
     12011-05-20  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        IndexedDB createObjectStore should throw if name is null
     6        https://bugs.webkit.org/show_bug.cgi?id=58465
     7
     8        * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt: Added.
     9        * storage/indexeddb/mozilla/create-objectstore-null-name.html: Added.
     10
    1112011-05-20  Xiaomei Ji  <xji@chromium.org>
    212

  • trunk/Source/WebCore/ChangeLog

    r86966 r86970  
     12011-05-20  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        IndexedDB createObjectStore should throw if name is null
     6        https://bugs.webkit.org/show_bug.cgi?id=58465
     7
     8        Test: storage/indexeddb/mozilla/create-objectstore-null-name.html
     9
     10        * storage/IDBDatabase.idl:
     11        * storage/IDBDatabaseBackendImpl.cpp:
     12        (WebCore::IDBDatabaseBackendImpl::createObjectStore):
     13
    1142011-05-20  Xiaomei Ji  <xji@chromium.org>
    215

  • trunk/Source/WebCore/storage/IDBDatabase.idl

    r84789 r86970  
    4040        attribute EventListener onversionchange;
    4141
    42         IDBObjectStore createObjectStore(in DOMString name, in [Optional] OptionsObject options)
     42        IDBObjectStore createObjectStore(in [ConvertNullToNullString] DOMString name, in [Optional] OptionsObject options)
    4343            raises (IDBDatabaseException);
    4444        void deleteObjectStore(in DOMString name)

  • trunk/Source/WebCore/storage/IDBDatabaseBackendImpl.cpp

    r83443 r86970  
    102102    ASSERT(transactionPtr->mode() == IDBTransaction::VERSION_CHANGE);
    103103
     104    if (name.isNull()) {
     105        ec = IDBDatabaseException::NON_TRANSIENT_ERR;
     106        return 0;
     107    }
    104108    if (m_objectStores.contains(name)) {
    105109        ec = IDBDatabaseException::CONSTRAINT_ERR;
Note: See TracChangeset for help on using the changeset viewer.