Changeset 87022 in webkit

Timestamp:

May 21, 2011 3:30:01 PM (13 years ago)

Author:

jer.noble@apple.com

Message:

2011-05-21 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
​https://bugs.webkit.org/show_bug.cgi?id=61027

• platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.

2011-05-21 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
​https://bugs.webkit.org/show_bug.cgi?id=61027

• dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be

synchronous, so make sure to check whether the current element is
in the DOM before dispatching.

2011-05-21 Jeremy Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
​https://bugs.webkit.org/show_bug.cgi?id=61027

• WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the

exit functions (was calling the enter functions).

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/Skipped (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-21  Jeremy Noble  <jer.noble@apple.com>
+
+        Reviewed by Eric Carlson.
+
+        WebKit2: fix failing fullscreen/full-screen-remove* tests.
+        https://bugs.webkit.org/show_bug.cgi?id=61027
+
+        * platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.
+
 2011-05-21  Justin Schuh  <jschuh@chromium.org>
 

trunk/LayoutTests/platform/mac-wk2/Skipped

@@ -359 +359 @@
 fast/text/offsetForPosition-complex-fallback.html
 fast/text/reset-drag-on-mouse-down.html
-fullscreen/full-screen-cancel.html
 http/tests/local/blob/send-hybrid-blob.html
 http/tests/local/drag-over-remote-content.html
@@ -1660 +1659 @@
 inspector/console/console-long-eval-crash.html
 
-# WebKit2 needs fullscreen support
-# https://bugs.webkit.org/show_bug.cgi?id=56318
-fullscreen/
+# WebKit2 needs fake key event support
+fullscreen/full-screen-frameset.html
+fullscreen/full-screen-keyboard-disabled.html
+fullscreen/full-screen-keyboard-enabled.html
 
 # WebKit2 needs to support synchronous creation of about:blank/data:url frames

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-21  Jeremy Noble  <jer.noble@apple.com>
+
+        Reviewed by Eric Carlson.
+
+        WebKit2: fix failing fullscreen/full-screen-remove* tests.
+        https://bugs.webkit.org/show_bug.cgi?id=61027
+
+        * dom/Document.cpp:
+        (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be
+            synchronous, so make sure to check whether the current element is
+            in the DOM before dispatching.
+
 2011-05-21  Gavin Peters  <gavinp@chromium.org>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -4987 +4987 @@
         if (!element)
             element = documentElement();
-        
-        element->dispatchEvent(Event::create(eventNames().webkitfullscreenchangeEvent, true, false));
 
         // If the element was removed from our tree, also message the documentElement.
         if (!contains(element.get()))
             m_fullScreenChangeEventTargetQueue.append(documentElement());
+        
+        element->dispatchEvent(Event::create(eventNames().webkitfullscreenchangeEvent, true, false));
     }
 }

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-05-21  Jeremy Noble  <jer.noble@apple.com>
+
+        Reviewed by Eric Carlson.
+
+        WebKit2: fix failing fullscreen/full-screen-remove* tests.
+        https://bugs.webkit.org/show_bug.cgi?id=61027
+
+        * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
+        (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the 
+            exit functions (was calling the enter functions).
+
 2011-05-20  Jeremy Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp

@@ -62 +62 @@
 void InjectedBundlePageFullScreenClient::exitFullScreenForElement(WebPage *page, WebCore::Element *element)
 {
-    if (m_client.enterFullScreenForElement) {
+    if (m_client.exitFullScreenForElement) {
         RefPtr<InjectedBundleNodeHandle> nodeHandle = InjectedBundleNodeHandle::getOrCreate(element);
-        m_client.enterFullScreenForElement(toAPI(page), toAPI(nodeHandle.get()));
+        m_client.exitFullScreenForElement(toAPI(page), toAPI(nodeHandle.get()));
     } else
         page->send(Messages::WebFullScreenManagerProxy::ExitFullScreen());