Changeset 87059 in webkit

Timestamp:

May 23, 2011 1:07:04 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-05-23 Syed Idris Shah <​syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

GraphicsContext3DInternal object should be called for getAttachedShaders.
[Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
​https://bugs.webkit.org/show_bug.cgi?id=61202

LayoutTests/fast/canvas/webgl/gl-object-get-calls.html

getAttachedShaders should be called on GraphicsContext3DInternal instance.
It was left out by mistake.

• platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsContext3DQt.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-23  Syed Idris Shah  <syed.idris-shah@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        GraphicsContext3DInternal object should be called for getAttachedShaders.
+        [Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
+        https://bugs.webkit.org/show_bug.cgi?id=61202 
+
+        LayoutTests/fast/canvas/webgl/gl-object-get-calls.html
+
+        getAttachedShaders should be called on GraphicsContext3DInternal instance.
+        It was left out by mistake.
+
+        * platform/graphics/qt/GraphicsContext3DQt.cpp: 
+        (WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.
+
 2011-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp

@@ -773 +773 @@
 
     m_internal->m_glWidget->makeCurrent();
-    getAttachedShaders(program, maxCount, count, shaders);
+    m_internal->getAttachedShaders(program, maxCount, count, shaders);
 }