Changeset 87090 in webkit

Timestamp:

May 23, 2011 12:47:53 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update ImageDecoder::create to match sniffing spec
​https://bugs.webkit.org/show_bug.cgi?id=47683

This test actually passes before this patch anyway. I don't think this
patch is actually observable in any meaningful way.

• fast/images/busted-oval-does-not-render-expected.txt: Added.
• fast/images/busted-oval-does-not-render.html: Added.
• fast/images/resources/busted-oval.png: Added.

2011-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update ImageDecoder::create to match sniffing spec
​https://bugs.webkit.org/show_bug.cgi?id=47683

This change is difficult to test. We're making this change to comply
with standards even if the change is difficult to observe. (This patch
also causes us to match Firefox.)

Test: fast/images/busted-oval-does-not-render.html

• platform/image-decoders/ImageDecoder.cpp:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/images/busted-oval-does-not-render-expected.txt (added)
• LayoutTests/fast/images/busted-oval-does-not-render.html (added)
• LayoutTests/fast/images/resources/busted-oval.png (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/image-decoders/ImageDecoder.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-23  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Update ImageDecoder::create to match sniffing spec
+        https://bugs.webkit.org/show_bug.cgi?id=47683
+
+        This test actually passes before this patch anyway.  I don't think this
+        patch is actually observable in any meaningful way.
+
+        * fast/images/busted-oval-does-not-render-expected.txt: Added.
+        * fast/images/busted-oval-does-not-render.html: Added.
+        * fast/images/resources/busted-oval.png: Added.
+
 2011-05-23  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-23  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Update ImageDecoder::create to match sniffing spec
+        https://bugs.webkit.org/show_bug.cgi?id=47683
+
+        This change is difficult to test.  We're making this change to comply
+        with standards even if the change is difficult to observe.  (This patch
+        also causes us to match Firefox.)
+
+        Test: fast/images/busted-oval-does-not-render.html
+
+        * platform/image-decoders/ImageDecoder.cpp:
+
 2011-05-23  Ruben  <chromium@hybridsource.org>
 

trunk/Source/WebCore/platform/image-decoders/ImageDecoder.cpp

@@ -58 +58 @@
 bool matchesGIFSignature(char* contents)
 {
-    return !memcmp(contents, "GIF8", 4);
+    return !memcmp(contents, "GIF87a", 6) || !memcmp(contents, "GIF89a", 6);
 }
 
 bool matchesPNGSignature(char* contents)
 {
-    return !memcmp(contents, "\x89\x50\x4E\x47", 4);
+    return !memcmp(contents, "\x89\x50\x4E\x47\x0D\x0A\x1A\x0A", 8);
 }