Changeset 87093 in webkit

Timestamp:

May 23, 2011 1:21:35 PM (13 years ago)

Author:

weinig@apple.com

Message:

2011-05-23 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Terminating a WebProcess should work even while a page is being closed
<rdar://problem/8934632>
​https://bugs.webkit.org/show_bug.cgi?id=61299

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess): Change validity check to only check for process validity, since terminating the process of a page that is closed or is closing is acceptable behavior.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-05-23  Sam Weinig  <sam@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Terminating a WebProcess should work even while a page is being closed
+        <rdar://problem/8934632>
+        https://bugs.webkit.org/show_bug.cgi?id=61299
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::terminateProcess):
+        Change validity check to only check for process validity, since terminating the process of a page that
+        is closed or is closing is acceptable behavior.
+
 2011-05-23  Jessie Berlin  <jberlin@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -1035 +1035 @@
 void WebPageProxy::terminateProcess()
 {
-    if (!isValid())
+    // NOTE: This uses a check of m_isValid rather than calling isValid() since
+    // we want this to run even for pages being closed or that already closed.
+    if (!m_isValid)
         return;