Changeset 87107 in webkit

Timestamp:

May 23, 2011 4:52:03 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-05-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot should give more details about the failures in IRC
​https://bugs.webkit.org/show_bug.cgi?id=61233

With this patch, sheriffbot will annonce the set of failing tests,
which might help folks triage the problem.

• Scripts/webkitpy/tool/commands/sheriffbot.py:
• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/failuremap.py (modified) (1 diff)
• Scripts/webkitpy/common/net/failuremap_unittest.py (modified) (1 diff)
• Scripts/webkitpy/tool/bot/sheriff.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/sheriffbot.py (modified) (2 diffs)
• Scripts/webkitpy/tool/commands/sheriffbot_unittest.py (modified) (1 diff)
• Scripts/webkitpy/tool/mocktool.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-23  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        sheriffbot should give more details about the failures in IRC
+        https://bugs.webkit.org/show_bug.cgi?id=61233
+
+        With this patch, sheriffbot will annonce the set of failing tests,
+        which might help folks triage the problem.
+
+        * Scripts/webkitpy/tool/commands/sheriffbot.py:
+        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
+
 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/Scripts/webkitpy/common/net/failuremap.py

@@ -60 +60 @@
         return sorted(result)
 
+    def failing_tests(self):
+        return set(sum([self.tests_failing_for(revision) for revision in self.failing_revisions()], []))
+
     def _old_failures(self, is_old_failure):
         return filter(lambda revision: is_old_failure(revision),

trunk/Tools/Scripts/webkitpy/common/net/failuremap_unittest.py

@@ -75 +75 @@
         failure_map = self._make_failure_map()
         self.assertEquals(failure_map.tests_failing_for(1234), [u'test1'])
+
+    def test_failing_tests(self):
+        failure_map = self._make_failure_map()
+        self.assertEquals(failure_map.failing_tests(), set([u'test1']))

trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py

@@ -52 +52 @@
         self._tool.irc().post(irc_message)
 
+    def post_irc_summary(self, failure_map):
+        failing_tests = failure_map.failing_tests()
+        if not failing_tests:
+            return
+        test_list_limit = 5
+        irc_message = "New failures: %s" % ", ".join(sorted(failing_tests)[:test_list_limit])
+        if len(failing_tests) > test_list_limit:
+            irc_message += " (and more...)"
+        self._tool.irc().post(irc_message)
+
     def post_rollout_patch(self, svn_revision_list, rollout_reason):
         # Ensure that svn revisions are numbers (and not options to

trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py

@@ -82 +82 @@
         for revision in failing_revisions:
             builders = failure_map.builders_failing_for(revision)
-            tests = failure_map.tests_failing_for(revision)
             try:
                 commit_info = self._tool.checkout().commit_info_for_revision(revision)
@@ -93 +92 @@
                 for builder in builders:
                     self._tool.status_server.update_svn_revision(revision, builder.name())
+        self._sheriff.post_irc_summary(failure_map)
         return True
 

trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py

@@ -45 +45 @@
             "next_work_item": "",
             "process_work_item": """MOCK: irc.post: abarth, darin, eseidel: http://trac.webkit.org/changeset/29837 might have broken Builder1
+MOCK: irc.post: New failures: mock-test-1
 """,
-            "handle_unexpected_error": "Mock error message\n"
+            "handle_unexpected_error": "Mock error message\n",
         }
         self.assert_queue_outputs(SheriffBot(), work_item=mock_work_item, expected_stderr=expected_stderr)
+
+    def test_many_failing_tests(self):
+        tool = MockTool()
+        mock_work_item = MockFailureMap(tool.buildbot)
+        mock_work_item.failing_tests = lambda: set(["test1", "test2", "test3", "test4", "test5", "test6", "test7"])
+        expected_stderr = {
+            "begin_work_queue": self._default_begin_work_queue_stderr("sheriff-bot", tool.scm().checkout_root),
+            "next_work_item": "",
+            "process_work_item": """MOCK: irc.post: abarth, darin, eseidel: http://trac.webkit.org/changeset/29837 might have broken Builder1
+MOCK: irc.post: New failures: test1, test2, test3, test4, test5 (and more...)
+""",
+            "handle_unexpected_error": "Mock error message\n",
+        }
+        self.assert_queue_outputs(SheriffBot(), work_item=mock_work_item, expected_stderr=expected_stderr)

trunk/Tools/Scripts/webkitpy/tool/mocktool.py

@@ -413 +413 @@
         return ["mock-test-1"]
 
+    def failing_tests(self):
+        return set(["mock-test-1"])
+
 
 class MockBuildBot(object):