Changeset 87163 in webkit

Timestamp:

May 24, 2011 10:12:09 AM (13 years ago)

Author:

Philippe Normand

Message:

2011-05-24 Philippe Normand <​pnormand@igalia.com>

Reviewed by Andres Kling.

JSAudioContextCustom doesn't encode errors
​https://bugs.webkit.org/show_bug.cgi?id=61357

Fix AudioContext return values

• bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSAudioContextCustom.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-24  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Andres Kling.
+
+        JSAudioContextCustom doesn't encode errors
+        https://bugs.webkit.org/show_bug.cgi?id=61357
+
+        Fix AudioContext return values
+
+        * bindings/js/JSAudioContextCustom.cpp:
+        (WebCore::JSAudioContextConstructor::constructJSAudioContext):
+
 2011-05-24  Rob Buis  <rbuis@rim.com>
 

trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp

@@ -53 +53 @@
     JSAudioContextConstructor* jsConstructor = static_cast<JSAudioContextConstructor*>(exec->callee());
     if (!jsConstructor)
-      return throwError(exec, createReferenceError(exec, "AudioContext constructor callee is unavailable"));
+        return throwVMError(exec, createReferenceError(exec, "AudioContext constructor callee is unavailable"));
 
     ScriptExecutionContext* scriptExecutionContext = jsConstructor->scriptExecutionContext();
     if (!scriptExecutionContext)
-      return throwError(exec, createReferenceError(exec, "AudioContext constructor script execution context is unavailable"));
+        return throwVMError(exec, createReferenceError(exec, "AudioContext constructor script execution context is unavailable"));
         
     if (!scriptExecutionContext->isDocument())
-      return throwError(exec, createReferenceError(exec, "AudioContext constructor called in a script execution context which is not a document"));
+        return throwVMError(exec, createReferenceError(exec, "AudioContext constructor called in a script execution context which is not a document"));
 
     Document* document = static_cast<Document*>(scriptExecutionContext);
@@ -73 +73 @@
         // new AudioContext(in unsigned long numberOfChannels, in unsigned long numberOfFrames, in float sampleRate);
         if (exec->argumentCount() < 3)
-            return throwError(exec, createSyntaxError(exec, "Not enough arguments"));
+            return throwVMError(exec, createSyntaxError(exec, "Not enough arguments"));
 
         unsigned numberOfChannels = exec->argument(0).toInt32(exec);
@@ -83 +83 @@
 
     if (!audioContext.get())
-        return throwError(exec, createReferenceError(exec, "Error creating AudioContext"));
+        return throwVMError(exec, createReferenceError(exec, "Error creating AudioContext"));
 
     return JSValue::encode(asObject(toJS(exec, jsConstructor->globalObject(), audioContext.get())));