Changeset 87168 in webkit

Timestamp:

May 24, 2011 10:43:55 AM (13 years ago)

Author:

tony@chromium.org

Message:

2011-05-24 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

fix render overflow computation for input type=range
​https://bugs.webkit.org/show_bug.cgi?id=61132

• fast/forms/slider-hit-testing-expected.txt: Added.
• fast/forms/slider-hit-testing.html: Added.

2011-05-24 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

fix render overflow computation for input type=range
​https://bugs.webkit.org/show_bug.cgi?id=61132

Test: fast/forms/slider-hit-testing.html

We need to clear m_overflow otherwise we use the first
size of the slider for hit testing (i.e., changes to the size
cause problems). This only shows up if the thumb isn't contained
in the bounds of the slider. Making the range have a smaller height
than the thumb shows the bug.

• rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Clear the overflow during layout

so we re-compute the overflow based on the current size of the
slider.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/slider-hit-testing-expected.txt (added)
• LayoutTests/fast/forms/slider-hit-testing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderSlider.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-24  Tony Chang  <tony@chromium.org>
+
+        Reviewed by James Robinson.
+
+        fix render overflow computation for input type=range
+        https://bugs.webkit.org/show_bug.cgi?id=61132
+
+        * fast/forms/slider-hit-testing-expected.txt: Added.
+        * fast/forms/slider-hit-testing.html: Added.
+
 2011-05-24  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-24  Tony Chang  <tony@chromium.org>
+
+        Reviewed by James Robinson.
+
+        fix render overflow computation for input type=range
+        https://bugs.webkit.org/show_bug.cgi?id=61132
+
+        Test: fast/forms/slider-hit-testing.html
+
+        We need to clear m_overflow otherwise we use the first
+        size of the slider for hit testing (i.e., changes to the size
+        cause problems).  This only shows up if the thumb isn't contained
+        in the bounds of the slider.  Making the range have a smaller height
+        than the thumb shows the bug.
+
+        * rendering/RenderSlider.cpp:
+        (WebCore::RenderSlider::layout): Clear the overflow during layout
+            so we re-compute the overflow based on the current size of the
+            slider.
+
 2011-05-24  Alok Priyadarshi  <alokp@chromium.org>
 

trunk/Source/WebCore/rendering/RenderSlider.cpp

@@ -154 +154 @@
     updateLayerTransform();
 
+    m_overflow.clear();
+
     if (thumb) {
         if (oldSize != size())