Changeset 87218 in webkit

Timestamp:

May 24, 2011 3:22:26 PM (13 years ago)

Author:

rniwa@webkit.org

Message:

2011-05-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

[chromium] selectstart-by-drag.html and selectstart-by-double-triple-clicks.html
fail on Windows and Linux
​https://bugs.webkit.org/show_bug.cgi?id=61377

selectstart-by-drag.html pass on Chromium Windows and Chromium Linux so don't use
the failing test expectation on Windows port.

In selectstart-by-double-triple-clicks.html, /^{\s|\s$/ isn't recognized by V8 so
replace it by /}[ \t]|[ \t]$/.

• platform/chromium/fast/events/selectstart-by-drag-expected.txt: Copied from LayoutTests/fast/events/selectstart-by-drag-expected.txt.
• fast/events/selectstart-by-double-triple-clicks.html:
• platform/chromium/test_expectations.txt:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/selectstart-by-double-triple-clicks.html (modified) (1 diff)
• platform/chromium/fast/events/selectstart-by-drag-expected.txt (added)
• platform/chromium/test_expectations.txt (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Tony Chang.
+
+        [chromium] selectstart-by-drag.html and selectstart-by-double-triple-clicks.html
+        fail on Windows and Linux
+        https://bugs.webkit.org/show_bug.cgi?id=61377
+
+        selectstart-by-drag.html pass on Chromium Windows and Chromium Linux so don't use
+        the failing test expectation on Windows port.
+
+        In selectstart-by-double-triple-clicks.html, /^\s|\s$/ isn't recognized by V8 so
+        replace it by /^[ \t]|[ \t]$/.
+
+        * platform/chromium/fast/events/selectstart-by-drag-expected.txt: Copied from
+        LayoutTests/fast/events/selectstart-by-drag-expected.txt.
+        * fast/events/selectstart-by-double-triple-clicks.html:
+        * platform/chromium/test_expectations.txt:
+
 2011-05-24  James Simonsen  <simonjam@chromium.org>
 

trunk/LayoutTests/fast/events/selectstart-by-double-triple-clicks.html

@@ -14 +14 @@
     document.write(title + ': ');
     var actualSelectionType = window.getSelection().isCollapsed ? 'caret' : 'range';
-    var actualString = window.getSelection().toString().replace(/^\s*|\s*$/, '');
+    var actualString = window.getSelection().toString().replace(/^[ \t]*|[ \t]*$/, '');
 
     if (selectStartCount != expectedCount)

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -4122 +4122 @@
 BUGWK61326 : fast/storage/storage-detached-iframe.html = CRASH
 
-BUGCR83682 WIN LINUX : fast/events/selectstart-by-double-triple-clicks.html = TEXT
-BUGCR83682 WIN LINUX : fast/events/selectstart-by-drag.html = TEXT
-
 BUGCR83683 : fast/dom/HTMLLinkElement/prerender.html = TEXT