Changeset 87274 in webkit
- Timestamp:
- May 24, 2011 11:03:09 PM (13 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 3 deleted
- 33 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/ChangeLog
r87189 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * configure.ac: Added INPUT_COLOR feature flag. 9 1 10 2011-05-24 Jay Civelli <jcivelli@chromium.org> 2 11 -
trunk/LayoutTests/ChangeLog
r87273 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed. 9 * fast/forms/ValidityState-typeMismatch-color.html: Removed. 10 * fast/forms/color/input-value-sanitization-color-expected.txt: Added. 11 * fast/forms/color/input-value-sanitization-color.html: Added. Tests 12 sanitization algorithm for input type=color. 13 * fast/forms/input-type-change3-expected.txt: 14 * fast/forms/input-widths-expected.txt: 15 * fast/forms/input-widths.html: Removed type=color because it 16 is no loger a text input type. 17 * fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Changed to range input type. 18 * fast/forms/script-tests/ValidityState-typeMismatch-color.js: Removed. 19 * fast/forms/script-tests/input-type-change3.js: 20 * platform/gtk/Skipped: Skip fast/forms/color. 21 * platform/mac/Skipped: Skip fast/forms/color. 22 * platform/qt/Skipped: Skip fast/forms/color. 23 * platform/win/Skipped: Skip fast/forms/color. 24 1 25 2011-05-24 Csaba Osztrogonác <ossy@webkit.org> 2 26 -
trunk/LayoutTests/fast/forms/input-type-change3-expected.txt
r82534 r87274 14 14 PASS input.type for " button " is correctly "text". 15 15 PASS input.type for "checkbox" is correctly "checkbox". 16 PASS input.type for "color" is correctly "color".17 16 PASS input.type for "date" is correctly "date". 18 17 PASS input.type for "datetime" is correctly "datetime". -
trunk/LayoutTests/fast/forms/input-widths-expected.txt
r76567 r87274 6 6 PASS document.getElementById("tel").offsetWidth is baseWidth 7 7 PASS document.getElementById("url").offsetWidth is baseWidth 8 PASS document.getElementById("color").offsetWidth is baseWidth9 8 PASS document.getElementById("date").offsetWidth is baseWidth 10 9 PASS document.getElementById("datetime").offsetWidth is baseWidth -
trunk/LayoutTests/fast/forms/input-widths.html
r76567 r87274 39 39 40 40 // The folloiwng types should be removed when dedicated UIs are implemented. 41 shouldBe('document.getElementById("color").offsetWidth', 'baseWidth');42 41 shouldBe('document.getElementById("date").offsetWidth', 'baseWidth'); 43 42 shouldBe('document.getElementById("datetime").offsetWidth', 'baseWidth'); -
trunk/LayoutTests/fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js
r48552 r87274 2 2 3 3 var input = document.createElement('input'); 4 input.type = ' color';5 input.pattern = ' #[0-9A-F]{6}'; // Restrict to capital letters6 input.value = ' #0099ff';4 input.type = 'range'; 5 input.pattern = '[0-9]'; // Restrict to single digit 6 input.value = '11'; 7 7 8 // pattern doesn't work for type= color8 // pattern doesn't work for type=range 9 9 shouldBe('input.validity.patternMismatch', 'false'); 10 10 -
trunk/LayoutTests/fast/forms/script-tests/input-type-change3.js
r82534 r87274 28 28 check(" button ", "text"); 29 29 check("checkbox", "checkbox"); 30 check("color", "color");31 30 check("date", "date"); 32 31 check("datetime", "datetime"); -
trunk/LayoutTests/platform/gtk/Skipped
r87207 r87274 277 277 # StorageTracker is not enabled. 278 278 storage/domstorage/localstorage/storagetracker 279 280 # Color input is not yet enabled. 281 fast/forms/color 279 282 280 283 # Speech input is not yet enabled. -
trunk/LayoutTests/platform/mac/Skipped
r87029 r87274 198 198 http/tests/multipart/policy-ignore-crash.php 199 199 200 # Color input is not yet enabled. 201 fast/forms/color 202 200 203 # Speech input is not yet enabled. 201 204 fast/speech -
trunk/LayoutTests/platform/qt/Skipped
r87248 r87274 1974 1974 fast/forms/input-number-large-padding.html 1975 1975 1976 # Color input is not yet enabled. 1977 fast/forms/color 1978 1976 1979 # Speech input is not yet enabled. 1977 1980 fast/speech -
trunk/LayoutTests/platform/win/Skipped
r87205 r87274 1062 1062 fast/forms/input-spinbutton-capturing.html 1063 1063 1064 # Color input is not yet enabled. 1065 fast/forms/color 1066 1064 1067 # Speech input is not yet enabled. 1065 1068 fast/speech -
trunk/Source/JavaScriptCore/ChangeLog
r87269 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag. 9 1 10 2011-05-24 Kevin Ollivier <kevino@theolliviers.com> 2 11 -
trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
r87213 r87274 86 86 87 87 ENABLE_INDEXED_DATABASE = ; 88 ENABLE_INPUT_COLOR = ; 88 89 ENABLE_INPUT_SPEECH = ; 89 90 ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER; … … 135 136 ENABLE_XSLT = ENABLE_XSLT; 136 137 137 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_ SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);138 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); -
trunk/Source/WebCore/ChangeLog
r87268 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 Test: fast/forms/color/input-value-sanitization-color.html 9 10 * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag. 11 * GNUmakefile.am: Added COLOR_INPUT feature flag. 12 * features.pri: Added COLOR_INPUT feature flag. 13 * html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag. 14 (WebCore::ColorInputType::isColorControl): Added. 15 (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec. 16 (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec. 17 * html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag. 18 (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType. 19 * html/InputType.cpp: 20 (WebCore::InputType::isColorControl): Added. 21 * html/InputType.h: 22 1 23 2011-05-24 Steve Lacey <sjl@chromium.org> 2 24 -
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
r87189 r87274 86 86 87 87 ENABLE_INDEXED_DATABASE = ; 88 ENABLE_INPUT_COLOR = ; 88 89 ENABLE_INPUT_SPEECH = ; 89 90 ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER; … … 135 136 ENABLE_XSLT = ENABLE_XSLT; 136 137 137 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_ SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_MHTML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);138 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_MHTML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); -
trunk/Source/WebCore/GNUmakefile.am
r87189 r87274 274 274 275 275 # ---- 276 # Color Input API support 277 # ---- 278 if ENABLE_INPUT_COLOR 279 FEATURE_DEFINES += ENABLE_INPUT_COLOR=1 280 webcore_cppflags += -DENABLE_INPUT_COLOR=1 281 else 282 webcore_cppflags += -DENABLE_INPUT_COLOR=0 283 endif # END ENABLE_INPUT_COLOR 284 285 # ---- 276 286 # Speech Input API support 277 287 # ---- -
trunk/Source/WebCore/features.pri
r87189 r87274 70 70 !contains(DEFINES, ENABLE_BLOB=.): DEFINES += ENABLE_BLOB=1 71 71 !contains(DEFINES, ENABLE_NOTIFICATIONS=.): DEFINES += ENABLE_NOTIFICATIONS=1 72 !contains(DEFINES, ENABLE_INPUT_COLOR=.): DEFINES += ENABLE_INPUT_COLOR=0 72 73 !contains(DEFINES, ENABLE_INPUT_SPEECH=.): DEFINES += ENABLE_INPUT_SPEECH=0 73 74 !contains(DEFINES, ENABLE_INSPECTOR=.): DEFINES += ENABLE_INSPECTOR=1 -
trunk/Source/WebCore/html/ColorInputType.cpp
r73139 r87274 37 37 #include <wtf/text/WTFString.h> 38 38 39 #if ENABLE(INPUT_COLOR) 40 39 41 namespace WebCore { 40 42 … … 58 60 } 59 61 62 bool ColorInputType::isColorControl() const 63 { 64 return true; 65 } 66 60 67 const AtomicString& ColorInputType::formControlType() const 61 68 { 62 69 return InputTypeNames::color(); 63 }64 65 bool ColorInputType::typeMismatchFor(const String& value) const66 {67 // FIXME: Should not accept an empty value. Remove it when we implement value68 // sanitization for type=color.69 if (value.isEmpty())70 return false;71 return !isValidColorString(value);72 }73 74 bool ColorInputType::typeMismatch() const75 {76 // FIXME: Should return false. We don't implement value sanitization for77 // type=color yet.78 String value = element()->value();79 return !value.isEmpty() && !isValidColorString(value);80 70 } 81 71 … … 85 75 } 86 76 77 String ColorInputType::fallbackValue() 78 { 79 return String("#000000"); 80 } 81 82 String ColorInputType::sanitizeValue(const String& proposedValue) 83 { 84 if (proposedValue.isNull()) 85 return proposedValue; 86 87 if (!isValidColorString(proposedValue)) 88 return fallbackValue(); 89 90 return proposedValue.lower(); 91 } 92 87 93 } // namespace WebCore 94 95 #endif // ENABLE(INPUT_COLOR) -
trunk/Source/WebCore/html/ColorInputType.h
r69445 r87274 32 32 #define ColorInputType_h 33 33 34 #include "TextFieldInputType.h" 34 #include "BaseButtonInputType.h" 35 36 #if ENABLE(INPUT_COLOR) 35 37 36 38 namespace WebCore { 37 39 38 class ColorInputType : public TextFieldInputType {40 class ColorInputType : public BaseButtonInputType { 39 41 public: 40 42 static PassOwnPtr<InputType> create(HTMLInputElement*); 41 43 42 44 private: 43 ColorInputType(HTMLInputElement* element) : TextFieldInputType(element) { } 45 ColorInputType(HTMLInputElement* element) : BaseButtonInputType(element) { } 46 virtual bool isColorControl() const; 44 47 virtual const AtomicString& formControlType() const; 45 virtual bool typeMismatchFor(const String&) const;46 virtual bool typeMismatch() const;47 48 virtual bool supportsRequired() const; 49 virtual String fallbackValue(); 50 virtual String sanitizeValue(const String&); 48 51 }; 49 52 50 53 } // namespace WebCore 51 54 52 #endif // ButtonInputType_h 55 #endif // ENABLE(INPUT_COLOR) 56 57 #endif // ColorInputType_h -
trunk/Source/WebCore/html/InputType.cpp
r85998 r87274 80 80 map->add(InputTypeNames::button(), ButtonInputType::create); 81 81 map->add(InputTypeNames::checkbox(), CheckboxInputType::create); 82 #if ENABLE(INPUT_COLOR) 82 83 map->add(InputTypeNames::color(), ColorInputType::create); 84 #endif 83 85 map->add(InputTypeNames::date(), DateInputType::create); 84 86 map->add(InputTypeNames::datetime(), DateTimeInputType::create); … … 636 638 } 637 639 640 #if ENABLE(INPUT_COLOR) 641 bool InputType::isColorControl() const 642 { 643 return false; 644 } 645 #endif 646 638 647 bool InputType::shouldRespectHeightAndWidthAttributes() 639 648 { … … 658 667 } 659 668 669 #if ENABLE(INPUT_COLOR) 660 670 const AtomicString& color() 661 671 { … … 663 673 return name; 664 674 } 675 #endif 665 676 666 677 const AtomicString& date() -
trunk/Source/WebCore/html/InputType.h
r87067 r87274 89 89 // scattered code with special cases for various types. 90 90 91 #if ENABLE(INPUT_COLOR) 92 virtual bool isColorControl() const; 93 #endif // ENABLE(INPUT_COLOR) 91 94 virtual bool isCheckbox() const; 92 95 virtual bool isEmailField() const; … … 260 263 const AtomicString& button(); 261 264 const AtomicString& checkbox(); 265 #if ENABLE(INPUT_COLOR) 262 266 const AtomicString& color(); 267 #endif 263 268 const AtomicString& date(); 264 269 const AtomicString& datetime(); -
trunk/Source/WebKit/chromium/ChangeLog
r87260 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * features.gypi: Added INPUT_COLOR feature flag. 9 1 10 2011-05-24 Adam Barth <abarth@webkit.org> 2 11 -
trunk/Source/WebKit/chromium/features.gypi
r87189 r87274 63 63 'ENABLE_ICONDATABASE=0', 64 64 'ENABLE_INDEXED_DATABASE=1', 65 'ENABLE_INPUT_COLOR=1', 65 66 'ENABLE_INPUT_SPEECH=1', 66 67 'ENABLE_JAVASCRIPT_DEBUGGER=1', -
trunk/Source/WebKit/mac/ChangeLog
r87260 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag. 9 1 10 2011-05-24 Adam Barth <abarth@webkit.org> 2 11 -
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
r87213 r87274 88 88 89 89 ENABLE_INDEXED_DATABASE = ; 90 ENABLE_INPUT_COLOR = ; 90 91 ENABLE_INPUT_SPEECH = ; 91 92 ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER; … … 136 137 ENABLE_XSLT = ENABLE_XSLT; 137 138 138 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_ SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);139 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); -
trunk/Source/WebKit2/ChangeLog
r87272 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag. 9 1 10 2011-05-24 Maciej Stachowiak <mjs@apple.com> 2 11 -
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
r87213 r87274 88 88 89 89 ENABLE_INDEXED_DATABASE = ; 90 ENABLE_INPUT_COLOR = ; 90 91 ENABLE_INPUT_SPEECH = ; 91 92 ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER; … … 136 137 ENABLE_XSLT = ENABLE_XSLT; 137 138 138 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_ SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);139 FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); -
trunk/Tools/ChangeLog
r87257 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * Scripts/build-webkit: Added INPUT_COLOR feature flag. 9 1 10 2011-05-24 Greg Simon <gregsimon@chromium.org> 2 11 -
trunk/Tools/Scripts/build-webkit
r87189 r87274 88 88 $imageResizerSupport, 89 89 $indexedDatabaseSupport, 90 $inputColorSupport, 90 91 $inputSpeechSupport, 91 92 $javaScriptDebuggerSupport, … … 195 196 define => "ENABLE_INDEXED_DATABASE", default => 0, value => \$indexedDatabaseSupport }, 196 197 198 { option => "input-color", desc => "Color Input support", 199 define => "ENABLE_INPUT_COLOR", default => 0, value => \$inputColorSupport }, 200 197 201 { option => "input-speech", desc => "Speech Input API support", 198 202 define => "ENABLE_INPUT_SPEECH", default => 0, value => \$inputSpeechSupport }, -
trunk/WebKitLibraries/ChangeLog
r86369 r87274 1 2011-05-24 Keishi Hattori <keishi@webkit.org> 2 3 Reviewed by Kent Tamura. 4 5 Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer. 6 https://bugs.webkit.org/show_bug.cgi?id=61273 7 8 * win/tools/vsprops/FeatureDefines.vsprops: Added INPUT_COLOR feature flag. 9 * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added INPUT_COLOR feature flag. 10 1 11 2011-05-12 Jessie Berlin <jberlin@apple.com> 2 12 -
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
r85719 r87274 10 10 <Tool 11 11 Name="VCCLCompilerTool" 12 PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_ SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_ANIMATION);$(ENABLE_SVG_AS_IMAGE);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SVG_FOREIGN_OBJECT);$(ENABLE_SVG_USE);$(ENABLE_VIDEO);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)"12 PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_ANIMATION);$(ENABLE_SVG_AS_IMAGE);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SVG_FOREIGN_OBJECT);$(ENABLE_SVG_USE);$(ENABLE_VIDEO);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)" 13 13 /> 14 14 <UserMacro … … 118 118 /> 119 119 <UserMacro 120 Name="ENABLE_INPUT_COLOR" 121 Value="" 122 PerformEnvironmentSet="true" 123 /> 124 <UserMacro 120 125 Name="ENABLE_INPUT_SPEECH" 121 126 Value="" -
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
r85273 r87274 10 10 <Tool 11 11 Name="VCCLCompilerTool" 12 PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_ SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_ANIMATION);$(ENABLE_SVG_AS_IMAGE);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SVG_FOREIGN_OBJECT);$(ENABLE_SVG_USE);$(ENABLE_VIDEO);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)"12 PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_ANIMATION);$(ENABLE_SVG_AS_IMAGE);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SVG_FOREIGN_OBJECT);$(ENABLE_SVG_USE);$(ENABLE_VIDEO);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)" 13 13 /> 14 14 <UserMacro … … 118 118 /> 119 119 <UserMacro 120 Name="ENABLE_INPUT_COLOR" 121 Value="" 122 PerformEnvironmentSet="true" 123 /> 124 <UserMacro 120 125 Name="ENABLE_INPUT_SPEECH" 121 126 Value="" -
trunk/configure.ac
r87189 r87274 473 473 [],[enable_indexed_database="no"]) 474 474 AC_MSG_RESULT([$enable_indexed_database]) 475 476 # check whether to enable the color input 477 AC_MSG_CHECKING([whether to enable the color input]) 478 AC_ARG_ENABLE(input_color, 479 AC_HELP_STRING([--enable-input-color], 480 [enable the color input [default=no]]), 481 [],[enable_input_color="no"]) 482 AC_MSG_RESULT([$enable_input_color]) 475 483 476 484 # check whether to enable the speech input API … … 1109 1117 AM_CONDITIONAL([ENABLE_IMAGE_RESIZER],[test "$enable_image_resizer" = "yes"]) 1110 1118 AM_CONDITIONAL([ENABLE_INDEXED_DATABASE],[test "$enable_indexed_database" = "yes"]) 1119 AM_CONDITIONAL([ENABLE_INPUT_COLOR],[test "$enable_input_color" = "yes"]) 1111 1120 AM_CONDITIONAL([ENABLE_INPUT_SPEECH],[test "$enable_input_speech" = "yes"]) 1112 1121 AM_CONDITIONAL([ENABLE_XHTMLMP],[test "$enable_xhtmlmp" = "yes"]) … … 1224 1233 Opcode stats : $enable_opcode_stats 1225 1234 SharedWorkers support : $enable_shared_workers 1235 Color input support : $enable_input_color 1226 1236 Speech input support : $enable_input_speech 1227 1237 SVG support : $enable_svg
Note: See TracChangeset
for help on using the changeset viewer.